Skip to content

tcg-i386 cleanup and improvement, v2

Richard Henderson qemu-devel 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 25 repliesApplied

Changes v1->v2 from the cover letter

* Dropped controversial bswap changes; bswap16 continues to use rolw.
* Tidy data16 as the last of the hard-coded constants.

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/22tcg-i386: Allocate call-saved registers first.tcg/i386/tcg-target.c+9 -41 reply
2/22tcg-i386: Tidy initialization of tcg_target_call_clobber_regs.tcg/i386/tcg-target.c+6 -51 reply
3/22tcg-i386: Tidy ext8u and ext16u operations.tcg/i386/tcg-target.c+42 -266 replies
4/22tcg-i386: Tidy ext8s and ext16s operations.tcg/i386/tcg-target.c+37 -121 reply
5/22tcg-i386: Tidy bswap operations.tcg/i386/tcg-target.c+24 -280 replies
6/22tcg-i386: Tidy shift operations.tcg/i386/tcg-target.c+22 -210 replies
7/22tcg-i386: Tidy move operations.tcg/i386/tcg-target.c+24 -270 replies
8/22tcg-i386: Eliminate extra move from qemu_ld64.tcg/i386/tcg-target.c+9 -110 replies
9/22tcg-i386: Tidy jumps.tcg/i386/tcg-target.c+33 -250 replies
10/22tcg-i386: Tidy immediate arithmetic operations.tcg/i386/tcg-target.c+11 -171 reply
11/22tcg-i386: Tidy non-immediate arithmetic operations.tcg/i386/tcg-target.c+48 -301 reply
12/22tcg-i386: Tidy movi.tcg/i386/tcg-target.c+2 -11 reply
13/22tcg-i386: Tidy push/pop.tcg/i386/tcg-target.c+32 -181 reply
14/22tcg-i386: Tidy calls.tcg/i386/tcg-target.c+27 -221 reply
15/22tcg-i386: Tidy ret.tcg/i386/tcg-target.c+2 -11 reply
16/22tcg-i386: Tidy setcc.tcg/i386/tcg-target.c+2 -21 reply
17/22tcg-i386: Tidy unary arithmetic.tcg/i386/tcg-target.c+25 -131 reply
18/22tcg-i386: Tidy multiply.tcg/i386/tcg-target.c+6 -31 reply
19/22tcg-i386: Tidy xchg.tcg/i386/tcg-target.c+3 -11 reply
20/22tcg-i386: Tidy lea.tcg/i386/tcg-target.c+60 -311 reply
21/22tcg-i386: Use lea for three-operand add.tcg/i386/tcg-target.c+20 -31 reply
22/22tcg-i386: Tidy data16 prefixes.tcg/i386/tcg-target.c+13 -81 reply

Reviews trailers per patch

12 of 22 patches have a Reviewed-by or Acked-by.

PatchAurelien Jarno
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22A-b
11/22A-b
12/22A-b
13/22
14/22A-b
15/22A-b
16/22A-b
17/22A-b
18/22A-b
19/22A-b
20/22A-b
21/22A-b
22/22A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/22] tcg-i386 cleanup and improvement, v2

Changes v1->v2:
* Dropped controversial bswap changes; bswap16 continues to use rolw.
* Tidy data16 as the last of the hard-coded constants.

r~

Richard Henderson (22):
tcg-i386: Allocate call-saved registers first.
tcg-i386: Tidy initialization of tcg_target_call_clobber_regs.
tcg-i386: Tidy ext8u and ext16u operations.
tcg-i386: Tidy ext8s and ext16s operations.
tcg-i386: Tidy bswap operations.
tcg-i386: Tidy shift operations.
tcg-i386: Tidy move operations.
tcg-i386: Eliminate extra move from qemu_ld64.
tcg-i386: Tidy jumps.
tcg-i386: Tidy immediate arithmetic operations.
tcg-i386: Tidy non-immediate arithmetic operations.
tcg-i386: Tidy movi.
tcg-i386: Tidy push/pop.
tcg-i386: Tidy calls.
tcg-i386: Tidy ret.
tcg-i386: Tidy setcc.
tcg-i386: Tidy unary arithmetic.
tcg-i386: Tidy multiply.
tcg-i386: Tidy xchg.
tcg-i386: Tidy lea.
tcg-i386: Use lea for three-operand add.
tcg-i386: Tidy data16 prefixes.

 tcg/i386/tcg-target.c |  718 +++++++++++++++++++++++++++++--------------------
 1 files changed, 433 insertions(+), 285 deletions(-)