Skip to content

RFC tvp514x fixes

Hans Verkuil linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tvp514x: do NOT change the std as a side effectdrivers/media/video/tvp514x.c+16 -371 reply
2/6tvp514x: make std_list constdrivers/media/video/tvp514x.c+2 -21 reply
3/6tvp514x: there is only one supported format, so simplify the codedrivers/media/video/tvp514x.c+9 -361 reply
4/6tvp514x: add missing newlinesdrivers/media/video/tvp514x.c+6 -61 reply
5/6tvp514x: remove obsolete fmt_listdrivers/media/video/tvp514x.c+0 -151 reply
6/6tvp514x: simplify try/g/s_fmt handlingdrivers/media/video/tvp514x.c+9 -891 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchVaibhav Hiremath
1/6R-b T-b A-b
2/6R-b T-b A-b
3/6R-b T-b A-b
4/6R-b T-b A-b
5/6R-b T-b A-b
6/6R-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] [RFC] tvp514x fixes

Hi Vaibhav,

While working on the *_fmt to *_mbus_fmt video op conversion I noticed that tvp514x is confusing the current select TV standard with the detected TV standard leading to horrible side-effects where called TRY_FMT can actually magically change the TV standard.

I fixed this and I also simplified the format handling in general. Basically removing the format list table and realizing that since there is only one supported format, you can just return that format directly.

This will also make the next step much easier where enum/try/s/g_fmt is replaced by enum/try/s/g_mbus_fmt.

However, I have no way of testing this. Can you review this code and let me know if it is OK?

Regards,

Hans

Hans Verkuil (6):
tvp514x: do NOT change the std as a side effect
tvp514x: make std_list const
tvp514x: there is only one supported format, so simplify the code
tvp514x: add missing newlines
tvp514x: remove obsolete fmt_list
tvp514x: simplify try/g/s_fmt handling

 drivers/media/video/tvp514x.c |  223 ++++++++---------------------------------
 1 files changed, 40 insertions(+), 183 deletions(-)