HPET cleanups, fixes, enhancements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 106 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | hpet: Catch out-of-bounds timer accesshw/ | +5 | 3 replies | |
| 2/15 | hpet: Coding style cleanups and some refactoringshw/ hw/ | +226 | 1 reply | |
| 3/15 | hpet: Silence warning on write to running main counterhw/ | +2 | 0 replies | |
| 4/15 | hpet: Move static timer field initializationhw/ | +2 | 0 replies | |
| 5/15 | hpet: Convert to qdevhw/ hw/ hw/ | +38 | 2 replies | |
| 6/15 | hpet: Start/stop timer when HPET_TN_ENABLE is modifiedhw/ | +5 | 0 replies | |
| 7/15 | qemu_irq: Add IRQ handlers with delivery feedbackhw/ hw/ | +44 | 91 replies | |
| 8/15 | x86: Refactor RTC IRQ coalescing workaroundhw/ hw/ hw/ +5 more | +94 | 0 replies | |
| 9/15 | hpet/rtc: Rework RTC IRQ replacement by HPEThw/ hw/ hw/ +6 more | +53 | 8 replies | |
| 10/15 | hpet: Drop static statehw/ | +17 | 0 replies | |
| 11/15 | hpet: Add support for level-triggered interruptshw/ | +22 | 0 replies | |
| 12/15 | vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8hw/ | +10 | 0 replies | |
| 13/15 | hpet: Make number of timers configurablehw/ hw/ | +45 | 0 replies | |
| 14/15 | hpet: Add MSI supporthw/ hw/ hw/ +1 more | +40 | 0 replies | |
| 15/15 | monitor/QMP: Drop info hpet / query-hpetQMP/ monitor.c | +1 | 0 replies |
Reviews trailers per patch
1 of 15 patches has a Reviewed-by or Acked-by.
| Patch | Juan Quintela |
|---|---|
| 1/15 | |
| 2/15 | R-b |
| 3/15 | |
| 4/15 | |
| 5/15 | |
| 6/15 | |
| 7/15 | |
| 8/15 | |
| 9/15 | |
| 10/15 | |
| 11/15 | |
| 12/15 | |
| 13/15 | |
| 14/15 | |
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [RFT][PATCH 00/15] HPET cleanups, fixes, enhancements
Not yet for merge (unless I happened to forgot adding bugs), just a Request For Testing (and for review, of course). This series grew beyond my initial plans and my current testing capabilities, Linux and Win7 are apparently still fine, but that's all I can say so far.
To summarize contributions to the HPET model:
- fixed host memory corruptions by guest (patch 1, likely stable stuff)
- coding style cleanup
- qdev conversion
- detangling of RTC from HPET dependencies, specifically via providing "feedback" IRQ handlers to easy IRQ coalescing workaround implementations
- support for level-triggered HPET IRQs (untested - does anyone know of a user?)
- up to 32 comparators (configurable via qdev prop)
- MSI support (configurable via qdev prop)
- dropped obsolete "info hpet" and "query-hpet"
Yet missing:
- IRQ coalescing workaround
- maybe some refactoring to easy compile-time disabling (Juan?)
- build once (I leave this to Blue Swirl :) )
- multiple HPET blocks (no urgent need yet)
Please give this hell.
Jan Kiszka (15):
hpet: Catch out-of-bounds timer access
hpet: Coding style cleanups and some refactorings
hpet: Silence warning on write to running main counter
hpet: Move static timer field initialization
hpet: Convert to qdev
hpet: Start/stop timer when HPET_TN_ENABLE is modified
qemu_irq: Add IRQ handlers with delivery feedback
x86: Refactor RTC IRQ coalescing workaround hpet/rtc: Rework RTC IRQ replacement by HPET
hpet: Drop static state
hpet: Add support for level-triggered interrupts
vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8
hpet: Make number of timers configurable
hpet: Add MSI support
monitor/QMP: Drop info hpet / query-hpet
QMP/vm-info | 2 +- hw/apic.c | 63 +++--- hw/apic.h | 11 +- hw/hpet.c | 582 +++++++++++++++++++++++++++++++++-------------------- hw/hpet_emul.h | 46 +---- hw/hw.h | 10 + hw/i8259.c | 20 ++- hw/ioapic.c | 34 ++-- hw/irq.c | 38 +++- hw/irq.h | 22 ++- hw/mc146818rtc.c | 60 ++---- hw/mc146818rtc.h | 4 +- hw/mips_jazz.c | 2 +- hw/mips_malta.c | 2 +- hw/mips_r4k.c | 2 +- hw/pc.c | 33 +++- hw/pc.h | 2 +- hw/pc_piix.c | 2 +- hw/ppc_prep.c | 2 +- monitor.c | 33 --- 20 files changed, 552 insertions(+), 418 deletions(-)