Skip to content

RFC misc cleanups and SMS ID API

Inaky Perez-Gonzalez ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest13 patches 33 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Update .gitignore to ignore cscope databases and backup files.gitignore+3 -04 replies
2/13sms_send_message: add a short roadmapsrc/sms.c+13 -04 replies
3/13documentation: add note about referencing standardsdoc/standards.txt+8 -02 replies
4/13sms_assembly_add_fragment_backup: clarify how insertion spot is foundsrc/smsutil.c+5 -02 replies
5/13util.h: Add BUILD_BUG_ON() and friends for compile-time assert checkingsrc/util.h+29 -02 replies
6/13smutil.h: add missing header file dependenciessrc/smsutil.h+10 -04 replies
7/13write_file: make transaction-safesrc/storage.c+31 -112 replies
8/13storage: add __attribute__((format)) to {write, read}_file() for printf-like variable arg verificationsrc/storage.h+4 -22 replies
9/13Add function doc headers to ofono_sms_{create, register}src/sms.c+19 -02 replies
10/13doc: explain debugging options to -d, add a pointer in -h to manpageHACKING doc/ofonod.8 src/main.c+17 -24 replies
11/13automake: fix installation of udev rules in VPATH buildsMakefile.am+1 -12 replies
12/13SMS: introduce message ID APIMakefile.am src/smsutil.c src/smsutil.h +1 more+490 -13 replies
13/13SMS: implement SHA256-based message IDs [incomplete]src/sms.c+27 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC patches 00/13] misc cleanups and SMS ID API

From: Inaky Perez-Gonzalez <[email protected]>

Hi All

This set of patches introduce:

- a few cleanups, code documentations nippets, .gitignore additions, header file dependency fixes in smutil.h

- adds BUILD_BUG_ON() [linux kernel style], printf-like attribute checking for {write,read}_file()

- make write_file() transaction-safe

- Introduce the SMS ID API (rfc, still incomplete).

feedback?

Thanks!

The following changes since commit 6b0f2328c5e190053f6a28ed119d01581e2119b3:
Denis Kenzior (1):
Update TODO

are available in the git repository at:

git://gitorious.org/~inakypg/ofono/ofono-inakypg.git master

Patches follow for reviewing convenience.

Inaky Perez-Gonzalez (13):
Update .gitignore to ignore cscope databases and backup files
sms_send_message: add a short roadmap
documentation: add note about referencing standards sms_assembly_add_fragment_backup: clarify how insertion spot is found
util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking
smutil.h: add missing header file dependencies
write_file: make transaction-safe
storage: add __attribute__((format)) to {write,read}_file() for printf-like variable arg verification Add function doc headers to ofono_sms_{create,register}
doc: explain debugging options to -d, add a pointer in -h to manpage
automake: fix installation of udev rules in VPATH builds
SMS: introduce message ID API
SMS: implement SHA256-based message IDs [incomplete]

 .gitignore             |    3 +
 HACKING                |   10 +++
 Makefile.am            |    7 +-
 doc/ofonod.8           |    5 +-
 doc/standards.txt      |    8 ++
 src/main.c             |    4 +-
 src/sms.c              |   69 +++++++++++++---
 src/smsutil.c          |  197 ++++++++++++++++++++++++++++++++++++++++++++
 src/smsutil.h          |   92 +++++++++++++++++++++
 src/storage.c          |   42 +++++++---
 src/storage.h          |    6 +-
 src/util.h             |   29 +++++++
 unit/test-sms-msg-id.c |  212 ++++++++++++++++++++++++++++++++++++++++++++++++
 13 files changed, 657 insertions(+), 27 deletions(-)
 create mode 100644 doc/standards.txt
 create mode 100644 unit/test-sms-msg-id.c