Skip to content

Removing dead code

Christoph Egger linux-arm-kernel linux-arm-msm linux-omap lkml 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest33 patches 62 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/33Removing dead MTD_NAND_AT91_BUSWIDTH_16arch/arm/mach-at91/board-at572d940hf_ek.c arch/arm/mach-at91/board-sam9m10g45ek.c+0 -85 replies
2/33Removing dead ARCH_DAVINCI_TNETV107Xarch/arm/mach-davinci/include/mach/cputype.h+0 -63 replies
3/33Removing dead OMAP_MUX_ERRORSarch/arm/mach-omap1/mux.c+0 -54 replies
3/33Removing dead OMAP_MUX_ERRORSarch/arm/mach-omap1/mux.c+0 -50 replies
4/33Removing dead MSM7X00A_IDLEarch/arm/mach-msm/idle.S+0 -132 replies
5/33Removing dead OMAP_IRarch/arm/mach-omap1/board-h2.c arch/arm/mach-omap2/board-h4.c+0 -221 reply
5/33Removing dead OMAP_IRarch/arm/mach-omap1/board-h2.c arch/arm/mach-omap2/board-h4.c+0 -220 replies
6/33Removing dead SHARPSL_LOCOMOarch/arm/mach-sa1100/include/mach/irqs.h+0 -25 replies
7/33Removing dead CPU_S3C2400arch/arm/mach-s3c2410/include/mach/gpio-fns.h arch/arm/mach-s3c2410/include/mach/regs-gpio.h arch/arm/plat-s3c24xx/cpu.c +1 more+0 -550 replies
8/33Removing dead SA1101arch/arm/mach-sa1100/include/mach/SA-1101.h arch/arm/mach-sa1100/include/mach/hardware.h+0 -9294 replies
9/33Removing dead MAGICVarch/arm/mach-at91/at572d940hf_devices.c+0 -730 replies
10/33Removing dead VIDEO_AT91_ISIarch/arm/mach-at91/at91sam9263_devices.c+0 -490 replies
11/33Removing dead OMAP_DSParch/arm/mach-omap1/board-nokia770.c arch/arm/mach-omap1/devices.c arch/arm/mach-omap1/mcbsp.c +2 more+0 -2741 reply
11/33Removing dead OMAP_DSParch/arm/mach-omap1/board-nokia770.c arch/arm/mach-omap1/devices.c arch/arm/mach-omap1/mcbsp.c +2 more+0 -2740 replies
12/33Removing dead OMAP_STIarch/arm/mach-omap1/devices.c arch/arm/mach-omap2/devices.c+0 -921 reply
12/33Removing dead OMAP_STIarch/arm/mach-omap1/devices.c arch/arm/mach-omap2/devices.c+0 -920 replies
13/33Replacing LEDS_OMAP_DEBUG with OMAP_DEBUG_LEDSarch/arm/plat-omap/Kconfig arch/arm/plat-omap/debug-leds.c+2 -21 reply
14/33Removing dead SDMA_IRAMarch/arm/plat-mxc/include/mach/mx51.h+0 -41 reply
15/33Removing dead PROCESSOR_NS9750arch/arm/mach-ns9xxx/gpio.c+0 -81 reply
16/33Removing dead APMarch/arm/mach-omap1/board-palmte.c+0 -842 replies
16/33Removing dead APMarch/arm/mach-omap1/board-palmte.c+0 -840 replies
17/33Removing dead SX1_OLD_FLASHarch/arm/mach-omap1/board-sx1.c+0 -263 replies
18/33Removing dead OMAP_ARM_96MHZarch/arm/mach-omap1/opp_data.c+0 -32 replies
19/33Removing dead MACH_OMAP_H4_OTGarch/arm/mach-omap2/board-h4.c+0 -170 replies
20/33Removing dead MACH_OMAP2_H4_USB1arch/arm/mach-omap2/board-h4.c+0 -52 replies
21/33Removing dead OMAP2_VENC_OUT_TYPE_SVIDEO, OMAP2_VENC_OUT_TYPE_COMPOSITEarch/arm/mach-omap2/board-omap3stalker.c+0 -53 replies
22/33Removing dead MPU_{BRIDGE,TESLA}_IOMMUarch/arm/mach-omap2/omap-iommu.c+0 -222 replies
23/33Removing dead BACKLIGHT_CORGIarch/arm/mach-pxa/corgi_pm.c arch/arm/mach-pxa/sharpsl_pm.c arch/arm/mach-pxa/spitz_pm.c+0 -192 replies
24/33Removing dead ARCH_GUMSTIX_ORIGarch/arm/mach-pxa/include/mach/gumstix.h+1 -113 replies
25/33Removing dead CORGI_SSP_DEPRECATEDarch/arm/mach-pxa/sharpsl_pm.c+0 -52 replies
26/33Removing dead XSCALE_CACHE_ERRATAarch/arm/mach-pxa/sleep.S+0 -72 replies
27/33Removing dead IDE_PXA_CFarch/arm/mach-pxa/trizeps4.c+1 -55 replies
28/33Removing dead CPU_S3C24XXarch/arm/mach-s3c2410/include/mach/gpio.h+0 -41 reply
29/33Removing dead SND_SOC_SMDK2443_WM9710arch/arm/mach-s3c2443/mach-smdk2443.c+0 -76 replies
30/33Removing dead S3C_DEV_ADCarch/arm/mach-s5pv210/cpu.c+0 -42 replies
31/33Removing dead MACH_U300_BS26arch/arm/mach-u300/core.c+0 -72 replies
32/33Removing dead CPU_ICACHE_STREAMING_DISABLEarch/arm/mm/proc-arm925.S+0 -30 replies
33/33Removing dead MACH_U300_USE_I2S_AS_MASTERarch/arm/mach-u300/clock.c+0 -911 reply

Reviews trailers per patch

14 of 38 patches have a Reviewed-by or Acked-by.

PatchNicolas PitreKirill A. ShutemovLinus WalleijEric MiaoSascha HauerKristoffer EricsonJaya KumarJean-Christophe PLAGNIOL-VILLARD
1/33A-b A-b A-b
2/33A-b
3/33A-b
3/33A-b
4/33
5/33
5/33
6/33A-b
7/33
8/33A-b
9/33
10/33
11/33
11/33
12/33
12/33
13/33
14/33A-b
15/33
16/33
16/33
17/33
18/33
19/33
20/33
21/33
22/33
23/33A-b
24/33A-b A-b
25/33A-b
26/33A-b
27/33A-b
28/33
29/33
30/33
31/33A-b
32/33
33/33A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/33] Removing dead code

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux' configuration system.

I've been running a check on the arch/arm sourcetree for
config Items not defined in Kconfig and found 33 such cases. Sourcecode blocks depending on these Items are not reachable from a vanilla kernel -- dead code. I've seen such dead blocks made on purpose e.g. while integrating new features into the kernel but generally they're just useless.

Each of the patches in this patchset removes on such dead
config Item, I'd be glad if you consider applying them. I've been doing deeper analysis of such issues before and can do so again but I'm not so sure they were fastly usefull. Unfortunately arm doesn't allow some allyesconfig build covering all of that code so I couldn't build-test all of them, sorry for that.

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/

Christoph Egger (33):
Removing dead MTD_NAND_AT91_BUSWIDTH_16
Removing dead ARCH_DAVINCI_TNETV107X
Removing dead OMAP_MUX_ERRORS
Removing dead MSM7X00A_IDLE
Removing dead OMAP_IR
Removing dead SHARPSL_LOCOMO
Removing dead CPU_S3C2400
Removing dead SA1101
Removing dead MAGICV
Removing dead VIDEO_AT91_ISI
Removing dead OMAP_DSP
Removing dead OMAP_STI
Replacing LEDS_OMAP_DEBUG with OMAP_DEBUG_LEDS
Removing dead SDMA_IRAM
Removing dead PROCESSOR_NS9750
Removing dead APM
Removing dead SX1_OLD_FLASH
Removing dead OMAP_ARM_96MHZ
Removing dead MACH_OMAP_H4_OTG
Removing dead MACH_OMAP2_H4_USB1
Removing dead OMAP2_VENC_OUT_TYPE_SVIDEO,
OMAP2_VENC_OUT_TYPE_COMPOSITE
Removing dead MPU_{BRIDGE,TESLA}_IOMMU
Removing dead BACKLIGHT_CORGI
Removing dead ARCH_GUMSTIX_ORIG
Removing dead CORGI_SSP_DEPRECATED
Removing dead XSCALE_CACHE_ERRATA
Removing dead IDE_PXA_CF
Removing dead CPU_S3C24XX
Removing dead SND_SOC_SMDK2443_WM9710
Removing dead S3C_DEV_ADC
Removing dead MACH_U300_BS26
Removing dead CPU_ICACHE_STREAMING_DISABLE
Removing dead MACH_U300_USE_I2S_AS_MASTER

 arch/arm/mach-at91/at572d940hf_devices.c       |   73 --
 arch/arm/mach-at91/at91sam9263_devices.c       |   49 --
 arch/arm/mach-at91/board-at572d940hf_ek.c      |    4 -
 arch/arm/mach-at91/board-sam9m10g45ek.c        |    4 -
 arch/arm/mach-davinci/include/mach/cputype.h   |    6 -
 arch/arm/mach-msm/idle.S                       |   13 -
 arch/arm/mach-ns9xxx/gpio.c                    |    8 -
 arch/arm/mach-omap1/board-h2.c                 |   18 -
 arch/arm/mach-omap1/board-nokia770.c           |  132 ----
 arch/arm/mach-omap1/board-palmte.c             |   84 ---
 arch/arm/mach-omap1/board-sx1.c                |   26 -
 arch/arm/mach-omap1/devices.c                  |   72 --
 arch/arm/mach-omap1/mcbsp.c                    |    3 -
 arch/arm/mach-omap1/mux.c                      |    5 -
 arch/arm/mach-omap1/opp_data.c                 |    3 -
 arch/arm/mach-omap2/board-h4.c                 |   26 -
 arch/arm/mach-omap2/board-omap3stalker.c       |    5 -
 arch/arm/mach-omap2/devices.c                  |   57 --
 arch/arm/mach-omap2/omap-iommu.c               |   22 -
 arch/arm/mach-pxa/corgi_pm.c                   |    2 -
 arch/arm/mach-pxa/include/mach/gumstix.h       |   12 +-
 arch/arm/mach-pxa/sharpsl_pm.c                 |   20 -
 arch/arm/mach-pxa/sleep.S                      |    7 -
 arch/arm/mach-pxa/spitz_pm.c                   |    2 -
 arch/arm/mach-pxa/trizeps4.c                   |    6 +-
 arch/arm/mach-s3c2410/include/mach/gpio-fns.h  |    5 -
 arch/arm/mach-s3c2410/include/mach/gpio.h      |    4 -
 arch/arm/mach-s3c2410/include/mach/regs-gpio.h |    4 -
 arch/arm/mach-s3c2443/mach-smdk2443.c          |    7 -
 arch/arm/mach-s5pv210/cpu.c                    |    4 -
 arch/arm/mach-sa1100/include/mach/SA-1101.h    |  925 ------------------------
 arch/arm/mach-sa1100/include/mach/hardware.h   |    4 -
 arch/arm/mach-sa1100/include/mach/irqs.h       |    2 -
 arch/arm/mach-u300/clock.c                     |   91 ---
 arch/arm/mach-u300/core.c                      |    7 -
 arch/arm/mm/proc-arm925.S                      |    3 -
 arch/arm/plat-mxc/include/mach/mx51.h          |    4 -
 arch/arm/plat-omap/Kconfig                     |    2 +-
 arch/arm/plat-omap/debug-leds.c                |    2 +-
 arch/arm/plat-omap/devices.c                   |   62 --
 arch/arm/plat-omap/include/plat/dsp_common.h   |   40 -
 arch/arm/plat-s3c24xx/cpu.c                    |   15 -
 arch/arm/plat-s3c24xx/include/plat/s3c2400.h   |   31 -
 43 files changed, 4 insertions(+), 1867 deletions(-)
 delete mode 100644 arch/arm/mach-sa1100/include/mach/SA-1101.h
 delete mode 100644 arch/arm/plat-omap/include/plat/dsp_common.h
 delete mode 100644 arch/arm/plat-s3c24xx/include/plat/s3c2400.h