Skip to content

Removing dead code

Christoph Egger lkml 1 version NAK

Status from this message: NAK: it is defied & used locally

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 4 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/11Removing dead 68328_SERIAL_UARTdrivers/serial/68328serial.h+0 -50 replies
2/11Removing dead CONSOLE_*drivers/serial/68360serial.c+2 -100 replies
3/11Removing dead PP04drivers/serial/68360serial.c+0 -140 replies
4/11Removing dead (ALMA_ANS | DRAGONIXVZ | M68EZ328ADS)drivers/serial/68328serial.c+5 -111 reply
5/11Removing dead ETRAX_RS485_ON_PORT_Gdrivers/serial/crisv10.c+0 -240 replies
6/11Removing dead ETRAX_RS485_LTC1387drivers/serial/crisv10.c+0 -120 replies
7/11Removing dead ETRAX_EXTERN_PB6CLK_ENABLEDdrivers/serial/crisv10.c+0 -130 replies
8/11Removing dead ETRAX_SERIAL_PROC_ENTRYdrivers/serial/crisv10.c+0 -220 replies
9/11Removing dead SERIAL_BFIN_{HARD_,}CTSRTSdrivers/serial/bfin_5xx.c+0 -1031 reply
10/11Removing dead SERIAL_BFIN_SPORT_CTSRTSdrivers/serial/bfin_sport_uart.c+0 -851 reply
11/11Removing dead SERIAL_BFIN_SPORT_CONSOLEdrivers/serial/bfin_sport_uart.c+5 -101 reply

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchGreg Ungerer
1/11
2/11
3/11
4/11A-b
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Removing dead code

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux' configuration system.

I've been running a check on the arch/arm sourcetree for
config Items not defined in Kconfig and found 33 such cases. Sourcecode
blocks depending on these Items are not reachable from a vanilla kernel -- dead code. I've seen such dead blocks made on purpose e.g. while integrating new features into the kernel but generally they're just useless.

Each of the patches in this patchset removes on such dead
config Item, I'd be glad if you consider applying them. I've been doing deeper analysis of such issues before and can do so again but I'm not so sure they were fastly usefull. Unfortunately arm doesn't allow some allyesconfig build covering all of that code so I couldn't build-test all of them, sorry for that.

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/

Christoph Egger (11):
Removing dead 68328_SERIAL_UART
Removing dead CONSOLE_*
Removing dead PP04
Removing dead (ALMA_ANS | DRAGONIXVZ | M68EZ328ADS) Removing dead ETRAX_RS485_ON_PORT_G Removing dead ETRAX_RS485_LTC1387
Removing dead ETRAX_EXTERN_PB6CLK_ENABLED Removing dead ETRAX_SERIAL_PROC_ENTRY Removing dead SERIAL_BFIN_{HARD_,}CTSRTS Removing dead SERIAL_BFIN_SPORT_CTSRTS Removing dead SERIAL_BFIN_SPORT_CONSOLE

 drivers/serial/68328serial.c     |   16 ++----
 drivers/serial/68328serial.h     |    5 --
 drivers/serial/68360serial.c     |   26 +---------
 drivers/serial/bfin_5xx.c        |  103 --------------------------------------
 drivers/serial/bfin_sport_uart.c |  100 ++-----------------------------------
 drivers/serial/crisv10.c         |   71 --------------------------
 6 files changed, 12 insertions(+), 309 deletions(-)