Skip to content

Removing dead code

Christoph Egger linux-wireless lkml netdev 1 version Applied

Status from this message: Applied to net-next-2.6

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 22 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/11Removing dead RT2800PCI_SOCdrivers/net/wireless/rt2x00/Kconfig drivers/net/wireless/rt2x00/rt2800pci.c+0 -4410 replies
2/11Removing dead {AR,WAVE}LANdrivers/net/Space.c+0 -61 reply
3/11Removing dead CASSINI_QGE_DEBUGdrivers/net/cassini.h+0 -41 reply
4/11Removing dead CASSINI_MULTICAST_REG_WRITEdrivers/net/cassini.c+1 -190 replies
4/11Removing dead CASSINI_MULTICAST_REG_WRITEdrivers/net/cassini.c+1 -190 replies
5/11Removing dead CASSINI_NAPIdrivers/net/cassini.c+0 -50 replies
5/11Removing dead CASSINI_NAPIdrivers/net/cassini.c+0 -51 reply
6/11Removing dead CHELSIO_T1_COUGARdrivers/net/chelsio/subr.c+2 -461 reply
7/11Removing dead ARCH_PNX010Xdrivers/net/cs89x0.c+0 -450 replies
7/11Removing dead ARCH_PNX010Xdrivers/net/cs89x0.c+0 -452 replies
8/11Removing dead SH_HICOSH4drivers/net/cs89x0.c drivers/net/cs89x0.h+2 -530 replies
8/11Removing dead SH_HICOSH4drivers/net/cs89x0.c drivers/net/cs89x0.h+2 -531 reply
9/11Removing dead ETRAX_NETWORK_RED_ON_NO_CONNECTIONdrivers/net/cris/eth_v10.c+0 -40 replies
9/11Removing dead ETRAX_NETWORK_RED_ON_NO_CONNECTIONdrivers/net/cris/eth_v10.c+0 -42 replies
10/11Removing dead NETWINDER_{T,R}X_DMA_PROBLEMSdrivers/net/irda/w83977af_ir.c+4 -291 reply
11/11Removing dead REDWOOD_{5,6}drivers/net/smc91x.h+0 -370 replies
11/11Removing dead REDWOOD_{5,6}drivers/net/smc91x.h+0 -372 replies

Reviews trailers per patch

4 of 17 patches have a Reviewed-by or Acked-by.

PatchNicolas PitreJesper Nilsson
1/11
2/11
3/11
4/11
4/11
5/11
5/11
6/11
7/11
7/11
8/11
8/11
9/11A-b
9/11A-b
10/11
11/11A-b
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Removing dead code

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux' configuration system.

I've been running a check on the drivers/net sourcetree for
config Items not defined in Kconfig and found 11 such cases. Sourcecode blocks depending on these Items are not reachable from a vanilla kernel -- dead code. I've seen such dead blocks made on purpose e.g. while integrating new features into the kernel but generally they're just useless.

Each of the patches in this patchset removes on such dead
config Item, I'd be glad if you consider applying them. I've been doing deeper analysis of such issues before and can do so again but I'm not so sure they were fastly usefull.

I build the patches against a vanilla kernel in order to
try if the kernel compiles with this patches

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/

Christoph Egger (11):
Removing dead RT2800PCI_SOC
Removing dead {AR,WAVE}LAN
Removing dead CASSINI_QGE_DEBUG
Removing dead CASSINI_MULTICAST_REG_WRITE Removing dead CASSINI_NAPI
Removing dead CHELSIO_T1_COUGAR
Removing dead ARCH_PNX010X
Removing dead SH_HICOSH4
Removing dead ETRAX_NETWORK_RED_ON_NO_CONNECTION Removing dead NETWINDER_{T,R}X_DMA_PROBLEMS Removing dead REDWOOD_{5,6}

 drivers/net/Space.c                     |    6 --
 drivers/net/cassini.c                   |   25 +--------
 drivers/net/cassini.h                   |    4 -
 drivers/net/chelsio/subr.c              |   48 +---------------
 drivers/net/cris/eth_v10.c              |    4 -
 drivers/net/cs89x0.c                    |   96 +------------------------------
 drivers/net/cs89x0.h                    |    4 -
 drivers/net/irda/w83977af_ir.c          |   33 +---------
 drivers/net/smc91x.h                    |   37 ------------
 drivers/net/wireless/rt2x00/Kconfig     |    5 --
 drivers/net/wireless/rt2x00/rt2800pci.c |   39 -------------
 11 files changed, 9 insertions(+), 292 deletions(-)