Skip to content

Removing dead code

Christoph Egger linux-um lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Removing dead PROC_MMarch/um/kernel/ptrace.c+0 -210 replies
2/3Removing conditionalizing containing exactly the same codearch/um/sys-ppc/shared/sysdep/ptrace.h+1 -40 replies
3/3Removing dead copy&paste codearch/um/sys-i386/asm/archparam.h arch/um/sys-i386/shared/sysdep/system.h arch/um/sys-ppc/misc.S +1 more+2 -290 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Removing dead code

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux' configuration system.

I've been running a check on the arch/um sourcetree for config
Items not defined in Kconfig and found 10 such cases. Sourcecode blocks depending on these Items are not reachable from a vanilla kernel -- dead code. I've seen such dead blocks made on purpose e.g. while integrating new features into the kernel but generally they're just useless.

Each of the patches in this patchset removes on such dead
config Item, I'd be glad if you consider applying them. I've been doing deeper analysis of such issues before and can do so again but I'm not so sure they were fastly usefull.

I build the patches against a vanilla kernel in order to
try if the kernel compiles with this patches. As reported earlier today the build currently fails for plain um but adding this patchset doesn't change the failing in any way. That was a i386 build.

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/

Christoph Egger (3):
Removing dead PROC_MM
Removing conditionalizing containing exactly the same code Removing dead copy&paste code

 arch/um/kernel/ptrace.c                   |   21 ---------------------
 arch/um/sys-i386/asm/archparam.h          |    4 ----
 arch/um/sys-i386/shared/sysdep/system.h   |   11 +----------
 arch/um/sys-ppc/misc.S                    |    6 ------
 arch/um/sys-ppc/shared/sysdep/ptrace.h    |    5 +----
 arch/um/sys-x86_64/shared/sysdep/system.h |   10 +---------
 6 files changed, 3 insertions(+), 54 deletions(-)