Skip to content

pull request

Inaky Perez-Gonzalez ofono 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest17 patches 2 repliesIn review
  2. v119 patches 11 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17sms: replace sequential SMS message ID with hashsrc/sms.c+49 -10 replies
2/17sms: _txq_submit() returns pointer to objectsrc/ofono.h src/sms.c+17 -120 replies
3/17sms: document the org.ofono.SmsMessage interfacedoc/sms-api.txt+47 -20 replies
4/17sms: document handle_sms_status_report()src/sms.c+9 -00 replies
5/17sms: introduce bare state machine and transitionssrc/ofono.h src/sms.c+148 -20 replies
6/17sms: introduce the Wait-for-Status-Report statesrc/sms.c+73 -70 replies
7/17sms: introduce a state change callback for messagessrc/ofono.h src/sms.c src/stk.c+43 -120 replies
8/17sms: export outgoing messages over D-Bussrc/sms.c+139 -520 replies
9/17sms: send PropertyChanged signals on state changesrc/sms.c+35 -10 replies
10/17sms: introduce sms_msg_cancel and its D-Bus wrappersrc/sms.c+55 -00 replies
11/17sms: Implement D-Bus SMS-MSG::GetPropertiessrc/sms.c+33 -60 replies
12/17sms: document SMS Message's D-Bus 'To' propertydoc/sms-api.txt+5 -00 replies
13/17sms: test code for message's D-Bus GetPropertiestest/test-sms-msg-get-properties+26 -00 replies
14/17automake: fix generation of symlinks for headersMakefile.am+1 -12 replies
15/17sms: document variable usage in sms_msg_send()src/sms.c+3 -00 replies
16/17sms: add test case for message canceltest/test-sms-msg-cancel+173 -00 replies
17/17sms: add test case for state change signalstest/test-sms-msg-state-change+24 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [SMS D-Bus v5 00/17] pull request

From: Inaky Perez-Gonzalez <[email protected]>

v5 (there have been more than five submissions, but whatever) contains the following changes as requested by Dennis:

- multi fragment message ref and the unique message ID are decoupled now. this allows...

- UUID is generated in tx_queue_entry_new()

- UUID is expanded to 32-bits from 16 bits

Catchas

- UUID is not used in the RX path yet, the old mechanism (sms->next_msg_id) is still in place

- __ofono_sms_txq_submit() still has to be modified. No better alternatives have been proposed.

The following changes since commit f01de438bd4f834a27f9c36e74e6a1067f778a21:
João Paulo Rechi Vita (1):
huawei: Fix SIM state logic

are available in the git repository at:

git://gitorious.org/~inakypg/ofono/ofono-inakypg.git master

Patches follow for reviewing convenience.

Inaky Perez-Gonzalez (17):
sms: replace sequential SMS message ID with hash
sms: _txq_submit() returns pointer to object
sms: document the org.ofono.SmsMessage interface
sms: document handle_sms_status_report()
sms: introduce bare state machine and transitions
sms: introduce the Wait-for-Status-Report state
sms: introduce a state change callback for messages
sms: export outgoing messages over D-Bus
sms: send PropertyChanged signals on state change
sms: introduce sms_msg_cancel and its D-Bus wrapper
sms: Implement D-Bus SMS-MSG::GetProperties
sms: document SMS Message's D-Bus 'To' property
sms: test code for message's D-Bus GetProperties
automake: fix generation of symlinks for headers
sms: document variable usage in sms_msg_send()
sms: add test case for message cancel
sms: add test case for state change signals

 Makefile.am                      |    2 +-
 doc/sms-api.txt                  |   54 ++++-
 src/ofono.h                      |   46 +++-
 src/sms.c                        |  576 ++++++++++++++++++++++++++++++++++----
 src/stk.c                        |   19 ++-
 test/test-sms-msg-cancel         |  173 ++++++++++++
 test/test-sms-msg-get-properties |   26 ++
 test/test-sms-msg-state-change   |   24 ++
 8 files changed, 852 insertions(+), 68 deletions(-)
 create mode 100755 test/test-sms-msg-cancel
 create mode 100755 test/test-sms-msg-get-properties
 create mode 100755 test/test-sms-msg-state-change