pps: several fixes and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest16 patches 11 repliesIn review
- v517 patches 15 repliesSuperseded
- v417 patches 32 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 16 patches | 25 replies | Superseded |
Changes in v6 from the cover letter
* drop patch that fixes a race condition in tty code because it's already fixed in 2.6.37-rc2
* fix getnstime_raw_and_real() comments (thanks Thomas Gleixner for the note)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | pps: trivial fixesdrivers/ include/ | +7 | 0 replies | |
| 2/16 | pps: declare variables where they are used in switchdrivers/ | +6 | 0 replies | |
| 3/16 | pps: fix race in PPS_FETCH handlerdrivers/ drivers/ include/ | +10 | 0 replies | |
| 4/16 | pps: unify timestamp gatheringdrivers/ drivers/ drivers/ +3 more | +44 | 0 replies | |
| 5/16 | pps: access pps device by direct pointerdrivers/ drivers/ drivers/ +2 more | +82 | 0 replies | |
| 6/16 | pps: convert printk/pr_* to dev_*drivers/ drivers/ drivers/ +1 more | +26 | 0 replies | |
| 7/16 | pps: move idr stuff to pps.cdrivers/ drivers/ | +52 | 3 replies | |
| 8/16 | pps: do not disable interrupts for idr operationsdrivers/ | +6 | 0 replies | |
| 9/16 | pps: use BUG_ON for kernel API safety checksdrivers/ | +2 | 0 replies | |
| 10/16 | pps: simplify conditions a bitdrivers/ | +2 | 0 replies | |
| 11/16 | pps: timestamp is always passed to dcd_change()Documentation/ drivers/ include/ | +2 | 0 replies | |
| 12/16 | ntp: add hardpps implementationdrivers/ include/ kernel/ | +418 | 0 replies | |
| 13/16 | pps: capture MONOTONIC_RAW timestamps as wellinclude/ include/ kernel/ | +43 | 0 replies | |
| 14/16 | pps: add kernel consumer supportDocumentation/ drivers/ drivers/ +3 more | +103 | 0 replies | |
| 15/16 | pps: add parallel port PPS clientdrivers/ drivers/ drivers/ | +255 | 3 replies | |
| 16/16 | pps: add parallel port PPS signal generatorDocumentation/ drivers/ drivers/ +3 more | +350 | 2 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Rodolfo Giometti | John Stultz |
|---|---|---|
| Series | A-b A-b | A-b A-b |
| 1/16 | A-b | |
| 2/16 | A-b | |
| 3/16 | A-b | |
| 4/16 | A-b | |
| 5/16 | A-b | |
| 6/16 | A-b | |
| 7/16 | A-b | |
| 8/16 | A-b | |
| 9/16 | A-b | |
| 10/16 | A-b | |
| 11/16 | A-b | |
| 12/16 | A-b | |
| 13/16 | A-b | |
| 14/16 | A-b | |
| 15/16 | A-b | |
| 16/16 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv6 00/16] pps: several fixes and improvements
This patchset contains several changes that improve an overall design/performance of PPS subsystem. I'd like these patches to be merged mainline if no one objects.
Patches 1-3 are bugfixes.
Patches 4-11 are other improvements to PPS subsystem. Patches 12-14 add kernel consumer support. Patch 15 adds parallel port PPS client.
Patch 16 adds parallel port PPS generator.
You can find description for my previous patchset (it describes patches 12-16 in more detail) here: http://lkml.org/lkml/2010/2/24/189
This patchset is tested against the vanilla 2.6.37-rc6 kernel. But we are actually using it on 2.6.33.7-rt29 rt-preempt kernel most of the time. Those who are interested in other versions of the patchset can find them in my git repository:git://github.com/ago/linux-2.6.git
There is one problem however: kernel consumer works bad (if enabled) when CONFIG_NO_HZ is enabled. The reason for this is commit a092ff0f90cae22b2ac8028ecd2c6f6c1a9e4601. Without it hardpps() is able to sync to 1us precision in about 10 seconds. With CONFIG_NO_HZ it is not syncing at all. This only affects patches 12-14, others are ok.
Changelog
v5 -> v6:
* drop patch that fixes a race condition in tty code because it's already fixed in 2.6.37-rc2
* fix getnstime_raw_and_real() comments (thanks Thomas Gleixner for the note)
Alexander Gordeev (16):
pps: trivial fixes
pps: declare variables where they are used in switch
pps: fix race in PPS_FETCH handler
pps: unify timestamp gathering
pps: access pps device by direct pointer
pps: convert printk/pr_* to dev_*
pps: move idr stuff to pps.c
pps: do not disable interrupts for idr operations
pps: use BUG_ON for kernel API safety checks
pps: simplify conditions a bit
pps: timestamp is always passed to dcd_change()
ntp: add hardpps implementation
pps: capture MONOTONIC_RAW timestamps as well
pps: add kernel consumer support
pps: add parallel port PPS client
pps: add parallel port PPS signal generator
Documentation/ioctl/ioctl-number.txt | 2 +- Documentation/pps/pps.txt | 46 ++++ Documentation/serial/tty.txt | 2 +- drivers/pps/Kconfig | 10 + drivers/pps/Makefile | 2 +- drivers/pps/clients/Kconfig | 7 + drivers/pps/clients/Makefile | 1 + drivers/pps/clients/pps-ktimer.c | 44 ++-- drivers/pps/clients/pps-ldisc.c | 59 ++-- drivers/pps/clients/pps_parport.c | 247 +++++++++++++++++ drivers/pps/generators/Kconfig | 17 ++ drivers/pps/generators/Makefile | 9 + drivers/pps/generators/pps_gen_parport.c | 275 +++++++++++++++++++ drivers/pps/kapi.c | 221 +++++----------- drivers/pps/pps.c | 177 ++++++++++--- include/linux/pps.h | 7 + include/linux/pps_kernel.h | 54 +++- include/linux/serial_core.h | 5 +- include/linux/time.h | 2 + include/linux/timex.h | 1 + include/linux/tty_ldisc.h | 7 +- kernel/time/ntp.c | 425 ++++++++++++++++++++++++++++- kernel/time/timekeeping.c | 39 +++ 23 files changed, 1374 insertions(+), 285 deletions(-) create mode 100644 drivers/pps/clients/pps_parport.c create mode 100644 drivers/pps/generators/Kconfig create mode 100644 drivers/pps/generators/Makefile create mode 100644 drivers/pps/generators/pps_gen_parport.c
Signature · 1 line
1.7.2.3