Skip to content

pvcreate & detection of foreign signatures

Milan Broz lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Change the pvcreate swap/md logiclib/metadata/metadata.c+36 -340 replies
2/4Remove assumption that --ye must be used only in --force modetools/pvremove.c tools/toollib.c+0 -100 replies
3/4Fix file open leak in swap signature detectionlib/device/dev-swap.c+5 -70 replies
4/4Detect LUKS signature in pvcreatelib/Makefile.in lib/device/dev-luks.c lib/device/device.h +1 more+48 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPetr Rockai
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] pvcreate & detection of foreign signatures

After the third report of broken LUKS after pvcreate (just this week...) I added LUKS detection to lvm. But the current code is messy and in fact it wipes superblocks without asking by default.

This is attempt to change that to something more user friendly.

Milan Broz (4):
Change the pvcreate swap/md logic
Remove assumption that --ye must be used only in --force mode Fix file open leak in swap signature detection Detect LUKS signature in pvcreate

 lib/Makefile.in         |    1 +
 lib/device/dev-luks.c   |   43 ++++++++++++++++++++++++++++
 lib/device/dev-swap.c   |   12 +++----
 lib/device/device.h     |    1 +
 lib/metadata/metadata.c |   71 +++++++++++++++++++++++++----------------------
 tools/pvremove.c        |    5 ---
 tools/toollib.c         |    5 ---
 7 files changed, 88 insertions(+), 50 deletions(-)
 create mode 100644 lib/device/dev-luks.c