Skip to content

treewide-next: Use static const char arrays

Joe Perches alsa-devel linux-acpi linux-arm-kernel linux-fbdev linux-i2c linux-media linux-mips linux-nfs linux-s390 linux-scsi linux-wireless linuxppc-dev lkml netdev sparclinux 1 version NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 26 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/25arch/mips: Use static const char arraysarch/mips/pnx8550/common/reset.c+2 -22 replies
2/25arch/powerpc: Use static const char arraysarch/powerpc/boot/addnote.c arch/powerpc/boot/cuboot-c2k.c arch/powerpc/kernel/irq.c+5 -52 replies
3/25drivers/acpi: Use static const char arraysdrivers/acpi/sleep.c+2 -20 replies
4/25drivers/char: Use static const char arraysdrivers/char/hvc_vio.c+1 -11 reply
5/25drivers/i2c: Use static const char arraysdrivers/i2c/busses/i2c-stu300.c+2 -27 replies
6/25drivers/isdn: Use static const char arraysdrivers/isdn/hysdn/hycapi.c drivers/isdn/mISDN/dsp_cmx.c+2 -20 replies
7/25drivers/media: Use static const char arraysdrivers/media/video/zoran/zoran_device.c+2 -31 reply
7/25drivers/media/video/zoran: Don't use initialized char arraydrivers/media/video/zoran/zoran_device.c+4 -80 replies
8/25drivers/net/atl1c: Use static const char arraysdrivers/net/atl1c/atl1c.h drivers/net/atl1c/atl1c_main.c+4 -40 replies
9/25drivers/net/atl1e: Use static const char arraysdrivers/net/atl1e/atl1e.h drivers/net/atl1e/atl1e_main.c+4 -40 replies
10/25drivers/net/(intel): Use static const char arraysdrivers/net/e1000/e1000.h drivers/net/e1000/e1000_main.c drivers/net/e1000e/e1000.h +11 more+18 -180 replies
11/25drivers/net/netxen: Use static const char arraysdrivers/net/netxen/netxen_nic.h drivers/net/netxen/netxen_nic_main.c+2 -20 replies
12/25drivers/net/qlcnic: Use static const char arraysdrivers/net/qlcnic/qlcnic.h drivers/net/qlcnic/qlcnic_main.c+2 -20 replies
13/25drivers/net/spider_net.c: Use static const char arraysdrivers/net/spider_net.c+1 -10 replies
14/25drivers/net/vnxnet3: Use static const char arraysdrivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_int.h+2 -22 replies
15/25drivers/net/wireless/ipw2x00: Use static const char arraysdrivers/net/wireless/ipw2x00/ipw2100.c drivers/net/wireless/ipw2x00/ipw2200.c drivers/net/wireless/ipw2x00/libipw_module.c+3 -31 reply
16/25drivers/s390/char: Use static const char arraysdrivers/s390/char/vmlogrdr.c+2 -20 replies
17/25drivers/scsi: Use static const char arraysdrivers/scsi/bnx2i/bnx2i_hwi.c drivers/scsi/lpfc/lpfc_init.c drivers/scsi/megaraid/megaraid_mbox.c+7 -70 replies
18/25drivers/serial/suncore.c: Use static const char arraysdrivers/serial/suncore.c+2 -24 replies
19/25drivers/staging: Use static const char arraysdrivers/staging/brcm80211/util/bcmutils.c drivers/staging/comedi/drivers/comedi_bond.c drivers/staging/cxt1e1/ossiRelease.c +5 more+10 -100 replies
20/25drivers/usb: Use static const char arraysdrivers/usb/atm/ueagle-atm.c drivers/usb/otg/langwell_otg.c+6 -101 reply
21/25drivers/video: Use static const char arraysdrivers/video/sh_mipi_dsi.c drivers/video/sis/sis_main.c drivers/video/via/viafbdev.c+8 -81 reply
22/25net/dsa: Use static const char arraysnet/dsa/dsa.c net/dsa/dsa_priv.h+2 -20 replies
23/25net/sunrpc: Use static const char arraysnet/sunrpc/auth_gss/gss_krb5_mech.c+1 -10 replies
24/25sound: Use static const char arrayssound/core/misc.c+4 -13 replies
25/25tools/perf/util: Use static const char arraystools/perf/util/ui/setup.c tools/perf/util/ui/util.c+4 -20 replies

Reviews trailers per patch

5 of 26 patches have a Reviewed-by or Acked-by.

PatchShreyas BhatewaraStephen RothwellJohn W. LinvilleJames Simmons
1/25
2/25R-b
3/25
4/25R-b
5/25
6/25
7/25
7/25
8/25
9/25
10/25
11/25
12/25
13/25
14/25A-b
15/25A-b
16/25
17/25
18/25
19/25
20/25
21/25A-b
22/25
23/25
24/25
25/25

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/25] treewide-next: Use static const char arrays

Using static const char foo[] = "bar" can save some code and text space, so change the places where it's possible.

Also change the places that use

	char foo[] = "barX";
	...
	foo[3] = value + '0';
where X is typically changed
	char foo[sizeof("barX")];
	...
	sprintf(foo, "bar%c", value + '0');

Joe Perches (25):
arch/mips: Use static const char arrays arch/powerpc: Use static const char arrays drivers/acpi: Use static const char arrays drivers/char: Use static const char arrays drivers/i2c: Use static const char arrays drivers/isdn: Use static const char arrays drivers/media: Use static const char arrays drivers/net/atl1c: Use static const char arrays drivers/net/atl1e: Use static const char arrays drivers/net/(intel): Use static const char arrays drivers/net/netxen: Use static const char arrays drivers/net/qlcnic: Use static const char arrays drivers/net/spider_net.c: Use static const char arrays drivers/net/vnxnet3: Use static const char arrays drivers/net/wireless/ipw2x00: Use static const char arrays drivers/s390/char: Use static const char arrays drivers/scsi: Use static const char arrays drivers/serial/suncore.c: Use static const char arrays drivers/staging: Use static const char arrays drivers/usb: Use static const char arrays drivers/video: Use static const char arrays net/dsa: Use static const char arrays net/sunrpc: Use static const char arrays
sound: Use static const char arrays tools/perf/util: Use static const char arrays

 arch/mips/pnx8550/common/reset.c                   |    4 ++--
 arch/powerpc/boot/addnote.c                        |    4 ++--
 arch/powerpc/boot/cuboot-c2k.c                     |    4 ++--
 arch/powerpc/kernel/irq.c                          |    2 +-
 drivers/acpi/sleep.c                               |    4 ++--
 drivers/char/hvc_vio.c                             |    2 +-
 drivers/i2c/busses/i2c-stu300.c                    |    4 ++--
 drivers/isdn/hysdn/hycapi.c                        |    2 +-
 drivers/isdn/mISDN/dsp_cmx.c                       |    2 +-
 drivers/media/video/zoran/zoran_device.c           |    5 ++---
 drivers/net/atl1c/atl1c.h                          |    4 ++--
 drivers/net/atl1c/atl1c_main.c                     |    4 ++--
 drivers/net/atl1e/atl1e.h                          |    4 ++--
 drivers/net/atl1e/atl1e_main.c                     |    4 ++--
 drivers/net/e1000/e1000.h                          |    2 +-
 drivers/net/e1000/e1000_main.c                     |    4 ++--
 drivers/net/e1000e/e1000.h                         |    2 +-
 drivers/net/e1000e/netdev.c                        |    2 +-
 drivers/net/igb/igb.h                              |    4 ++--
 drivers/net/igb/igb_main.c                         |    4 ++--
 drivers/net/igbvf/igbvf.h                          |    2 +-
 drivers/net/igbvf/netdev.c                         |    2 +-
 drivers/net/ixgb/ixgb.h                            |    2 +-
 drivers/net/ixgb/ixgb_main.c                       |    2 +-
 drivers/net/ixgbe/ixgbe.h                          |    2 +-
 drivers/net/ixgbe/ixgbe_main.c                     |    4 ++--
 drivers/net/ixgbevf/ixgbevf.h                      |    2 +-
 drivers/net/ixgbevf/ixgbevf_main.c                 |    2 +-
 drivers/net/netxen/netxen_nic.h                    |    2 +-
 drivers/net/netxen/netxen_nic_main.c               |    2 +-
 drivers/net/qlcnic/qlcnic.h                        |    2 +-
 drivers/net/qlcnic/qlcnic_main.c                   |    2 +-
 drivers/net/spider_net.c                           |    2 +-
 drivers/net/vmxnet3/vmxnet3_drv.c                  |    2 +-
 drivers/net/vmxnet3/vmxnet3_int.h                  |    2 +-
 drivers/net/wireless/ipw2x00/ipw2100.c             |    2 +-
 drivers/net/wireless/ipw2x00/ipw2200.c             |    2 +-
 drivers/net/wireless/ipw2x00/libipw_module.c       |    2 +-
 drivers/s390/char/vmlogrdr.c                       |    4 ++--
 drivers/scsi/bnx2i/bnx2i_hwi.c                     |    6 +++---
 drivers/scsi/lpfc/lpfc_init.c                      |    2 +-
 drivers/scsi/megaraid/megaraid_mbox.c              |    6 +++---
 drivers/serial/suncore.c                           |    4 ++--
 drivers/staging/brcm80211/util/bcmutils.c          |    2 +-
 drivers/staging/comedi/drivers/comedi_bond.c       |    2 +-
 drivers/staging/cxt1e1/ossiRelease.c               |    2 +-
 drivers/staging/go7007/go7007-driver.c             |    2 +-
 drivers/staging/msm/mdp.c                          |    2 +-
 .../staging/rtl8192e/ieee80211/ieee80211_module.c  |    2 +-
 .../staging/rtl8192u/ieee80211/ieee80211_module.c  |    2 +-
 drivers/staging/tidspbridge/rmgr/dbdcd.c           |    6 +++---
 drivers/usb/atm/ueagle-atm.c                       |   14 +++++---------
 drivers/usb/otg/langwell_otg.c                     |    2 +-
 drivers/video/sh_mipi_dsi.c                        |    4 ++--
 drivers/video/sis/sis_main.c                       |   10 +++++-----
 drivers/video/via/viafbdev.c                       |    2 +-
 net/dsa/dsa.c                                      |    2 +-
 net/dsa/dsa_priv.h                                 |    2 +-
 net/sunrpc/auth_gss/gss_krb5_mech.c                |    2 +-
 sound/core/misc.c                                  |    5 ++++-
 tools/perf/util/ui/setup.c                         |    3 ++-
 tools/perf/util/ui/util.c                          |    3 ++-
 62 files changed, 98 insertions(+), 98 deletions(-)
Signature · 1 line
1.7.3.rc1