Fixes from clang
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest30 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/30 | Fix clang warning for ntohl(*((uint32_t *)buf))daemons/ daemons/ | +19 | 1 reply | |
| 2/30 | Use dm_pool_grow_object embeded strlen for 0 deltalib/ lib/ lib/ +3 more | +10 | 1 reply | |
| 2/30 | Use dm_pool_grow_object embeded strlen for 0 delta | +0 | 1 reply | |
| 3/30 | Check (type) is not NULL before accesslibdm/ | +4 | 1 reply | |
| 4/30 | Fix NULL pointer dereferencelib/ | +1 | 1 reply | |
| 5/30 | Print vg_name and do not to access vg->nametools/ | +1 | 1 reply | |
| 6/30 | Ensure we always have origin definedtools/ | +4 | 1 reply | |
| 7/30 | Ensure seg is nonnulllib/ | +1 | 1 reply | |
| 8/30 | Ensure first is not NULLlib/ | +1 | 1 reply | |
| 9/30 | Reuse result of previous strchr.tools/ | +1 | 1 reply | |
| 10/30 | Fix potential NULL pointer dereferencetools/ | +3 | 1 reply | |
| 11/30 | Fix theoretical usage of NULL pointer dereferencelibdm/ | +3 | 1 reply | |
| 12/30 | Check for NULL pointertools/ | +1 | 0 replies | |
| 13/30 | Eliminate uninitialized_varlib/ | +2 | 1 reply | |
| 13/30 | Eliminate uninitialized_var | +0 | 1 reply | |
| 14/30 | Fix missing initilisation to 0daemons/ | +1 | 1 reply | |
| 15/30 | Function pull_state cannot work with NULL bufferdaemons/ | +3 | 1 reply | |
| 16/30 | Fix void* pointer arithmeticlib/ | +2 | 2 replies | |
| 16/30 | Fix void* pointer arithmetic | +0 | 1 reply | |
| 16/30 | Fix void* pointer arithmetic | +0 | 0 replies | |
| 17/30 | Use const pvid for device_from_pvid()lib/ lib/ | +2 | 1 reply | |
| 18/30 | Use const pointer for return value of dm_basenamelibdm/ libdm/ | +4 | 1 reply | |
| 19/30 | Fix constness warninglib/ | +4 | 1 reply | |
| 20/30 | Fix constness warninglib/ | +1 | 1 reply | |
| 21/30 | Fix constness warninglib/ | +3 | 1 reply | |
| 22/30 | Fix constness warningtools/ | +1 | 1 reply | |
| 23/30 | Using const config nodelib/ | +1 | 1 reply | |
| 24/30 | bufused is assigned 0 in preceding source linelib/ | +1 | 1 reply | |
| 25/30 | Proper C declarationdaemons/ | +2 | 1 reply | |
| 26/30 | Use staticlibdm/ | +4 | 1 reply | |
| 27/30 | Instrument compiler about code unreachabilitydaemons/ | +5 | 1 reply | |
| 28/30 | Skip uninitialized macro for scan-buildlib/ | +4 | 1 reply | |
| 29/30 | Add some __attribute__ instrumentationlibdm/ | +13 | 1 reply | |
| 29/30 | Add some __attribute__ instrumentation | +0 | 0 replies | |
| 30/30 | __attribute__((nonnull(1)))lib/ libdm/ | +3 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/30] Fixes from clang
Patchset combines code cleanups for compiler warnings and code fixes found by static analyzer scan-build.
Potentional NULL pointer dereferencies are mostly in very unusual code execution paths. I've tried to order them on their importance - the later ones are not event trigerable as surrounding code should not be to pass problematic values - but checks seems to be simple enough to keep static analysis happy.
Last patches in this set add some instrumentation to function calls that might allow better code optimization or better static analysis.
Zdenek Kabelac (30):
Fix clang warning for ntohl(*((uint32_t *)buf)) Use dm_pool_grow_object embeded strlen for 0 delta Check (type) is not NULL before access
Fix NULL pointer dereference
Print vg_name and do not to access vg->name Ensure we always have origin defined Ensure seg is nonnull
Ensure first is not NULL
Reuse result of previous strchr.
Fix potential NULL pointer dereference
Fix theoretical usage of NULL pointer dereference Check for NULL pointer
Eliminate uninitialized_var
Fix missing initilisation to 0
Function pull_state cannot work with NULL buffer Fix void* pointer arithmetic
Use const pvid for device_from_pvid()
Use const pointer for return value of dm_basename Fix constness warning
Fix constness warning
Fix constness warning
Fix constness warning
Using const config node
bufused is assigned 0 in preceding source line Proper C declaration
Use static
Instrument compiler about code unreachability Skip uninitialized macro for scan-build Add some __attribute__ instrumentation __attribute__((nonnull(1)))
daemons/clvmd/clvmd.c | 7 +++++-- daemons/cmirrord/cluster.c | 2 +- daemons/cmirrord/functions.c | 4 +++- daemons/dmeventd/dmeventd.c | 21 +++++++++++---------- daemons/dmeventd/libdevmapper-event.c | 20 ++++++++++---------- lib/activate/dev_manager.c | 2 +- lib/cache/lvmcache.c | 10 +++++----- lib/cache/lvmcache.h | 2 +- lib/config/config.c | 2 +- lib/device/dev-cache.h | 2 +- lib/device/dev-md.c | 3 ++- lib/format1/format1.c | 2 +- lib/format_text/archive.c | 4 ++-- lib/format_text/format-text.c | 2 +- lib/log/log.c | 2 +- lib/metadata/lv_manip.c | 2 +- lib/metadata/metadata.c | 6 +++--- lib/misc/crc.c | 6 +++--- lib/misc/util.h | 4 ++++ lib/mm/memlock.c | 4 ++-- lib/report/report.c | 6 +++--- lib/striped/striped.c | 2 +- libdm/libdevmapper.h | 28 ++++++++++++++-------------- libdm/libdm-report.c | 7 ++++--- libdm/libdm-string.c | 6 +++--- libdm/mm/pool-fast.c | 8 ++++---- libdm/regex/ttree.c | 7 +++++-- tools/dmsetup.c | 2 +- tools/lvcreate.c | 4 ++++ tools/lvm.c | 6 +++--- tools/lvmcmdline.c | 2 +- tools/pvresize.c | 2 +- tools/reporter.c | 2 +- tools/toollib.c | 2 +- 34 files changed, 105 insertions(+), 86 deletions(-)
--
1.7.3.1