Skip to content

Cleanup WARN #defines

Joe Perches alsa-devel dri-devel intel-gfx linux-acpi linux-alpha linux-arch linux-arm-kernel linux-fbdev linux-fsdevel linux-media linux-mm linux-nfs linux-omap linux-pm linux-scsi linux-wireless linuxppc-dev lkml netdev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest39 patches 25 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/39include/asm-generic/bug.h: Update WARN macrosinclude/asm-generic/bug.h+61 -400 replies
2/39arch/alpha: Update WARN usesarch/alpha/kernel/pci-sysfs.c+6 -84 replies
3/39arch/arm: Update WARN usesarch/arm/mach-davinci/clock.c arch/arm/mach-davinci/da830.c arch/arm/mach-davinci/da850.c +11 more+69 -690 replies
4/39arch/powerpc: Update WARN usesarch/powerpc/kernel/hw_breakpoint.c+2 -25 replies
5/39arch/x86: Update WARN usesarch/x86/kernel/acpi/boot.c arch/x86/kernel/apic/apic.c arch/x86/kernel/apic/es7000_32.c +8 more+17 -192 replies
6/39drivers/acpi: Update WARN usesdrivers/acpi/ec.c+2 -20 replies
7/39drivers/base: Update WARN usesdrivers/base/class.c drivers/base/core.c drivers/base/memory.c +1 more+10 -130 replies
8/39drivers/block: Update WARN usesdrivers/block/floppy.c+1 -10 replies
9/39drivers/cpuidle: Update WARN usesdrivers/cpuidle/driver.c+1 -10 replies
10/39drivers/firewire: Update WARN usesdrivers/firewire/core-transaction.c+3 -31 reply
11/39drivers/firmware: Update WARN usesdrivers/firmware/dmi_scan.c+1 -10 replies
12/39drivers/gpio: Update WARN usesdrivers/gpio/gpiolib.c drivers/gpio/it8761e_gpio.c+3 -30 replies
13/39drivers/gpu/drm: Update WARN usesdrivers/gpu/drm/drm_crtc_helper.c drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/radeon/evergreen.c +7 more+15 -140 replies
14/39drivers/media/video: Update WARN usesdrivers/media/video/s5p-fimc/fimc-core.c drivers/media/video/sr030pc30.c+2 -20 replies
15/39drivers/mfd: Update WARN usesdrivers/mfd/ezx-pcap.c+2 -31 reply
16/39drivers/net/can: Update WARN usesdrivers/net/can/mscan/mscan.c+1 -11 reply
17/39drivers/net/usb: Update WARN usesdrivers/net/usb/ipheth.c+1 -11 reply
18/39drivers/net/wireless/iwlwifi: Update WARN usesdrivers/net/wireless/iwlwifi/iwl-agn-lib.c drivers/net/wireless/iwlwifi/iwl-agn-sta.c drivers/net/wireless/iwlwifi/iwl-tx.c +1 more+8 -90 replies
19/39drivers/regulator: Update WARN usesdrivers/regulator/core.c+1 -21 reply
20/39drivers/scsi/fcoe: Update WARN usesdrivers/scsi/fcoe/libfcoe.c+1 -10 replies
21/39drivers/staging: Update WARN usesdrivers/staging/memrar/memrar_allocator.c drivers/staging/solo6x10/solo6010-v4l2-enc.c+2 -21 reply
22/39drivers/usb/musb: Update WARN usesdrivers/usb/musb/musb_host.c+3 -33 replies
23/39drivers/video/omap2/dss: Update WARN usesdrivers/video/omap2/dss/core.c+1 -20 replies
24/39fs/nfsd: Update WARN usesfs/nfsd/nfs4state.c+2 -10 replies
25/39fs/notify/inotify: Update WARN usesfs/notify/inotify/inotify_fsnotify.c+2 -20 replies
26/39fs/sysfs: Update WARN usesfs/sysfs/dir.c fs/sysfs/file.c fs/sysfs/group.c +1 more+9 -120 replies
27/39fs/proc: Update WARN usesfs/proc/generic.c+4 -50 replies
28/39fs: Update WARN usesfs/bio.c fs/buffer.c fs/super.c+5 -40 replies
29/39include/linux/device.h: Update WARN usesinclude/linux/device.h+1 -10 replies
30/39kernel/irq: Update WARN useskernel/irq/chip.c kernel/irq/manage.c+2 -20 replies
31/39kernel/panic.c: Update warn_slowpath to use %pVkernel/panic.c+18 -220 replies
32/39kernel: Update WARN useskernel/notifier.c kernel/pm_qos_params.c+4 -40 replies
33/39lib: Update WARN useslib/debugobjects.c lib/iomap.c lib/kobject.c +3 more+33 -390 replies
34/39mm: Update WARN usesmm/percpu.c mm/vmalloc.c+4 -51 reply
35/39net/core/dev.c: Update WARN usesnet/core/dev.c+1 -21 reply
36/39net/ipv4/tcp.c: Update WARN usesnet/ipv4/tcp.c+7 -91 reply
37/39net/mac80211: Update WARN usesnet/mac80211/agg-tx.c net/mac80211/iface.c net/mac80211/mlme.c +4 more+11 -161 reply
38/39net/rfkill/input.c: Update WARN usesnet/rfkill/input.c+2 -30 replies
39/39sound/soc/codecs/wm_hubs.c: Update WARN usessound/soc/codecs/wm_hubs.c+1 -11 reply

Reviews trailers per patch

2 of 39 patches have a Reviewed-by or Acked-by.

PatchMark BrownFelipe Balbi
1/39
2/39
3/39
4/39
5/39
6/39
7/39
8/39
9/39
10/39
11/39
12/39
13/39
14/39
15/39
16/39
17/39
18/39
19/39A-b
20/39
21/39
22/39A-b
23/39
24/39
25/39
26/39
27/39
28/39
29/39
30/39
31/39
32/39
33/39
34/39
35/39
36/39
37/39
38/39
39/39

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/39] Cleanup WARN #defines

WARN uses sometimes use KERN_<level> but mostly don't have any prefix.

Change the WARN macros and the warn_slowpath function to preface KERN_WARNING and remove all the KERN_<level> uses from WARN sites.

Neatening clean up of include/asm-generic/bug.h

Update WARN macros
Add KERN_WARNING to WARN output
Remove any KERN_<level> from WARN uses
Coalesce formats
Align WARN arguments
Add some missing newlines to WARN uses
Add some missing first test argument (1, fmt, args) to WARN uses

Joe Perches (39):
include/asm-generic/bug.h: Update WARN macros
arch/alpha: Update WARN uses
arch/arm: Update WARN uses
arch/powerpc: Update WARN uses
arch/x86: Update WARN uses
drivers/acpi: Update WARN uses
drivers/base: Update WARN uses
drivers/block: Update WARN uses
drivers/cpuidle: Update WARN uses
drivers/firewire: Update WARN uses
drivers/firmware: Update WARN uses
drivers/gpio: Update WARN uses
drivers/gpu/drm: Update WARN uses
drivers/media/video: Update WARN uses
drivers/mfd: Update WARN uses
drivers/net/can: Update WARN uses
drivers/net/usb: Update WARN uses
drivers/net/wireless/iwlwifi: Update WARN uses
drivers/regulator: Update WARN uses
drivers/scsi/fcoe: Update WARN uses
drivers/staging: Update WARN uses
drivers/usb/musb: Update WARN uses
drivers/video/omap2/dss: Update WARN uses
fs/nfsd: Update WARN uses
fs/notify/inotify: Update WARN uses
fs/sysfs: Update WARN uses
fs/proc: Update WARN uses
fs: Update WARN uses
include/linux/device.h: Update WARN uses
kernel/irq: Update WARN uses
kernel/panic.c: Update warn_slowpath to use %pV
kernel: Update WARN uses
lib: Update WARN uses
mm: Update WARN uses
net/core/dev.c: Update WARN uses
net/ipv4/tcp.c: Update WARN uses
net/mac80211: Update WARN uses
net/rfkill/input.c: Update WARN uses
sound/soc/codecs/wm_hubs.c: Update WARN uses

 arch/alpha/kernel/pci-sysfs.c                |   14 ++--
 arch/arm/mach-davinci/clock.c                |    4 +-
 arch/arm/mach-davinci/da830.c                |    2 +-
 arch/arm/mach-davinci/da850.c                |   12 ++--
 arch/arm/mach-omap2/clkt_clksel.c            |   12 ++--
 arch/arm/mach-omap2/clock.c                  |   16 ++--
 arch/arm/mach-omap2/devices.c                |    4 +-
 arch/arm/mach-omap2/omap_hwmod.c             |   47 +++++++-----
 arch/arm/mach-omap2/pm34xx.c                 |    7 +-
 arch/arm/mach-omap2/serial.c                 |    2 +-
 arch/arm/mach-omap2/timer-gp.c               |    3 +-
 arch/arm/mach-tegra/clock.c                  |    3 +-
 arch/arm/mach-tegra/timer.c                  |    2 +-
 arch/arm/mach-u300/padmux.c                  |   14 +---
 arch/arm/plat-omap/omap-pm-noop.c            |   10 ++--
 arch/powerpc/kernel/hw_breakpoint.c          |    4 +-
 arch/x86/kernel/acpi/boot.c                  |    2 +-
 arch/x86/kernel/apic/apic.c                  |    2 +-
 arch/x86/kernel/apic/es7000_32.c             |    2 +-
 arch/x86/kernel/cpu/perf_event.c             |    4 +-
 arch/x86/kernel/pci-calgary_64.c             |    4 +-
 arch/x86/kernel/tsc_sync.c                   |    4 +-
 arch/x86/kernel/xsave.c                      |    2 +-
 arch/x86/mm/ioremap.c                        |    5 +-
 arch/x86/mm/pageattr-test.c                  |    2 +-
 arch/x86/mm/pageattr.c                       |    5 +-
 arch/x86/platform/sfi/sfi.c                  |    4 +-
 drivers/acpi/ec.c                            |    4 +-
 drivers/base/class.c                         |    4 +-
 drivers/base/core.c                          |    5 +-
 drivers/base/memory.c                        |    4 +-
 drivers/base/sys.c                           |   10 +--
 drivers/block/floppy.c                       |    2 +-
 drivers/cpuidle/driver.c                     |    2 +-
 drivers/firewire/core-transaction.c          |    6 +-
 drivers/firmware/dmi_scan.c                  |    2 +-
 drivers/gpio/gpiolib.c                       |    4 +-
 drivers/gpio/it8761e_gpio.c                  |    2 +-
 drivers/gpu/drm/drm_crtc_helper.c            |    2 +-
 drivers/gpu/drm/i915/i915_gem.c              |    3 +-
 drivers/gpu/drm/radeon/evergreen.c           |    2 +-
 drivers/gpu/drm/radeon/r100.c                |    4 +-
 drivers/gpu/drm/radeon/r300.c                |    2 +-
 drivers/gpu/drm/radeon/r600.c                |    4 +-
 drivers/gpu/drm/radeon/radeon_fence.c        |    3 +-
 drivers/gpu/drm/radeon/radeon_ttm.c          |    3 +-
 drivers/gpu/drm/radeon/rs400.c               |    2 +-
 drivers/gpu/drm/radeon/rs600.c               |    4 +-
 drivers/media/video/s5p-fimc/fimc-core.c     |    2 +-
 drivers/media/video/sr030pc30.c              |    2 +-
 drivers/mfd/ezx-pcap.c                       |    5 +-
 drivers/net/can/mscan/mscan.c                |    2 +-
 drivers/net/usb/ipheth.c                     |    2 +-
 drivers/net/wireless/iwlwifi/iwl-agn-lib.c   |    3 +-
 drivers/net/wireless/iwlwifi/iwl-agn-sta.c   |    6 +-
 drivers/net/wireless/iwlwifi/iwl-tx.c        |    6 +-
 drivers/net/wireless/iwlwifi/iwl3945-base.c  |    2 +-
 drivers/regulator/core.c                     |    3 +-
 drivers/scsi/fcoe/libfcoe.c                  |    2 +-
 drivers/staging/memrar/memrar_allocator.c    |    2 +-
 drivers/staging/solo6x10/solo6010-v4l2-enc.c |    2 +-
 drivers/usb/musb/musb_host.c                 |    6 +-
 drivers/video/omap2/dss/core.c               |    3 +-
 fs/bio.c                                     |    2 +-
 fs/buffer.c                                  |    2 +-
 fs/nfsd/nfs4state.c                          |    3 +-
 fs/notify/inotify/inotify_fsnotify.c         |    4 +-
 fs/proc/generic.c                            |    9 +--
 fs/super.c                                   |    5 +-
 fs/sysfs/dir.c                               |    3 +-
 fs/sysfs/file.c                              |    4 +-
 fs/sysfs/group.c                             |    4 +-
 fs/sysfs/symlink.c                           |   10 +--
 include/asm-generic/bug.h                    |  101 ++++++++++++++++----------
 include/linux/device.h                       |    2 +-
 kernel/irq/chip.c                            |    2 +-
 kernel/irq/manage.c                          |    2 +-
 kernel/notifier.c                            |    2 +-
 kernel/panic.c                               |   40 +++++------
 kernel/pm_qos_params.c                       |    6 +-
 lib/debugobjects.c                           |   21 +++---
 lib/iomap.c                                  |    2 +-
 lib/kobject.c                                |    9 +--
 lib/kobject_uevent.c                         |    4 +-
 lib/list_debug.c                             |   24 +++----
 lib/plist.c                                  |   12 ++--
 mm/percpu.c                                  |    4 +-
 mm/vmalloc.c                                 |    5 +-
 net/core/dev.c                               |    3 +-
 net/ipv4/tcp.c                               |   16 ++---
 net/mac80211/agg-tx.c                        |    5 +-
 net/mac80211/iface.c                         |    4 +-
 net/mac80211/mlme.c                          |    2 +-
 net/mac80211/rx.c                            |    4 +-
 net/mac80211/tx.c                            |    4 +-
 net/mac80211/util.c                          |    4 +-
 net/mac80211/work.c                          |    4 +-
 net/rfkill/input.c                           |    5 +-
 sound/soc/codecs/wm_hubs.c                   |    2 +-
 99 files changed, 319 insertions(+), 330 deletions(-)
Signature · 1 line
1.7.3.1.g432b3.dirty