Skip to content

FLUSH/FUA updates for Xen blkfront

Jeremy Fitzhardinge lkml xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xen/blkfront: map REQ_FLUSH into a full barrierdrivers/block/xen-blkfront.c+5 -140 replies
2/4xen/blkfront: change blk_shadow.request to proper pointerdrivers/block/xen-blkfront.c+6 -80 replies
3/4xen/blkfront: Implement FUA with BLKIF_OP_WRITE_BARRIERdrivers/block/xen-blkfront.c+12 -20 replies
4/4xen/blkfront: cope with backend that fail empty BLKIF_OP_WRITE_BARRIER requestsdrivers/block/xen-blkfront.c+8 -01 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/4A-b
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] FLUSH/FUA updates for Xen blkfront

From: Jeremy Fitzhardinge <[email protected]>

Update the Xen blockfront driver to deal with the block layer's cache flush and FUA operations.

The only primitive we have for implementing these is BLKIF_OP_WRITE_BARRIER, which is a fully ordered write operation. This is much stronger than a simple cache flush which Linux requires, but it will do the job.

It can also implement FUA, since it will guarantee that the data is written to stable storage when it completes - however it also implements full ordering, which makes it equivalent to a FLUSH+FUA.

Unfortunately it appears that the actual Xen backend implementation will fail an empty BLKIF_OP_WRITE_BARRIER operation. If that happens, disable use of WRITE_BARRIER. (Daniel, I don't know if this is deliberate or not; I couldn't see where the error was coming from).

Jeremy Fitzhardinge (4):
xen/blkfront: map REQ_FLUSH into a full barrier xen/blkfront: change blk_shadow.request to proper pointer xen/blkfront: Implement FUA with BLKIF_OP_WRITE_BARRIER xen/blkfront: cope with backend that fail empty
BLKIF_OP_WRITE_BARRIER requests

 drivers/block/xen-blkfront.c |   53 +++++++++++++++++++++++------------------
 1 files changed, 30 insertions(+), 23 deletions(-)
Signature · 1 line
1.7.2.3