Skip to content

Handling of rfc1991 signatures

Michael J Gruber git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v15 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5t/t7004-tag: test handling of rfc1991 signaturest/t7004-tag.sh+66 -00 replies
2/5verify-tag: factor out signature detectionbuiltin/verify-tag.c tag.c tag.h+16 -80 replies
3/5tag: factor out sig detection for body editsbuiltin/tag.c+2 -100 replies
4/5tag: factor out sig detection for tag displaybuiltin/tag.c+2 -20 replies
5/5tag: recognize rfc1991 signaturest/t7004-tag.sh tag.c+9 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/5] Handling of rfc1991 signatures

This mini-series fixes the handling of signed tags for users with "rfc1991" in their gpg config. In fact, the refactoring done in the middle three patches would be worthwhile even without the side effect of having to fix the handling in one place only rather than three...

v2 has these changes:
* additional tests for dealing with rfc1991 sigs without the rfc1991 option set (1/5)
* macros in tag.c rather than tag.h since they are used only in tag.c (2/5)
* logical && at eol for continued logical expression in C (5/5)

Michael J Gruber (5):
t/t7004-tag: test handling of rfc1991 signatures
verify-tag: factor out signature detection
tag: factor out sig detection for body edits
tag: factor out sig detection for tag display
tag: recognize rfc1991 signatures

 builtin/tag.c        |   16 +++---------
 builtin/verify-tag.c |   10 +------
 t/t7004-tag.sh       |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tag.c                |   15 +++++++++++
 tag.h                |    1 +
 5 files changed, 88 insertions(+), 20 deletions(-)
Signature · 1 line
1.7.3.2.193.g78bbb