Skip to content

PV ticket locks without expanding spinlock

Jeremy Fitzhardinge kvm lkml virtualization xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 53 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14x86/ticketlock: clean up types and accessorsarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+28 -162 replies
1/14x86/ticketlock: clean up types and accessorsarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+28 -160 replies
2/14x86/ticketlock: convert spin loop to Carch/x86/include/asm/spinlock.h+30 -300 replies
2/14x86/ticketlock: convert spin loop to Carch/x86/include/asm/spinlock.h+30 -300 replies
3/14x86/ticketlock: Use C for __ticket_spin_unlockarch/x86/include/asm/spinlock.h+17 -150 replies
3/14x86/ticketlock: Use C for __ticket_spin_unlockarch/x86/include/asm/spinlock.h+17 -150 replies
4/14x86/ticketlock: make large and small ticket versions of spin_lock the samearch/x86/include/asm/spinlock.h+8 -150 replies
4/14x86/ticketlock: make large and small ticket versions of spin_lock the samearch/x86/include/asm/spinlock.h+8 -150 replies
5/14x86/ticketlock: make __ticket_spin_lock commonarch/x86/include/asm/spinlock.h+20 -220 replies
5/14x86/ticketlock: make __ticket_spin_lock commonarch/x86/include/asm/spinlock.h+20 -220 replies
6/14x86/ticketlock: make __ticket_spin_trylock commonarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+14 -410 replies
6/14x86/ticketlock: make __ticket_spin_trylock commonarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+14 -410 replies
7/14x86/spinlocks: replace pv spinlocks with pv ticketlocksarch/x86/include/asm/paravirt.h arch/x86/include/asm/paravirt_types.h arch/x86/include/asm/spinlock.h +2 more+50 -540 replies
7/14x86/spinlocks: replace pv spinlocks with pv ticketlocksarch/x86/include/asm/paravirt.h arch/x86/include/asm/paravirt_types.h arch/x86/include/asm/spinlock.h +2 more+50 -540 replies
8/14x86/ticketlock: collapse a layer of functionsarch/x86/include/asm/spinlock.h+5 -300 replies
8/14x86/ticketlock: collapse a layer of functionsarch/x86/include/asm/spinlock.h+5 -300 replies
9/14xen/pvticketlock: Xen implementation for PV ticket locksarch/x86/xen/spinlock.c+36 -24510 replies
9/14xen/pvticketlock: Xen implementation for PV ticket locksarch/x86/xen/spinlock.c+36 -2450 replies
10/14x86/pvticketlock: use callee-save for lock_spinningarch/x86/include/asm/paravirt.h arch/x86/include/asm/paravirt_types.h arch/x86/kernel/paravirt-spinlocks.c +1 more+5 -40 replies
10/14x86/pvticketlock: use callee-save for lock_spinningarch/x86/include/asm/paravirt.h arch/x86/include/asm/paravirt_types.h arch/x86/kernel/paravirt-spinlocks.c +1 more+5 -40 replies
11/14x86/ticketlock: don't inline _spin_unlock when using paravirt spinlocksarch/x86/Kconfig kernel/Kconfig.locks+4 -10 replies
11/14x86/ticketlock: don't inline _spin_unlock when using paravirt spinlocksarch/x86/Kconfig kernel/Kconfig.locks+4 -10 replies
12/14x86/ticketlocks: when paravirtualizing ticket locks, increment by 2arch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+18 -100 replies
12/14x86/ticketlocks: when paravirtualizing ticket locks, increment by 2arch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h+18 -100 replies
13/14x86/ticketlock: add slowpath logicarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h arch/x86/kernel/paravirt-spinlocks.c +1 more+88 -837 replies
13/14x86/ticketlock: add slowpath logicarch/x86/include/asm/spinlock.h arch/x86/include/asm/spinlock_types.h arch/x86/kernel/paravirt-spinlocks.c +1 more+88 -80 replies
14/14x86/ticketlocks: tidy up __ticket_unlock_kick()arch/x86/include/asm/paravirt.h arch/x86/include/asm/spinlock.h+1 -150 replies
14/14x86/ticketlocks: tidy up __ticket_unlock_kick()arch/x86/include/asm/paravirt.h arch/x86/include/asm/spinlock.h+1 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] PV ticket locks without expanding spinlock

From: Jeremy Fitzhardinge <[email protected]>

Hi all,

This is a revised version of the pvticket lock series.

The early part of the series is mostly unchanged: it converts the bulk of the ticket lock code into C and makes the "small" and "large" ticket code common. The only changes are the incorporation of various review comments.

The latter part of the series converts from pv spinlocks to pv ticket locks (ie, using the ticket lock fastpath as-is, but adding pv ops for the ticketlock slowpaths).

The significant difference here is that rather than adding a new ticket_t-sized element to arch_spinlock_t - effectively doubling the size - I steal the LSB of the tickets themselves to store a bit. This allows the structure to remain the same size, but at the cost of halving the max number of CPUs (127 for a 8-bit ticket, and a hard max of 32767 overall).

The extra bit (well, two, but one is unused) in indicates whether the lock has gone into "slowpath state", which means one of its lockers has entered its slowpath and has blocked in the hypervisor. This means the current lock-holder needs to make sure it gets kicked out of the hypervisor on unlock.

The spinlock remains in slowpath state until the last unlock happens (ie there are no more queued lockers).

This code survives for a while with moderate testing, (make -j 100 on 8 VCPUs on a 4 PCPU system), but locks up after about 20 iterations, so there's still some race/deadlock in there (probably something misordered), but I think the basic approach is sound.

Thanks,
J

Jeremy Fitzhardinge (14):
x86/ticketlock: clean up types and accessors x86/ticketlock: convert spin loop to C
x86/ticketlock: Use C for __ticket_spin_unlock x86/ticketlock: make large and small ticket versions of spin_lock the
same
x86/ticketlock: make __ticket_spin_lock common x86/ticketlock: make __ticket_spin_trylock common x86/spinlocks: replace pv spinlocks with pv ticketlocks x86/ticketlock: collapse a layer of functions xen/pvticketlock: Xen implementation for PV ticket locks x86/pvticketlock: use callee-save for lock_spinning x86/ticketlock: don't inline _spin_unlock when using paravirt
spinlocks
x86/ticketlocks: when paravirtualizing ticket locks, increment by 2 x86/ticketlock: add slowpath logic
x86/ticketlocks: tidy up __ticket_unlock_kick()

 arch/x86/Kconfig                      |    3 +
 arch/x86/include/asm/paravirt.h       |   30 +---
 arch/x86/include/asm/paravirt_types.h |    8 +-
 arch/x86/include/asm/spinlock.h       |  236 +++++++++++++---------------
 arch/x86/include/asm/spinlock_types.h |   32 ++++-
 arch/x86/kernel/paravirt-spinlocks.c  |   52 +++++--
 arch/x86/xen/spinlock.c               |  281 +++++----------------------------
 kernel/Kconfig.locks                  |    2 +-
 8 files changed, 231 insertions(+), 413 deletions(-)
Signature · 1 line
1.7.2.3