Skip to content

drivers/net: Use static const

Joe Perches ath9k-devel linux-wireless lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest62 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/623c501: Use static constdrivers/net/3c501.c+2 -20 replies
2/623c503: Use static constdrivers/net/3c503.c+2 -20 replies
3/623c507: Use static constdrivers/net/3c507.c+2 -20 replies
4/623c527: Use static constdrivers/net/3c527.c+3 -30 replies
5/62at1700: Use static constdrivers/net/at1700.c+3 -30 replies
6/62benet: Use static constdrivers/net/benet/be_ethtool.c drivers/net/benet/be_main.c+8 -60 replies
7/62bnx2: Use static constdrivers/net/bnx2.c+24 -220 replies
8/62bnx2x: Use static constdrivers/net/bnx2x/bnx2x_main.c+4 -20 replies
9/62can: Use static constdrivers/net/can/sja1000/plx_pci.c+1 -10 replies
10/62chelsio: Use static constdrivers/net/chelsio/sge.c+4 -60 replies
11/62cxgb3: Use static constdrivers/net/cxgb3/ael1002.c+12 -120 replies
12/62cxgb3: Use static constdrivers/net/cxgb3/t3_hw.c+1 -10 replies
13/62cxgb4: Use static constdrivers/net/cxgb4/t4_hw.c+24 -240 replies
14/62cxgb4vf: Use static constdrivers/net/cxgb4vf/t4vf_hw.c+1 -11 reply
15/62e1000: Use static constdrivers/net/e1000/e1000_hw.c+4 -40 replies
16/62e1000: Use static constdrivers/net/e1000/e1000_param.c+7 -60 replies
17/62e1000e: Use static constdrivers/net/e1000e/phy.c+6 -50 replies
18/62e2100: Use static constdrivers/net/e2100.c+1 -10 replies
19/62eepro: Use static constdrivers/net/eepro.c+5 -40 replies
20/62eexpress: Use static constdrivers/net/eexpress.c+1 -10 replies
21/62gianfar: Use static constdrivers/net/gianfar.c+6 -40 replies
22/62hp: Use static constdrivers/net/hp.c+3 -30 replies
23/62igb: Use static constdrivers/net/igb/e1000_phy.c+6 -50 replies
24/62irda: Use static constdrivers/net/irda/act200l-sir.c+1 -10 replies
25/62irda: Use static constdrivers/net/irda/donauboe.c+2 -20 replies
26/62ixgbe: Use static constdrivers/net/ixgbe/ixgbe_ethtool.c+13 -90 replies
27/62ixgbevf: Use static constdrivers/net/ixgbevf/ethtool.c+11 -70 replies
28/62ixgb: Use static constdrivers/net/ixgb/ixgb_param.c+11 -100 replies
29/62jme: Use static constdrivers/net/jme.c+2 -20 replies
30/62ksz884x: Use static constdrivers/net/ksz884x.c+10 -100 replies
31/62netxen: Use static constdrivers/net/netxen/netxen_nic_hw.c+10 -60 replies
32/62ni52: Use static constdrivers/net/ni52.c+2 -20 replies
33/62ni65: Use static constdrivers/net/ni65.c+2 -20 replies
34/62pcmcia: Use static constdrivers/net/pcmcia/nmclan_cs.c+1 -10 replies
35/62qlcnic: Use static constdrivers/net/qlcnic/qlcnic_hw.c+9 -60 replies
36/62qlge: Use static constdrivers/net/qlge/qlge_main.c+7 -60 replies
37/62r8169: Use static constdrivers/net/r8169.c+1 -10 replies
38/62s2io: Use static constdrivers/net/s2io.c+12 -81 reply
39/62skfp: Use static constdrivers/net/skfp/smt.c+2 -20 replies
40/62skge: Use static constdrivers/net/skge.c+2 -20 replies
41/62smc-ultra: Use static constdrivers/net/smc-ultra.c+6 -20 replies
42/62tg3: Use static constdrivers/net/tg3.c+12 -140 replies
43/62tokenring: Use static constdrivers/net/tokenring/ibmtr.c+3 -20 replies
44/62tulip: Use static constdrivers/net/tulip/de2104x.c+12 -60 replies
45/62tulip: Use static constdrivers/net/tulip/tulip_core.c+9 -60 replies
46/62usb: Use static constdrivers/net/usb/hso.c+16 -231 reply
47/62vmxnet3: Use static constdrivers/net/vmxnet3/vmxnet3_drv.c+3 -13 replies
48/62wan: Use static constdrivers/net/wan/dscc4.c+3 -30 replies
49/62wd: Use static constdrivers/net/wd.c+1 -10 replies
50/62ar9170: Use constdrivers/net/wireless/ath/ar9170/cmd.c+1 -10 replies
51/62ath5k: Use static constdrivers/net/wireless/ath/ath5k/ani.c+17 -170 replies
52/62ath9k: Use static constdrivers/net/wireless/ath/ath9k/ani.c drivers/net/wireless/ath/ath9k/ar5008_phy.c drivers/net/wireless/ath/ath9k/ar9002_phy.c +10 more+74 -640 replies
53/62carl9170: Use static constdrivers/net/wireless/ath/carl9170/cmd.c+1 -10 replies
54/62atmel: Use static constdrivers/net/wireless/atmel.c+4 -20 replies
55/62b43: Use static constdrivers/net/wireless/b43/phy_common.c+5 -30 replies
56/62iwlwifi: Use static constdrivers/net/wireless/b43/phy_n.c drivers/net/wireless/iwlwifi/iwl-3945.c drivers/net/wireless/iwlwifi/iwl-agn-lib.c+9 -81 reply
57/62libertas: Use static constdrivers/net/wireless/libertas/cfg.c drivers/net/wireless/libertas/rx.c+4 -20 replies
58/62ray_cs: Use static constdrivers/net/wireless/ray_cs.c+2 -20 replies
59/62rndis_wlan: Use static constdrivers/net/wireless/rndis_wlan.c+6 -30 replies
60/62rt2x00: Use static constdrivers/net/wireless/rt2x00/rt2800lib.c+1 -11 reply
61/62wl12xx: Use static constdrivers/net/wireless/wl12xx/wl1271_acx.c+3 -10 replies
62/62zd1211rw: Use constdrivers/net/wireless/zd1211rw/zd_chip.c+2 -20 replies

Reviews trailers per patch

2 of 62 patches have a Reviewed-by or Acked-by.

PatchGertjan van WingerdeShreyas N BhatewaraScott J. Goldman
1/62
2/62
3/62
4/62
5/62
6/62
7/62
8/62
9/62
10/62
11/62
12/62
13/62
14/62
15/62
16/62
17/62
18/62
19/62
20/62
21/62
22/62
23/62
24/62
25/62
26/62
27/62
28/62
29/62
30/62
31/62
32/62
33/62
34/62
35/62
36/62
37/62
38/62
39/62
40/62
41/62
42/62
43/62
44/62
45/62
46/62
47/62A-b A-b
48/62
49/62
50/62
51/62
52/62
53/62
54/62
55/62
56/62
57/62
58/62
59/62
60/62A-b
61/62
62/62

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/62] drivers/net: Use static const

Using static const generally increases object text and decreases data size. It also generally decreases overall object size.

Summary of sizes old and new. Compiled allyesconfig x86 only.

text data bss dec hex filename

2075402   67170  466644 2609216  27d040 (TOTALS) -new
2074597   70614  466668 2611879  27daa7 (TOTALS) -old

Joe Perches (62):
3c501: Use static const
3c503: Use static const
3c507: Use static const
3c527: Use static const
at1700: Use static const
benet: Use static const
bnx2: Use static const
bnx2x: Use static const
can: Use static const
chelsio: Use static const
cxgb3: Use static const
cxgb3: Use static const
cxgb4: Use static const
cxgb4vf: Use static const
e1000: Use static const
e1000: Use static const
e1000e: Use static const
e2100: Use static const
eepro: Use static const
eexpress: Use static const
gianfar: Use static const
hp: Use static const
igb: Use static const
irda: Use static const
irda: Use static const
ixgbe: Use static const
ixgbevf: Use static const
ixgb: Use static const
jme: Use static const
ksz884x: Use static const
netxen: Use static const
ni52: Use static const
ni65: Use static const
pcmcia: Use static const
qlcnic: Use static const
qlge: Use static const
r8169: Use static const
s2io: Use static const
skfp: Use static const
skge: Use static const
smc-ultra: Use static const
tg3: Use static const
tokenring: Use static const
tulip: Use static const
tulip: Use static const
usb: Use static const
vmxnet3: Use static const
wan: Use static const
wd: Use static const
ar9170: Use const
ath5k: Use static const
ath9k: Use static const
carl9170: Use static const
atmel: Use static const
b43: Use static const
iwlwifi: Use static const
libertas: Use static const
ray_cs: Use static const
rndis_wlan: Use static const
rt2x00: Use static const
wl12xx: Use static const
zd1211rw: Use const

 drivers/net/3c501.c                            |    4 +-
 drivers/net/3c503.c                            |    4 +-
 drivers/net/3c507.c                            |    4 +-
 drivers/net/3c527.c                            |    6 +-
 drivers/net/at1700.c                           |    6 +-
 drivers/net/benet/be_ethtool.c                 |    4 +-
 drivers/net/benet/be_main.c                    |   10 ++--
 drivers/net/bnx2.c                             |   46 ++++++++++++-----------
 drivers/net/bnx2x/bnx2x_main.c                 |    6 ++-
 drivers/net/can/sja1000/plx_pci.c              |    2 +-
 drivers/net/chelsio/sge.c                      |   10 ++---
 drivers/net/cxgb3/ael1002.c                    |   24 ++++++------
 drivers/net/cxgb3/t3_hw.c                      |    2 +-
 drivers/net/cxgb4/t4_hw.c                      |   48 ++++++++++++------------
 drivers/net/cxgb4vf/t4vf_hw.c                  |    2 +-
 drivers/net/e1000/e1000_hw.c                   |    8 ++--
 drivers/net/e1000/e1000_param.c                |   13 +++---
 drivers/net/e1000e/phy.c                       |   11 +++--
 drivers/net/e2100.c                            |    2 +-
 drivers/net/eepro.c                            |    9 ++--
 drivers/net/eexpress.c                         |    2 +-
 drivers/net/gianfar.c                          |   10 +++--
 drivers/net/hp.c                               |    6 +-
 drivers/net/igb/e1000_phy.c                    |   11 +++--
 drivers/net/irda/act200l-sir.c                 |    2 +-
 drivers/net/irda/donauboe.c                    |    4 +-
 drivers/net/ixgb/ixgb_param.c                  |   21 +++++-----
 drivers/net/ixgbe/ixgbe_ethtool.c              |   22 ++++++----
 drivers/net/ixgbevf/ethtool.c                  |   18 +++++---
 drivers/net/jme.c                              |    4 +-
 drivers/net/ksz884x.c                          |   20 +++++-----
 drivers/net/netxen/netxen_nic_hw.c             |   16 +++++---
 drivers/net/ni52.c                             |    4 +-
 drivers/net/ni65.c                             |    4 +-
 drivers/net/pcmcia/nmclan_cs.c                 |    2 +-
 drivers/net/qlcnic/qlcnic_hw.c                 |   15 ++++---
 drivers/net/qlge/qlge_main.c                   |   13 +++---
 drivers/net/r8169.c                            |    2 +-
 drivers/net/s2io.c                             |   20 ++++++----
 drivers/net/skfp/smt.c                         |    4 +-
 drivers/net/skge.c                             |    4 +-
 drivers/net/smc-ultra.c                        |    8 +++-
 drivers/net/tg3.c                              |   26 ++++++-------
 drivers/net/tokenring/ibmtr.c                  |    5 +-
 drivers/net/tulip/de2104x.c                    |   18 ++++++---
 drivers/net/tulip/tulip_core.c                 |   15 ++++---
 drivers/net/usb/hso.c                          |   39 ++++++++-----------
 drivers/net/vmxnet3/vmxnet3_drv.c              |    4 +-
 drivers/net/wan/dscc4.c                        |    6 +-
 drivers/net/wd.c                               |    2 +-
 drivers/net/wireless/ath/ar9170/cmd.c          |    2 +-
 drivers/net/wireless/ath/ath5k/ani.c           |   34 ++++++++--------
 drivers/net/wireless/ath/ath9k/ani.c           |    8 ++--
 drivers/net/wireless/ath/ath9k/ar5008_phy.c    |   32 ++++++++-------
 drivers/net/wireless/ath/ath9k/ar9002_phy.c    |   12 +++--
 drivers/net/wireless/ath/ath9k/ar9003_calib.c  |   10 ++--
 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c |    8 ++-
 drivers/net/wireless/ath/ath9k/ar9003_paprd.c  |    4 +-
 drivers/net/wireless/ath/ath9k/ar9003_phy.c    |    4 +-
 drivers/net/wireless/ath/ath9k/eeprom_4k.c     |   12 +++--
 drivers/net/wireless/ath/ath9k/eeprom_9287.c   |   14 +++---
 drivers/net/wireless/ath/ath9k/eeprom_def.c    |   17 +++++---
 drivers/net/wireless/ath/ath9k/htc_drv_init.c  |    2 +-
 drivers/net/wireless/ath/ath9k/hw.c            |    9 ++--
 drivers/net/wireless/ath/ath9k/rc.c            |    6 +-
 drivers/net/wireless/ath/carl9170/cmd.c        |    2 +-
 drivers/net/wireless/atmel.c                   |    6 ++-
 drivers/net/wireless/b43/phy_common.c          |    8 ++-
 drivers/net/wireless/b43/phy_n.c               |    9 ++--
 drivers/net/wireless/iwlwifi/iwl-3945.c        |    2 +-
 drivers/net/wireless/iwlwifi/iwl-agn-lib.c     |    6 +-
 drivers/net/wireless/libertas/cfg.c            |    2 +-
 drivers/net/wireless/libertas/rx.c             |    4 +-
 drivers/net/wireless/ray_cs.c                  |    4 +-
 drivers/net/wireless/rndis_wlan.c              |    9 +++-
 drivers/net/wireless/rt2x00/rt2800lib.c        |    2 +-
 drivers/net/wireless/wl12xx/wl1271_acx.c       |    4 +-
 drivers/net/wireless/zd1211rw/zd_chip.c        |    4 +-
 78 files changed, 422 insertions(+), 362 deletions(-)
Signature · 1 line
1.7.3.2.245.g03276.dirty