Fixes for analyzer problems
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest29 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/29 | Cleanup remove test for NULLlibdm/ | +4 | 1 reply | |
| 2/29 | Fix check for empty system_dirlib/ | +1 | 1 reply | |
| 2/29 | Fix check for empty system_dir | +0 | 2 replies | |
| 3/29 | Remove printing of LCK_CACHEdaemons/ | +2 | 2 replies | |
| 4/29 | Reset vg pointer after releaselib/ | +1 | 1 reply | |
| 5/29 | Test *buf for NULLdaemons/ | +2 | 1 reply | |
| 6/29 | Replace snprintf -> dm_snprintfdaemons/ | +10 | 1 reply | |
| 7/29 | Test success from dm_poll_createlib/ | +8 | 1 reply | |
| 8/29 | Fix memory leak in error pathlib/ | +27 | 1 reply | |
| 9/29 | Remove check for lv is NULLlib/ | +7 | 1 reply | |
| 10/29 | Add some backtrace - Attention pleaselibdm/ | +6 | 1 reply | |
| 11/29 | Add stack trace for error pathlibdm/ | +4 | 1 reply | |
| 12/29 | Add test for 'read' resulttools/ | +7 | 1 reply | |
| 13/29 | Put some FIXME warnings in lvmcache_update_vg processinglib/ | +3 | 0 replies | |
| 13/29 | Put some FIXME warnings in lvmcache_update_vg processing | +0 | 0 replies | |
| 14/29 | Remove unneeded check for NULL pvd->system_idlib/ | +1 | 1 reply | |
| 15/29 | Modify test to catch passing NULL pointerlib/ | +1 | 1 reply | |
| 16/29 | Test uuid for NULLtools/ | +3 | 1 reply | |
| 17/29 | Optimize second call to strchr with same parameterstools/ | +3 | 1 reply | |
| 18/29 | Check result of vginfo_from_vgnamelib/ | +6 | 1 reply | |
| 19/29 | Test for error statusdaemons/ | +4 | 1 reply | |
| 20/29 | Add test for lv_name not NULLtools/ | +1 | 1 reply | |
| 21/29 | Instrument with nonnull dev_manager_transientlib/ | +1 | 1 reply | |
| 22/29 | Ensure pointer first is notnull before dereferencelib/ | +4 | 1 reply | |
| 23/29 | Add test and error message for failure casedaemons/ | +2 | 1 reply | |
| 24/29 | Test for str_list_addlib/ | +8 | 1 reply | |
| 25/29 | Check for unlink resultlib/ | +3 | 2 replies | |
| 25/29 | Check for unlink result | +0 | 0 replies | |
| 26/29 | Add stack traces for dev_set/close_immediate error pathlib/ | +6 | 1 reply | |
| 27/29 | Add standard check for result of lv_info calllib/ | +10 | 1 reply | |
| 27/29 | Add standard check for result of lv_info call | +0 | 0 replies | |
| 28/29 | Check type is not NULL before accesslibdm/ | +6 | 1 reply | |
| 29/29 | Check for NULL pointertools/ | +4 | 1 reply | |
| 29/29 | Check for NULL pointertools/ | +0 | 1 reply | |
| 29/29 | Check for NULL pointer | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/29] Fixes for analyzer problems
Another patchset with fixes based on static analyzer.
Close inspection required for patches:
0010 - Add some backtrace - Attention please
0013 - Put some FIXME warnings in lvmcache_update_vg processing 0026 - Add stack traces for dev_set/close_immediate error path
It's not completly obvious what we should exactly do.
Zdenek Kabelac (29):
Cleanup remove test for NULL
Fix check for empty system_dir
Remove printing of LCK_CACHE
Reset vg pointer after release
Test *buf for NULL
Replace snprintf -> dm_snprintf
Test success from dm_poll_create
Fix memory leak in error path
Remove check for lv is NULL
Add some backtrace - Attention please
Add stack trace for error path
Add test for 'read' result
Put some FIXME warnings in lvmcache_update_vg processing Remove unneeded check for NULL pvd->system_id Modify test to catch passing NULL pointer
Test uuid for NULL
Optimize second call to strchr with same parameters Check result of vginfo_from_vgname
Test for error status
Add test for lv_name not NULL
Instrument with nonnull dev_manager_transient Ensure pointer first is notnull before dereference Add test and error message for failure case Test for str_list_add
Check for unlink result
Add stack traces for dev_set/close_immediate error path Add standard check for result of lv_info call Check type is not NULL before access
Check for NULL pointer
daemons/clvmd/clvmd-command.c | 20 +++++++------- daemons/clvmd/clvmd.c | 9 ++++-- daemons/clvmd/lvm-functions.c | 5 +-- lib/activate/dev_manager.c | 15 +++++----- lib/activate/dev_manager.h | 2 +- lib/cache/lvmcache.c | 6 ++++ lib/commands/toolcontext.c | 2 +- lib/config/config.c | 10 +++++- lib/format1/disk-rep.c | 2 +- lib/format1/format1.c | 8 +++--- lib/format1/import-export.c | 2 +- lib/format_pool/import_export.c | 10 +++++- lib/format_text/archiver.c | 4 ++- lib/format_text/export.c | 56 ++++++++++++++++++-------------------- lib/metadata/lv_manip.c | 8 ++++- lib/metadata/metadata.c | 6 +++- lib/mirror/mirrored.c | 12 +++++++- libdm/ioctl/libdm-iface.c | 15 +++++++--- libdm/libdm-common.c | 14 +++------- libdm/libdm-report.c | 6 ++++ tools/dmsetup.c | 4 ++- tools/lvmcmdline.c | 12 +++++--- tools/reporter.c | 4 +++ tools/toollib.c | 7 +++-- 24 files changed, 143 insertions(+), 96 deletions(-)
Signature · 1 line
1.7.3.2