Skip to content

Fixes for analyzer problems

Zdenek Kabelac lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29Cleanup remove test for NULLlibdm/libdm-common.c+4 -101 reply
2/29Fix check for empty system_dirlib/commands/toolcontext.c+1 -11 reply
2/29Fix check for empty system_dir+0 -02 replies
3/29Remove printing of LCK_CACHEdaemons/clvmd/lvm-functions.c+2 -32 replies
4/29Reset vg pointer after releaselib/metadata/metadata.c+1 -01 reply
5/29Test *buf for NULLdaemons/clvmd/clvmd-command.c+2 -11 reply
6/29Replace snprintf -> dm_snprintfdaemons/clvmd/clvmd-command.c+10 -111 reply
7/29Test success from dm_poll_createlib/config/config.c+8 -21 reply
8/29Fix memory leak in error pathlib/format_text/export.c+27 -291 reply
9/29Remove check for lv is NULLlib/activate/dev_manager.c+7 -81 reply
10/29Add some backtrace - Attention pleaselibdm/ioctl/libdm-iface.c+6 -21 reply
11/29Add stack trace for error pathlibdm/ioctl/libdm-iface.c+4 -31 reply
12/29Add test for 'read' resulttools/lvmcmdline.c+7 -51 reply
13/29Put some FIXME warnings in lvmcache_update_vg processinglib/metadata/metadata.c+3 -20 replies
13/29Put some FIXME warnings in lvmcache_update_vg processing+0 -00 replies
14/29Remove unneeded check for NULL pvd->system_idlib/format1/import-export.c+1 -11 reply
15/29Modify test to catch passing NULL pointerlib/format1/disk-rep.c+1 -11 reply
16/29Test uuid for NULLtools/dmsetup.c+3 -11 reply
17/29Optimize second call to strchr with same parameterstools/toollib.c+3 -21 reply
18/29Check result of vginfo_from_vgnamelib/cache/lvmcache.c+6 -01 reply
19/29Test for error statusdaemons/clvmd/clvmd.c+4 -21 reply
20/29Add test for lv_name not NULLtools/toollib.c+1 -11 reply
21/29Instrument with nonnull dev_manager_transientlib/activate/dev_manager.h+1 -11 reply
22/29Ensure pointer first is notnull before dereferencelib/format1/format1.c+4 -41 reply
23/29Add test and error message for failure casedaemons/clvmd/clvmd.c+2 -11 reply
24/29Test for str_list_addlib/format_pool/import_export.c+8 -21 reply
25/29Check for unlink resultlib/format_text/archiver.c+3 -12 replies
25/29Check for unlink result+0 -00 replies
26/29Add stack traces for dev_set/close_immediate error pathlib/metadata/lv_manip.c+6 -21 reply
27/29Add standard check for result of lv_info calllib/mirror/mirrored.c+10 -21 reply
27/29Add standard check for result of lv_info call+0 -00 replies
28/29Check type is not NULL before accesslibdm/libdm-report.c+6 -01 reply
29/29Check for NULL pointertools/reporter.c+4 -01 reply
29/29Check for NULL pointertools/reporter.c+0 -01 reply
29/29Check for NULL pointer+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/29] Fixes for analyzer problems

Another patchset with fixes based on static analyzer.

Close inspection required for patches:

0010 - Add some backtrace - Attention please
0013 - Put some FIXME warnings in lvmcache_update_vg processing 0026 - Add stack traces for dev_set/close_immediate error path

It's not completly obvious what we should exactly do.

Zdenek Kabelac (29):
Cleanup remove test for NULL
Fix check for empty system_dir
Remove printing of LCK_CACHE
Reset vg pointer after release
Test *buf for NULL
Replace snprintf -> dm_snprintf
Test success from dm_poll_create
Fix memory leak in error path
Remove check for lv is NULL
Add some backtrace - Attention please
Add stack trace for error path
Add test for 'read' result
Put some FIXME warnings in lvmcache_update_vg processing Remove unneeded check for NULL pvd->system_id Modify test to catch passing NULL pointer
Test uuid for NULL
Optimize second call to strchr with same parameters Check result of vginfo_from_vgname
Test for error status
Add test for lv_name not NULL
Instrument with nonnull dev_manager_transient Ensure pointer first is notnull before dereference Add test and error message for failure case Test for str_list_add
Check for unlink result
Add stack traces for dev_set/close_immediate error path Add standard check for result of lv_info call Check type is not NULL before access
Check for NULL pointer

 daemons/clvmd/clvmd-command.c   |   20 +++++++-------
 daemons/clvmd/clvmd.c           |    9 ++++--
 daemons/clvmd/lvm-functions.c   |    5 +--
 lib/activate/dev_manager.c      |   15 +++++-----
 lib/activate/dev_manager.h      |    2 +-
 lib/cache/lvmcache.c            |    6 ++++
 lib/commands/toolcontext.c      |    2 +-
 lib/config/config.c             |   10 +++++-
 lib/format1/disk-rep.c          |    2 +-
 lib/format1/format1.c           |    8 +++---
 lib/format1/import-export.c     |    2 +-
 lib/format_pool/import_export.c |   10 +++++-
 lib/format_text/archiver.c      |    4 ++-
 lib/format_text/export.c        |   56 ++++++++++++++++++--------------------
 lib/metadata/lv_manip.c         |    8 ++++-
 lib/metadata/metadata.c         |    6 +++-
 lib/mirror/mirrored.c           |   12 +++++++-
 libdm/ioctl/libdm-iface.c       |   15 +++++++---
 libdm/libdm-common.c            |   14 +++-------
 libdm/libdm-report.c            |    6 ++++
 tools/dmsetup.c                 |    4 ++-
 tools/lvmcmdline.c              |   12 +++++---
 tools/reporter.c                |    4 +++
 tools/toollib.c                 |    7 +++--
 24 files changed, 143 insertions(+), 96 deletions(-)
Signature · 1 line
1.7.3.2