Skip to content

forcedeth: Convert to use netdev_<level> and neatening

Joe Perches lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11forcedeth: Change reg_delay arguments and usedrivers/net/forcedeth.c+14 -160 replies
2/11forcedeth: convert dprintk(KERN_DEBUG to netdev_dbgdrivers/net/forcedeth.c+87 -890 replies
3/11forcedeth: Use print_hex_dumpdrivers/net/forcedeth.c+17 -370 replies
4/11forcedeth: Convert remaining dprintk to netdev_dbgdrivers/net/forcedeth.c+12 -190 replies
5/11forcedeth: Use pr_fmt and pr_<level>drivers/net/forcedeth.c+142 -1140 replies
6/11forcedeth: Convert pr_<level> to netdev_<level>drivers/net/forcedeth.c+161 -1320 replies
7/11forcedeth: Add function init_realtek_8211bdrivers/net/forcedeth.c+32 -730 replies
8/11forcedeth: Separate vendor specific initializations into functionsdrivers/net/forcedeth.c+188 -1790 replies
9/11forcedeth: Convert dev_printk(<level> to dev_<level>(drivers/net/forcedeth.c+26 -380 replies
10/11forcedeth: Remove netdev_dbg usesdrivers/net/forcedeth.c+0 -1330 replies
11/11forcedeth: Use netdev_dbg for printk(KERN_DEBUGdrivers/net/forcedeth.c+12 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] forcedeth: Convert to use netdev_<level> and neatening

Some mild restructuring and some generally neatening.

The conversions of dprintk to netdev_dbg in patches 2 and 4 are deleted in patch 10 as these seem to have been used only during initial development and are not normally compiled-in.

Patch 10 may be ignored if desired.

Object size is reduced ~2Kb overall.

$ size drivers/net/forcedeth.o.*
   text	   data	    bss	    dec	    hex	filename
  71739	    336	  17176	  89251	  15ca3	drivers/net/forcedeth.o.new
  73416	    240	  17696	  91352	  164d8	drivers/net/forcedeth.o.old

Joe Perches (11):
forcedeth: Change reg_delay arguments and use
forcedeth: convert dprintk(KERN_DEBUG to netdev_dbg
forcedeth: Use print_hex_dump
forcedeth: Convert remaining dprintk to netdev_dbg
forcedeth: Use pr_fmt and pr_<level>
forcedeth: Convert pr_<level> to netdev_<level>
forcedeth: Add function init_realtek_8211b
forcedeth: Separate vendor specific initializations into functions
forcedeth: Convert dev_printk(<level> to dev_<level>(
forcedeth: Remove netdev_dbg uses
forcedeth: Use netdev_dbg for printk(KERN_DEBUG

 drivers/net/forcedeth.c |  860 ++++++++++++++++++++---------------------------
 1 files changed, 357 insertions(+), 503 deletions(-)
Signature · 1 line
1.7.3.2.245.g03276.dirty