Skip to content

jump label: simplify API

Jason Baron lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2jump label: make enable/disable o(1)include/linux/dynamic_debug.h include/linux/jump_label.h include/linux/jump_label_ref.h +5 more+196 -7916 replies
2/2jump label: introduce unlikely_switch()arch/x86/include/asm/jump_label.h arch/x86/kernel/jump_label.c include/linux/dynamic_debug.h +5 more+53 -650 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH/RFC 0/2] jump label: simplify API

Hi,

The first patch uses the storage space of the jump label key address as a pointer into the update table. In this way, we can find all the addresses that need to be updated without hashing.

The second patch introduces:

static __always_inline bool unlikely_switch(struct jump_label_key *key);

instead of the old JUMP_LABEL(key, label) macro.

In this way, jump labels become really easy to use:

Define:

	struct jump_label_key jump_key;

Can be used as:

if (unlikely_switch(&jump_key))
do unlikely code

enable/disale via:

	jump_label_enable(&jump_key);
	jump_label_disable(&jump_key);

that's it!

Thanks to H. Peter Anvin for suggesting the simpler 'unlikely_switch()' function.

thanks,

-Jason

Jason Baron (2):
jump label: make enable/disable o(1)
jump label: introduce unlikely_switch()

 arch/x86/include/asm/jump_label.h |   22 +++--
 arch/x86/kernel/jump_label.c      |    2 +-
 include/linux/dynamic_debug.h     |   24 ++----
 include/linux/jump_label.h        |   72 ++++++++++-------
 include/linux/jump_label_ref.h    |   41 ++++++----
 include/linux/perf_event.h        |   25 +++---
 include/linux/tracepoint.h        |    8 +-
 kernel/jump_label.c               |  159 ++++++++++++++++++++++++++++++-------
 kernel/perf_event.c               |    4 +-
 kernel/tracepoint.c               |   22 ++---
 10 files changed, 243 insertions(+), 136 deletions(-)