Skip to content

RFC Change page reference hanlding semantic of page cache

Minchan Kim linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drop page reference on remove_from_page_cachemm/filemap.c+12 -01 reply
2/5fuse: Remove unnecessary page releasefs/fuse/dev.c+0 -11 reply
3/5tlbfs: Remove unnecessary page releasefs/hugetlbfs/inode.c+0 -13 replies
4/5swap: Remove unnecessary page releasemm/shmem.c+0 -11 reply
5/5truncate: Remove unnecessary page releasemm/truncate.c+0 -112 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchKAMEZAWA Hiroyuki
1/5Reviewd-by
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/5] Change page reference hanlding semantic of page cache

I copy description of 1/5.

Now we add page reference on add_to_page_cache but doesn't drop it in remove_from_page_cache. Such asymmetric makes confusing about page reference so that caller should notice it and comment why they release page reference. It's not good API.

Long time ago, Hugh tried it[1] but gave up of reason which reiser4's drop_page had to unlock the page between removing it from page cache and doing the page_cache_release. But now the situation is changed. I think at least things in current mainline doesn't have any obstacles. The problem is fs or somethings out of mainline. If it has done such thing like reiser4, this patch could be a problem.

Do anyone know the such things? Do we care about things out of mainline?

[1] http://lkml.org/lkml/2004/10/24/140

Minchan Kim (5):
drop page reference on remove_from_page_cache
fuse: Remove unnecessary page release
tlbfs: Remove unnecessary page release
swap: Remove unnecessary page release
truncate: Remove unnecessary page release

 fs/fuse/dev.c        |    1 -
 fs/hugetlbfs/inode.c |    1 -
 mm/filemap.c         |   12 ++++++++++++
 mm/shmem.c           |    1 -
 mm/truncate.c        |    1 -
 5 files changed, 12 insertions(+), 4 deletions(-)