Skip to content

Static analyzis set

Zdenek Kabelac lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23Remove dead assignment to thisfddaemons/clvmd/clvmd.c+0 -21 reply
2/23Remove dead assignmenttools/lvscan.c+0 -61 reply
3/23Remove dead assigment of mirr_statelib/mirror/mirrored.c+0 -31 reply
4/23Remove dead assignment of lock_flagsdaemons/clvmd/clvmd-command.c+0 -21 reply
4/23Remove dead assignment of lock_flags+0 -02 replies
5/23Remove dead assignment in vgconvert_singletools/vgconvert.c+1 -31 reply
6/23Log of pthread_join operationdaemons/clvmd/clvmd.c+7 -61 reply
7/23Move lastfd handling into for()daemons/clvmd/clvmd.c+6 -42 replies
7/23Move lastfd handling into for()+0 -01 reply
8/23Fix memory leak in error path of restart_clvmddaemons/clvmd/clvmd-command.c+1 -00 replies
9/23Add test for errors in _setup_tasklib/activate/dev_manager.c+11 -82 replies
9/23Add test for errors in _setup_task+0 -01 reply
10/23Fix memory leak of dev_filter on error pathlib/commands/toolcontext.c lib/filters/filter-persistent.c+17 -72 replies
10/23Fix memory leak of dev_filter on error path+0 -01 reply
11/23Add stack traces for archivelib/format_text/archiver.c+6 -30 replies
12/23Add tests for dm_task_set operationsdaemons/dmeventd/libdevmapper-event.c+15 -120 replies
13/23Make it obvious this code is not usedlib/activate/dev_manager.c+2 -00 replies
14/23Add stack trace for backup and backup_removelib/metadata/metadata.c tools/vgrename.c+6 -30 replies
15/23Add test check for find_config_strlib/format_text/import_vsn1.c+2 -22 replies
15/23Add test check for find_config_str+0 -01 reply
16/23Remove check for vg != NULLlib/format_text/import_vsn1.c+6 -80 replies
17/23Add check for dm_snprintf resultlib/locking/cluster_locking.c lib/locking/file_locking.c+20 -101 reply
17/23Add check for dm_snprintf result+0 -01 reply
18/23Return PERCENT_INVALID for error caselib/report/properties.c+9 -62 replies
19/23Warning - dead code problem eliminationdaemons/dmeventd/dmeventd.c+1 -23 replies
20/23exit if lvmchache_init failstools/polldaemon.c+2 -11 reply
21/23Add default error path for get_propertyliblvm/lvm_misc.c+4 -01 reply
22/23Remove dead assignment in dm_event_get_registered_devicedaemons/dmeventd/libdevmapper-event.c+7 -71 reply
23/23Remove dead assignment in vg_split_mdaslib/metadata/metadata.c+2 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/23] Static analyzis set

This is mostly the last bigger patch sets for covering issues reported by Coverity tool.

Few patches needs some closer looking,
Most of them are trivial, but as they may present some forgotten tests or missing code I'm posting them for review.

Zdenek Kabelac (23):
Remove dead assignment to thisfd
Remove dead assignment
Remove dead assigment of mirr_state
Remove dead assignment of lock_flags
Remove dead assignment in vgconvert_single
Log of pthread_join operation
Move lastfd handling into for()
Fix memory leak in error path of restart_clvmd Add test for errors in _setup_task
Fix memory leak of dev_filter on error path
Add stack traces for archive
Add tests for dm_task_set operations
Make it obvious this code is not used
Add stack trace for backup and backup_remove Add test check for find_config_str
Remove check for vg != NULL
Add check for dm_snprintf result
Return PERCENT_INVALID for error case
Warning - dead code problem elimination
exit if lvmchache_init fails
Add default error path for get_property
Remove dead assignment in dm_event_get_registered_device Remove dead assignment in vg_split_mdas

 daemons/clvmd/clvmd-command.c         |    3 +-
 daemons/clvmd/clvmd.c                 |   25 ++++++++++---------
 daemons/dmeventd/dmeventd.c           |    3 +-
 daemons/dmeventd/libdevmapper-event.c |   41 +++++++++++++++++---------------
 lib/activate/dev_manager.c            |   21 ++++++++++------
 lib/commands/toolcontext.c            |    2 +
 lib/filters/filter-persistent.c       |   22 ++++++++++++-----
 lib/format_text/archiver.c            |    9 +++++--
 lib/format_text/import_vsn1.c         |   18 ++++++--------
 lib/locking/cluster_locking.c         |   14 ++++++-----
 lib/locking/file_locking.c            |   16 +++++++++---
 lib/metadata/metadata.c               |    8 +++---
 lib/mirror/mirrored.c                 |    3 --
 lib/report/properties.c               |   15 +++++++-----
 liblvm/lvm_misc.c                     |    4 +++
 tools/lvscan.c                        |    6 -----
 tools/polldaemon.c                    |    3 +-
 tools/vgconvert.c                     |    4 +--
 tools/vgrename.c                      |    6 +++-
 19 files changed, 125 insertions(+), 98 deletions(-)

--
1.7.3.4