Skip to content

world-writable files in sysfs and debugfs

Vasiliy Kulikov linux-arm-kernel linux-media linux-mtd linux-omap linux-scsi lkml netdev platform-driver-x86 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 36 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20mach-omap2: mux: world-writable debugfs filesarch/arm/mach-omap2/mux.c+1 -11 reply
2/20mach-omap2: pm: world-writable debugfs timer filesarch/arm/mach-omap2/pm-debug.c+4 -42 replies
3/20mach-omap2: smartreflex: world-writable debugfs voltage filesarch/arm/mach-omap2/smartreflex.c+2 -23 replies
4/20mach-ux500: mbox-db5500: world-writable sysfs fifo filearch/arm/mach-ux500/mbox-db5500.c+1 -10 replies
5/20leds: lp5521: world-writable sysfs engine* filesdrivers/leds/leds-lp5521.c+7 -70 replies
6/20leds: lp5523: world-writable engine* sysfs filesdrivers/leds/leds-lp5523.c+10 -100 replies
7/20video: sn9c102: world-wirtable sysfs filesdrivers/media/video/sn9c102/sn9c102_core.c+3 -32 replies
8/20mfd: ab3100: world-writable debugfs *_priv filesdrivers/mfd/ab3100-core.c+2 -21 reply
9/20mfd: ab3500: world-writable debugfs register-* filesdrivers/mfd/ab3550-core.c+3 -30 replies
10/20mfd: ab8500: world-writable debugfs register-* filesdrivers/mfd/ab8500-debugfs.c+3 -30 replies
11/20misc: ep93xx_pwm: world-writable sysfs filesdrivers/misc/ep93xx_pwm.c+3 -30 replies
12/20net: can: at91_can: world-writable sysfs filesdrivers/net/can/at91_can.c+1 -110 replies
13/20net: can: janz-ican3: world-writable sysfs termination filedrivers/net/can/janz-ican3.c+1 -11 reply
14/20platform: x86: acer-wmi: world-writable sysfs threeg filedrivers/platform/x86/acer-wmi.c+1 -10 replies
15/20platform: x86: asus_acpi: world-writable procfs filesdrivers/platform/x86/asus_acpi.c+1 -71 reply
16/20platform: x86: tc1100-wmi: world-writable sysfs wireless and jogdial filesdrivers/platform/x86/tc1100-wmi.c+1 -10 replies
17/20rtc: rtc-ds1511: world-writable sysfs nvram filedrivers/rtc/rtc-ds1511.c+1 -10 replies
18/20scsi: aic94xx: world-writable sysfs update_bios filedrivers/scsi/aic94xx/aic94xx_init.c+1 -10 replies
19/20scsi: iscsi: world-writable sysfs priv_sess filedrivers/scsi/scsi_transport_iscsi.c+1 -11 reply
20/20fs: ubifs: world-writable debugfs dump_* filesfs/ubifs/debug.c+3 -31 reply

Reviews trailers per patch

6 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKurt Van DijckCorentin CharyLinus WalleijMauro Carvalho ChehabLuca RisoliaKevin HilmanNishanth MenonMike Christie
SeriesA-b
1/20
2/20A-b
3/20A-b A-b
4/20
5/20
6/20
7/20A-b A-b
8/20
9/20
10/20
11/20
12/20A-b
13/20
14/20
15/20A-b
16/20
17/20
18/20
19/20A-b
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/20] world-writable files in sysfs and debugfs

The search was made with trivial shell commands:

find | xargs grep S_IWUGO
find | xargs grep S_IWOTH

I didn't precisely investigate how exactly one may damage the system/hardware because of issues number, maybe the harm is very limited in case of some of these drivers.

One suspicious file is ./staging/speakup/speakup.h, but it explitly calls macros as world-writable. I didn't check what speakup's world-writable files provide because it requires some knowledge about the hardware.

Vasiliy Kulikov (20):
mach-omap2: mux: world-writable debugfs files
mach-omap2: pm: world-writable debugfs timer files
mach-omap2: smartreflex: world-writable debugfs voltage files
mach-ux500: mbox-db5500: world-writable sysfs fifo file
leds: lp5521: world-writable sysfs engine* files
leds: lp5523: world-writable engine* sysfs files
video: sn9c102: world-wirtable sysfs files
mfd: ab3100: world-writable debugfs *_priv files
mfd: ab3500: world-writable debugfs register-* files
mfd: ab8500: world-writable debugfs register-* files
misc: ep93xx_pwm: world-writable sysfs files
net: can: at91_can: world-writable sysfs files
net: can: janz-ican3: world-writable sysfs termination file
platform: x86: acer-wmi: world-writable sysfs threeg file
platform: x86: asus_acpi: world-writable procfs files
platform: x86: tc1100-wmi: world-writable sysfs wireless and jogdial files
rtc: rtc-ds1511: world-writable sysfs nvram file
scsi: aic94xx: world-writable sysfs update_bios file
scsi: iscsi: world-writable sysfs priv_sess file
fs: ubifs: world-writable debugfs dump_* files

 arch/arm/mach-omap2/mux.c                  |    2 +-
 arch/arm/mach-omap2/pm-debug.c             |    8 ++++----
 arch/arm/mach-omap2/smartreflex.c          |    4 ++--
 arch/arm/mach-ux500/mbox-db5500.c          |    2 +-
 drivers/leds/leds-lp5521.c                 |   14 +++++++-------
 drivers/leds/leds-lp5523.c                 |   20 ++++++++++----------
 drivers/media/video/sn9c102/sn9c102_core.c |    6 +++---
 drivers/mfd/ab3100-core.c                  |    4 ++--
 drivers/mfd/ab3550-core.c                  |    6 +++---
 drivers/mfd/ab8500-debugfs.c               |    6 +++---
 drivers/misc/ep93xx_pwm.c                  |    6 +++---
 drivers/net/can/at91_can.c                 |    2 +-
 drivers/net/can/janz-ican3.c               |    2 +-
 drivers/platform/x86/acer-wmi.c            |    2 +-
 drivers/platform/x86/asus_acpi.c           |    8 +-------
 drivers/platform/x86/tc1100-wmi.c          |    2 +-
 drivers/rtc/rtc-ds1511.c                   |    2 +-
 drivers/scsi/aic94xx/aic94xx_init.c        |    2 +-
 drivers/scsi/scsi_transport_iscsi.c        |    2 +-
 fs/ubifs/debug.c                           |    6 +++---
 20 files changed, 50 insertions(+), 56 deletions(-)

--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments