Skip to content

PV_MIN_SIZE

Zdenek Kabelac lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Add find_config_tree_int64 functionlib/config/config.c lib/config/config.h+8 -00 replies
2/2Replace PV_MIN_SIZE with function pv_min_size()doc/example.conf.in lib/commands/toolcontext.c lib/filters/filter.c +6 more+38 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] PV_MIN_SIZE

Patch which adds parameter for minimal size of device to be usable as PV.

Milan suggested other option to add new filter filter_pv_min_size and keep the rest of the code as is. So pv_min_size() would be used only in filter.c and pvresize & lib/metadata/metadata.c would still use hardcoded define 512KB.

But IMHO this could lead to user confusion as user would be able to create PV which is then invisible because of filter settings. Looks to me more consistent to refuse any operation on such device.

But both ways are valid - we need decision which way to go.

Zdenek Kabelac (2):
Add find_config_tree_int64 function
Replace PV_MIN_SIZE with function pv_min_size()

 doc/example.conf.in              |    5 +++++
 lib/commands/toolcontext.c       |   11 ++++++++++-
 lib/config/config.c              |    6 ++++++
 lib/config/config.h              |    2 ++
 lib/filters/filter.c             |    2 +-
 lib/metadata/metadata-exported.h |    1 -
 lib/metadata/metadata.c          |    6 +++---
 lib/metadata/metadata.h          |    1 -
 lib/misc/lvm-globals.c           |   12 ++++++++++++
 lib/misc/lvm-globals.h           |    5 ++++-
 tools/pvresize.c                 |    6 +++---
 11 files changed, 46 insertions(+), 11 deletions(-)

--
1.7.4