VMState: Port several non-pc devices
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest58 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/58 | vmstate: add VMSTATE_UINT32_EQUALhw/ savevm.c | +25 | 0 replies | |
| 2/58 | vmstate: Fix varrays with uint8 indexeshw/ savevm.c | +5 | 0 replies | |
| 3/58 | vmstate: add UINT32 VARRAYShw/ savevm.c | +13 | 0 replies | |
| 4/58 | vmstate: add VMSTATE_STRUCT_VARRAY_INT32hw/ | +11 | 0 replies | |
| 5/58 | vmstate: add VMSTATE_INT64_ARRAYhw/ | +6 | 0 replies | |
| 6/58 | vmstate: add VMSTATE_STRUCT_VARRAY_UINT32hw/ | +10 | 0 replies | |
| 7/58 | vmstate: Add a way to send a partial arrayhw/ | +9 | 0 replies | |
| 8/58 | vmstate: be able to store/save a pci device from a pointerhw/ | +8 | 1 reply | |
| 9/58 | vmstate: move timers to use test instead of versionhw/ | +12 | 0 replies | |
| 10/58 | vmstate: port adb_kbdhw/ | +14 | 0 replies | |
| 11/58 | vmstate: port adb_mousehw/ | +15 | 0 replies | |
| 12/58 | vmstate: port ads7846hw/ | +18 | 0 replies | |
| 13/58 | vmstate: port m48t59hw/ | +13 | 0 replies | |
| 14/58 | vmstate: port mipsnethw/ | +19 | 0 replies | |
| 15/58 | vmstate: port arm sp804hw/ | +11 | 0 replies | |
| 16/58 | vmstate: port arm_timerhw/ | +14 | 0 replies | |
| 17/58 | vmstate: port sysborg_timerhw/ | +16 | 0 replies | |
| 18/58 | vmstate: port pmtimerhw/ hw/ qemu-timer.h | +27 | 0 replies | |
| 19/58 | vmstate: port syborg_rtchw/ | +12 | 0 replies | |
| 20/58 | vmstate: port pxa2xx_pichw/ | +20 | 3 replies | |
| 21/58 | vmstate: port pxa2xx_keypadhw/ | +17 | 0 replies | |
| 22/58 | vmstate: port pl011hw/ | +25 | 0 replies | |
| 23/58 | vmstate: port armv7m nvichw/ | +14 | 0 replies | |
| 24/58 | vmstate: port stellaris i2chw/ | +17 | 0 replies | |
| 25/58 | vmstate: port stellaris ssi bushw/ | +11 | 0 replies | |
| 26/58 | vmstate: port stellaris syshw/ | +25 | 0 replies | |
| 27/58 | vmstate: port pl022 ssphw/ | +36 | 0 replies | |
| 28/58 | vmstate: port heathrow_pichw/ | +25 | 0 replies | |
| 29/58 | vmstate: port cudahw/ | +46 | 0 replies | |
| 30/58 | vmstate: port stellaris gptmhw/ | +24 | 0 replies | |
| 31/58 | vmstate: port pxa2xx_i2shw/ | +18 | 0 replies | |
| 32/58 | vmstate: port pxa2xx_cmhw/ | +14 | 0 replies | |
| 33/58 | vmstate: port pxa2xx_mmhw/ | +12 | 0 replies | |
| 34/58 | vmstate: port pxa2xx_pmhw/ | +12 | 0 replies | |
| 35/58 | vmstate: port pxa2xx_rtchw/ | +37 | 0 replies | |
| 36/58 | vmstate: port ppce500_pcihw/ | +40 | 0 replies | |
| 37/58 | vmstate: port ppc4xx_pcihw/ | +39 | 0 replies | |
| 38/58 | vmstate: port syborg_pointerhw/ | +28 | 0 replies | |
| 39/58 | vmstate: port stellaris_adchw/ | +34 | 0 replies | |
| 40/58 | vmstate: port syborg_serialhw/ | +18 | 0 replies | |
| 41/58 | vmstate: port syborg_keyboardhw/ | +17 | 0 replies | |
| 42/58 | vmstate: port stellaris gamepadhw/ | +24 | 3 replies | |
| 43/58 | vmstate: stellaris use unused for placeholder entrieshw/ | +1 | 0 replies | |
| 44/58 | pxa2xx_dma: make req array statichw/ | +3 | 0 replies | |
| 45/58 | vmstate: port pxa2xx_dmahw/ | +36 | 0 replies | |
| 46/58 | pxa2xx_lcd: name anonymous structhw/ | +15 | 1 reply | |
| 47/58 | pxa2xx_lcd: up field is used as a bool and migrated as an uint8_thw/ | +1 | 0 replies | |
| 48/58 | vmstate: port pxa2xx_lcdchw/ | +43 | 0 replies | |
| 49/58 | max111x: input field is only used as uint8_thw/ | +1 | 0 replies | |
| 50/58 | vmstate: port max111xhw/ | +17 | 1 reply | |
| 51/58 | nand: pin values are uint8_thw/ hw/ | +5 | 0 replies | |
| 52/58 | vmstate: port nandhw/ | +39 | 0 replies | |
| 53/58 | mac_nvram: size is a size, no need to be a target dependent typehw/ | +1 | 0 replies | |
| 54/58 | vmstate: port mac_nvramhw/ | +11 | 0 replies | |
| 55/58 | piix4: create PIIX4Statehw/ | +17 | 0 replies | |
| 56/58 | vmstate: port piix4hw/ | +11 | 0 replies | |
| 57/58 | mac_dbdma: create DBDMAState instead of passing one array aroundhw/ | +27 | 0 replies | |
| 58/58 | vmstate: port mac_dbdmahw/ | +22 | 1 reply |
Reviews trailers per patch
None of the 58 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Blue Swirl |
|---|---|
| Series | R-b |
| 1/58 | |
| 2/58 | |
| 3/58 | |
| 4/58 | |
| 5/58 | |
| 6/58 | |
| 7/58 | |
| 8/58 | |
| 9/58 | |
| 10/58 | |
| 11/58 | |
| 12/58 | |
| 13/58 | |
| 14/58 | |
| 15/58 | |
| 16/58 | |
| 17/58 | |
| 18/58 | |
| 19/58 | |
| 20/58 | |
| 21/58 | |
| 22/58 | |
| 23/58 | |
| 24/58 | |
| 25/58 | |
| 26/58 | |
| 27/58 | |
| 28/58 | |
| 29/58 | |
| 30/58 | |
| 31/58 | |
| 32/58 | |
| 33/58 | |
| 34/58 | |
| 35/58 | |
| 36/58 | |
| 37/58 | |
| 38/58 | |
| 39/58 | |
| 40/58 | |
| 41/58 | |
| 42/58 | |
| 43/58 | |
| 44/58 | |
| 45/58 | |
| 46/58 | |
| 47/58 | |
| 48/58 | |
| 49/58 | |
| 50/58 | |
| 51/58 | |
| 52/58 | |
| 53/58 | |
| 54/58 | |
| 55/58 | |
| 56/58 | |
| 57/58 | |
| 58/58 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 00/58] VMState: Port several non-pc devices
Hi
This series are split in three parts:
- All VMState changes/fixes are together at the beggining (patches 1-9)
- Devices whose port is trivial: (patches 10-40)
- Devices whose port needs some change in types, or introduce a new struct to include all the device state: rest of patches.
There are three warnings and one error for checpatch. The Last one is a bug on checpatch, as there is no need to put spaces there (and putting params makes the preprecessor choke).
And the other three, we can use worse arguments names or having longer than 80 chars macro definitions.
I think that all are ok.
#31: FILE: hw/hw.h:442:
+#define VMSTATE_VARRAY_UINT32(_field, _state, _field_num, _version, _info, _type) {\
WARNING: line over 80 characters
#23: FILE: hw/hw.h:512:
+#define VMSTATE_STRUCT_VARRAY_INT32(_field, _state, _field_num, _version, _vmsd, _type) { \
#22: FILE: hw/hw.h:522:
+#define VMSTATE_STRUCT_VARRAY_UINT32(_field, _state, _field_num, _version, _vmsd, _type) { \
#41: FILE: hw/hw.h:755:
+ VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
^
None of the patches should be difficult to review/accept.
Please review. Anthony, apply the VMState ones the early possible, as it makes easier to work on other devices.
Later, Juan.
Juan Quintela (58):
vmstate: add VMSTATE_UINT32_EQUAL
vmstate: Fix varrays with uint8 indexes
vmstate: add UINT32 VARRAYS
vmstate: add VMSTATE_STRUCT_VARRAY_INT32
vmstate: add VMSTATE_INT64_ARRAY
vmstate: add VMSTATE_STRUCT_VARRAY_UINT32
vmstate: Add a way to send a partial array
vmstate: be able to store/save a pci device from a pointer
vmstate: move timers to use test instead of version
vmstate: port adb_kbd
vmstate: port adb_mouse
vmstate: port ads7846
vmstate: port m48t59
vmstate: port mipsnet
vmstate: port arm sp804
vmstate: port arm_timer
vmstate: port sysborg_timer
vmstate: port pmtimer
vmstate: port syborg_rtc
vmstate: port pxa2xx_pic
vmstate: port pxa2xx_keypad
vmstate: port pl011
vmstate: port armv7m nvic
vmstate: port stellaris i2c
vmstate: port stellaris ssi bus
vmstate: port stellaris sys
vmstate: port pl022 ssp
vmstate: port heathrow_pic
vmstate: port cuda
vmstate: port stellaris gptm
vmstate: port pxa2xx_i2s
vmstate: port pxa2xx_cm
vmstate: port pxa2xx_mm
vmstate: port pxa2xx_pm
vmstate: port pxa2xx_rtc
vmstate: port ppce500_pci
vmstate: port ppc4xx_pci
vmstate: port syborg_pointer
vmstate: port stellaris_adc
vmstate: port syborg_serial
vmstate: port syborg_keyboard
vmstate: port stellaris gamepad
vmstate: stellaris use unused for placeholder entries
pxa2xx_dma: make req array static
vmstate: port pxa2xx_dma
pxa2xx_lcd: name anonymous struct
pxa2xx_lcd: up field is used as a bool and migrated as an uint8_t
vmstate: port pxa2xx_lcdc
max111x: input field is only used as uint8_t
vmstate: port max111x
nand: pin values are uint8_t
vmstate: port nand
mac_nvram: size is a size, no need to be a target dependent type
vmstate: port mac_nvram
piix4: create PIIX4State
vmstate: port piix4
mac_dbdma: create DBDMAState instead of passing one array around
vmstate: port mac_dbdma
hw/adb.c | 83 +++++--------- hw/ads7846.c | 41 +++---- hw/arm_timer.c | 66 ++++------- hw/armv7m_nvic.c | 39 ++---- hw/cuda.c | 116 +++++++----------- hw/flash.h | 4 +- hw/heathrow_pic.c | 62 ++++------ hw/hw.h | 94 +++++++++++++-- hw/m48t59.c | 36 ++---- hw/mac_dbdma.c | 83 +++++++------ hw/mac_nvram.c | 32 ++--- hw/max111x.c | 51 +++----- hw/mipsnet.c | 53 +++------ hw/nand.c | 79 +++++++------ hw/piix4.c | 44 ++++---- hw/pl011.c | 76 ++++-------- hw/pl022.c | 84 ++++++-------- hw/ppc4xx_pci.c | 80 ++++++------- hw/ppce500_pci.c | 87 ++++++-------- hw/ptimer.c | 59 +++------- hw/pxa2xx.c | 243 +++++++++++++++----------------------- hw/pxa2xx_dma.c | 97 ++++++--------- hw/pxa2xx_keypad.c | 53 +++------ hw/pxa2xx_lcd.c | 138 +++++++++------------- hw/pxa2xx_pic.c | 52 +++----- hw/stellaris.c | 323 +++++++++++++++++--------------------------------- hw/stellaris_input.c | 50 ++++---- hw/syborg_keyboard.c | 57 +++------ hw/syborg_pointer.c | 73 +++++------- hw/syborg_rtc.c | 34 ++---- hw/syborg_serial.c | 60 +++------- hw/syborg_timer.c | 46 +++----- qemu-timer.h | 2 - savevm.c | 25 ++++ 34 files changed, 1048 insertions(+), 1474 deletions(-)
Signature · 1 line
1.7.4