Skip to content

Voice call SS notifications (2nd version)

Andras Domokos ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ssn: remove SSN atomdrivers/atmodem/ssn.c include/ssn.h plugins/calypso.c +12 more+24 -620 replies
2/3ssn: add code and call id to notificationsdrivers/atmodem/ssn.c include/ssn.h src/ofono.h +1 more+15 -121 reply
3/3voicecall: add SSN notifications handlinginclude/types.h src/voicecall.c+239 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Voice call SS notifications (2nd version)

Implementation proposal for handling some of the voice call related Supplementary Services (SS) notifications.

Implementation details:
- removed SSN atom
- expanded the SS notify functions with call number info, useful for modems capable of delivering it in the SS notifications
- expanded the SS callback functions with call number info and service code, useful in demultiplexing when a common callback function is defined for multiple service codes
- added +CSSU and +CSSI type SS notifications handling to the voicecall code

Andras Domokos (3):
ssn: remove SSN atom
ssn: add code and call id to notifications
voicecall: add SSN notifications handling

 drivers/atmodem/ssn.c |    6 +-
 include/ssn.h         |   12 ++--
 include/types.h       |    2 +
 plugins/calypso.c     |    1 -
 plugins/g1.c          |    1 -
 plugins/huawei.c      |    1 -
 plugins/ifx.c         |    1 -
 plugins/isiusb.c      |    1 -
 plugins/linktop.c     |    1 -
 plugins/n900.c        |    1 -
 plugins/phonesim.c    |    1 -
 plugins/ste.c         |    1 -
 plugins/tc65.c        |    1 -
 plugins/u8500.c       |    1 -
 plugins/wavecom.c     |    1 -
 src/ofono.h           |    5 +-
 src/ssn.c             |   66 +++++---------
 src/voicecall.c       |  240 ++++++++++++++++++++++++++++++++++++++++++++++++-
 18 files changed, 272 insertions(+), 71 deletions(-)