Skip to content

Correct transitions for cd change state

Amit Shah qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 11 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Use cdrom_changed to hold all state changes instead of introducing a new variable. (Paolo Bonzini)
- Slightly better comment and commit messages

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cdrom: Allow the TEST_UNIT_READY command after a cdrom changehw/ide/core.c+5 -41 reply
2/2cdrom: Make disc change event visible to guestshw/ide/core.c+42 -50 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan HajnocziPaolo Bonzini
SeriesT-b R-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] Correct transitions for cd change state

Hello,

These two patches fix the cd media size change bugs.

The test scenario is:

1. create an iso image from a file
2. create a second iso image from a bigger file
3. mount 1st cd in guest
4. unmount it
5. change cd via qemu monitor
6. mount 2nd cd
7. copy file on cd to local disk -- shows errors.

v2: Set media_change_notified to 1 if SENSE_UNIT_ATTENTION is not set after migration. This is the only thing needed for migration compat.

v3:
- Use cdrom_changed to hold all state changes instead of introducing a new variable. (Paolo Bonzini)
- Slightly better comment and commit messages

Please apply.

Amit Shah (2):
cdrom: Allow the TEST_UNIT_READY command after a cdrom change
cdrom: Make disc change event visible to guests

 hw/ide/core.c |   56 +++++++++++++++++++++++++++++++++++++++++++++++---------
 1 files changed, 47 insertions(+), 9 deletions(-)
Signature · 1 line
1.7.4