Skip to content

staging: usbip: miscellaneous code cleanup

matt mooney kernel-janitors lkml 1 version Applied

Status from this message: I've applied a number of these patches, care to respin the others and

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 17 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/12staging: usbip: change debug configuration optiondrivers/staging/usbip/Kconfig drivers/staging/usbip/Makefile drivers/staging/usbip/usbip_common.c +1 more+9 -100 replies
2/12staging: usbip: use single version for all modulesdrivers/staging/usbip/stub_main.c drivers/staging/usbip/usbip_common.c drivers/staging/usbip/usbip_common.h +1 more+8 -90 replies
3/12staging: usbip: fix header includesdrivers/staging/usbip/stub.h drivers/staging/usbip/stub_dev.c drivers/staging/usbip/stub_main.c +10 more+41 -272 replies
4/12staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalentdrivers/staging/usbip/stub_dev.c drivers/staging/usbip/stub_main.c drivers/staging/usbip/stub_rx.c +8 more+209 -2913 replies
5/12staging: usbip: remove unnecessary lines and extra return statementsdrivers/staging/usbip/stub.h drivers/staging/usbip/stub_dev.c drivers/staging/usbip/stub_main.c +5 more+17 -420 replies
6/12staging: usbip: stub_main.c: code cleanupdrivers/staging/usbip/stub_main.c+96 -952 replies
7/12staging: usbip: stub_main.c: change __init/__exit prefix and use KMEM_CACHEdrivers/staging/usbip/stub_main.c+6 -70 replies
8/12staging: usbip: usbip_common.c: fix misspelled function namedrivers/staging/usbip/usbip_common.c+3 -30 replies
9/12staging: usbip: edit Kconfig and rename CONFIG optionsdrivers/staging/Makefile drivers/staging/usbip/Kconfig drivers/staging/usbip/Makefile +3 more+36 -341 reply
10/12staging: usbip: stub.h: reorganizedrivers/staging/usbip/stub.h+10 -90 replies
11/12staging: usbip: vhci.h: reorganizedrivers/staging/usbip/vhci.h+5 -30 replies
12/12staging: usbip: usbip_common.h: reorganize and document request headersdrivers/staging/usbip/usbip_common.h+121 -1150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] staging: usbip: miscellaneous code cleanup

Hi Greg,

I am interested in hearing your thoughts on the userspace interface?

Even as is, it definitely needs some work. For one thing I was thinking of removing the debug flag from userspace. The userspace utilites are not using it anyway, and it is not 100% working yet.

Thanks,
matt

matt mooney (12):
staging: usbip: change debug configuration option
staging: usbip: use single version for all modules
staging: usbip: fix header includes
staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_
equivalent
staging: usbip: remove unnecessary lines and extra return statements
staging: usbip: stub_main.c: code cleanup
staging: usbip: stub_main.c: change __init/__exit prefix and use
KMEM_CACHE
staging: usbip: usbip_common.c: fix misspelled function name
staging: usbip: edit Kconfig and rename CONFIG options
staging: usbip: stub.h: reorganize
staging: usbip: vhci.h: reorganize
staging: usbip: usbip_common.h: reorganize and document request
headers

 drivers/staging/Makefile             |    2 +-
 drivers/staging/usbip/Kconfig        |   52 +++---
 drivers/staging/usbip/Makefile       |   11 +-
 drivers/staging/usbip/stub.h         |   29 ++--
 drivers/staging/usbip/stub_dev.c     |   30 ++--
 drivers/staging/usbip/stub_main.c    |  225 ++++++++++++--------------
 drivers/staging/usbip/stub_rx.c      |   29 ++--
 drivers/staging/usbip/stub_tx.c      |   31 ++--
 drivers/staging/usbip/usbip_common.c |  262 ++++++++++++++----------------
 drivers/staging/usbip/usbip_common.h |  302 ++++++++++++++++------------------
 drivers/staging/usbip/usbip_event.c  |    4 +-
 drivers/staging/usbip/vhci.h         |   16 ++-
 drivers/staging/usbip/vhci_hcd.c     |  107 +++++-------
 drivers/staging/usbip/vhci_rx.c      |   37 ++---
 drivers/staging/usbip/vhci_sysfs.c   |   19 +-
 drivers/staging/usbip/vhci_tx.c      |   10 +-
 16 files changed, 541 insertions(+), 625 deletions(-)
Signature · 1 line
1.7.5.1