staging: usbip: miscellaneous code cleanup
Status from this message: I've applied a number of these patches, care to respin the others and
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | staging: usbip: change debug configuration optiondrivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 2/12 | staging: usbip: use single version for all modulesdrivers/ drivers/ drivers/ +1 more | +8 | 0 replies | |
| 3/12 | staging: usbip: fix header includesdrivers/ drivers/ drivers/ +10 more | +41 | 2 replies | |
| 4/12 | staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalentdrivers/ drivers/ drivers/ +8 more | +209 | 3 replies | |
| 5/12 | staging: usbip: remove unnecessary lines and extra return statementsdrivers/ drivers/ drivers/ +5 more | +17 | 0 replies | |
| 6/12 | staging: usbip: stub_main.c: code cleanupdrivers/ | +96 | 2 replies | |
| 7/12 | staging: usbip: stub_main.c: change __init/__exit prefix and use KMEM_CACHEdrivers/ | +6 | 0 replies | |
| 8/12 | staging: usbip: usbip_common.c: fix misspelled function namedrivers/ | +3 | 0 replies | |
| 9/12 | staging: usbip: edit Kconfig and rename CONFIG optionsdrivers/ drivers/ drivers/ +3 more | +36 | 1 reply | |
| 10/12 | staging: usbip: stub.h: reorganizedrivers/ | +10 | 0 replies | |
| 11/12 | staging: usbip: vhci.h: reorganizedrivers/ | +5 | 0 replies | |
| 12/12 | staging: usbip: usbip_common.h: reorganize and document request headersdrivers/ | +121 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/12] staging: usbip: miscellaneous code cleanup
Hi Greg,
I am interested in hearing your thoughts on the userspace interface?
Even as is, it definitely needs some work. For one thing I was thinking of removing the debug flag from userspace. The userspace utilites are not using it anyway, and it is not 100% working yet.
Thanks,
matt
matt mooney (12):
staging: usbip: change debug configuration option
staging: usbip: use single version for all modules
staging: usbip: fix header includes
staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_
equivalent
staging: usbip: remove unnecessary lines and extra return statements
staging: usbip: stub_main.c: code cleanup
staging: usbip: stub_main.c: change __init/__exit prefix and use
KMEM_CACHE
staging: usbip: usbip_common.c: fix misspelled function name
staging: usbip: edit Kconfig and rename CONFIG options
staging: usbip: stub.h: reorganize
staging: usbip: vhci.h: reorganize
staging: usbip: usbip_common.h: reorganize and document request
headers
drivers/staging/Makefile | 2 +- drivers/staging/usbip/Kconfig | 52 +++--- drivers/staging/usbip/Makefile | 11 +- drivers/staging/usbip/stub.h | 29 ++-- drivers/staging/usbip/stub_dev.c | 30 ++-- drivers/staging/usbip/stub_main.c | 225 ++++++++++++-------------- drivers/staging/usbip/stub_rx.c | 29 ++-- drivers/staging/usbip/stub_tx.c | 31 ++-- drivers/staging/usbip/usbip_common.c | 262 ++++++++++++++---------------- drivers/staging/usbip/usbip_common.h | 302 ++++++++++++++++------------------ drivers/staging/usbip/usbip_event.c | 4 +- drivers/staging/usbip/vhci.h | 16 ++- drivers/staging/usbip/vhci_hcd.c | 107 +++++------- drivers/staging/usbip/vhci_rx.c | 37 ++--- drivers/staging/usbip/vhci_sysfs.c | 19 +- drivers/staging/usbip/vhci_tx.c | 10 +- 16 files changed, 541 insertions(+), 625 deletions(-)
Signature · 1 line
1.7.5.1