More gcc 4.6 warnings fixes
Status from this message: Thanks, applied to the trivial patches tree:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
Reviews trailers per patch
3 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell |
|---|---|
| 1/14 | |
| 2/14 | |
| 3/14 | |
| 4/14 | |
| 5/14 | R-b |
| 6/14 | |
| 7/14 | |
| 8/14 | R-b |
| 9/14 | R-b |
| 10/14 | |
| 11/14 | |
| 12/14 | |
| 13/14 | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes
Hi
This series fixes compilation of plain:
./configure
with gcc-4.6.0 on Fedora 15.
Notes:
- linuxload.c: why it define id_change if it never test its value?
git log shows that it has been this way forever
- linux-user/syscall.c: do we want to return an error in the default case? my guess is yes, but ...
- mips: it puts 8 arguments on the stack, but do_syscall() only uses 6.
at least some syscalls uses already 7 arguments, I guess this has never worked before.
- for this kind of warnings, I have added:
(void)unused_var;
We can remove the variable altogether, comment it, use __attribute__(no_warn_unused).
- linux-user, syscall for alpha. can anyone check tat my s/arg1/how/ is the right change. Looking at the normal sigprocmask call emulation, it looks like my change is wright, but one never knows.
Later, Juan.
Juan Quintela (14):
kvm: remove fop write only variable
tcg: define and set call_type only when it is used
flatload: memp was a write-only variable
xen: pentry is not used in this function
linuxload: id_change was a write only variable
flatload: end_code was only used in a debug message
alpha: fn2 was a write only variable
syscall: really return ret code
exec: last_first_tb was only used in !ONLY_USER case
mips: we really need the extra arguments
linux-user: fpu_save_addr is not used
linux-user: syscall should use sanitized arg1
alpha: disp12 is not used for USER emulation
lsi53c895a: current_dev is not used
exec.c | 10 +++++++--- hw/lsi53c895a.c | 2 -- linux-user/flatload.c | 8 ++------ linux-user/linuxload.c | 25 +------------------------ linux-user/main.c | 4 ++++ linux-user/signal.c | 3 ++- linux-user/syscall.c | 10 +++++----- target-alpha/translate.c | 10 +++++++--- target-i386/kvm.c | 3 +-- tcg/tcg.c | 9 +++------ xen-mapcache.c | 3 +-- 11 files changed, 33 insertions(+), 54 deletions(-)
Signature · 1 line
1.7.5.2