Skip to content

x86-64: vsyscall emulation cleanups

Andy Lutomirski lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86-64: Fix outdated comments in vsyscall_64.carch/x86/kernel/vsyscall_64.c+4 -31 reply
2/3x86-64: Clean up vsyscall emulation and remove fixed-address retarch/x86/include/asm/vsyscall.h arch/x86/kernel/vsyscall_64.c arch/x86/kernel/vsyscall_emu_64.S+32 -734 replies
3/3x86-64: Clarify CONFIG_COMPAT_VSYSCALLS textDocumentation/feature-removal-schedule.txt arch/x86/Kconfig+22 -161 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] x86-64: vsyscall emulation cleanups

[cc list trimmed from the previous patches to include only people who seem
like they would care about this round of changes. My apologies if I missed anyone.]

This series applies to the x86/vdso branch of the -tip tree.

Patch 1/3 deletes some very outdated comments in vsyscall_64.c.

Patch 2/3 simplifies the vsyscall emulation int 0xcc mechanism and removes some ret instructions that are (as pointed out by the PaX team) possibly dangerous.

Patch 3/3 fixes what is arguably the most serious problem of all: people thought that CONFIG_COMPAT_VSYSCALLS controlled binary compatibility. It changes the Kconfig short description, help text, and feature removal entry to make it a lot more clear what's going on.

Andy Lutomirski (3):
x86-64: Fix outdated comments in vsyscall_64.c
x86-64: Clean up vsyscall emulation and remove fixed-address ret
x86-64: Clarify CONFIG_COMPAT_VSYSCALLS text

 Documentation/feature-removal-schedule.txt |   11 ++-
 arch/x86/Kconfig                           |   27 +++++----
 arch/x86/include/asm/vsyscall.h            |   10 +++-
 arch/x86/kernel/vsyscall_64.c              |   85 +++++++++-------------------
 arch/x86/kernel/vsyscall_emu_64.S          |   17 +-----
 5 files changed, 58 insertions(+), 92 deletions(-)
Signature · 1 line
1.7.5.2