Skip to content

qemu: remove set but unused variables

Michael S. Tsirkin kvm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ppce500: move device/vendor/class id to qdevhw/ppce500_pci.c+3 -101 reply
2/10usb-ehci: move device/vendor/class id to qdevhw/usb-ehci.c+4 -50 replies
3/10usb-ehci: remove unused variableshw/usb-ehci.c+1 -91 reply
4/10lsi53c895a: remove unused variableshw/lsi53c895a.c+0 -21 reply
5/10wdt: remove unused variableshw/wdt_i6300esb.c+0 -31 reply
6/10kvm: remove unused variableshw/virtio-pci.h target-i386/kvm.c+6 -55 replies
7/10alpha/translate: remve unused variablestarget-alpha/translate.c+1 -21 reply
8/10alpha: remove unused variabletarget-alpha/translate.c+6 -13 replies
9/10exec: remove unused variableexec.c+4 -02 replies
10/10linux-user: remove unused variableslinux-user/flatload.c linux-user/linuxload.c linux-user/main.c +2 more+10 -429 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonIsaku Yamahata
1/10
2/10
3/10
4/10
5/10Acked-off-by
6/10
7/10A-b
8/10A-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] qemu: remove set but unused variables

Switched to FC15 and qemu build with -Werror fails. The reason is that with gcc 4.6.0, -Werror makes the build fail on variables that are set but never used.
XXX: In function ‘xxx’:
XXX:XXX:XX: error: variable ‘xx’ set but not used [-Werror=unused-but-set-variable]

The following patchset removes such variables
from the codebase.

Note: the warning could actually point to a
bug in code. Pls review carefully.

Build tested only.

Signature · 32 lines
MST


Michael S. Tsirkin (10):
  ppce500: move device/vendor/class id to qdev
  usb-ehci: move device/vendor/class id to qdev
  usb-ehci: remove unused variables
  lsi53c895a: remove unused variables
  wdt: remove unused variables
  kvm: remove unused variables
  alpha/translate: remve unused variables
  alpha: remove unused variable
  exec: remove unused variable
  linux-user: remove unused variables

 exec.c                   |    4 ++++
 hw/lsi53c895a.c          |    2 --
 hw/ppce500_pci.c         |   13 +++----------
 hw/usb-ehci.c            |   19 +++++--------------
 hw/virtio-pci.h          |    8 +++++---
 hw/wdt_i6300esb.c        |    3 ---
 linux-user/flatload.c    |   10 ++++++----
 linux-user/linuxload.c   |   25 +------------------------
 linux-user/main.c        |    6 +++---
 linux-user/signal.c      |    5 -----
 linux-user/syscall.c     |    6 ------
 target-alpha/translate.c |   10 +++++++---
 target-i386/kvm.c        |    3 +--
 13 files changed, 35 insertions(+), 79 deletions(-)

-- 
1.7.5.53.gc233e