Skip to content

bluetooth: Use current logging styles

Joe Perches linux-bluetooth linux-wireless lkml netdev 1 version Applied

Status from this message: I applied this one as well. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2bluetooth: Rename function bt_err to bt_to_errnoinclude/net/bluetooth/bluetooth.h net/bluetooth/hci_core.c net/bluetooth/l2cap_core.c +2 more+8 -81 reply
2/2bluetooth: Add bt_printk, convert logging macros to lower casedrivers/bluetooth/ath3k.c drivers/bluetooth/bcm203x.c drivers/bluetooth/bfusb.c +41 more+1136 -11145 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] bluetooth: Use current logging styles
Quoted 9 lines · Marcel Holtmann

I did not know that. Then we might should go ahead and also cleanup the Bluetooth subsystem.

We do use an implied "Bluetooth: " prefix when calling BT_INFO, but that can be easily changed to bt_info() as well since I do not care about that part.

The Bluetooth subsystem has a Linux 2.4 legacy history and a lot of things can be done a lot nicer these days.

Here you go Marcel.

It reduces code/text a couple/few percent too.

Joe Perches (2):
bluetooth: Rename function bt_err to bt_to_errno
bluetooth: Add bt_printk, convert logging macros to lower case

 drivers/bluetooth/ath3k.c          |   48 ++++----
 drivers/bluetooth/bcm203x.c        |   38 +++---
 drivers/bluetooth/bfusb.c          |   94 +++++++-------
 drivers/bluetooth/bluecard_cs.c    |   18 ++--
 drivers/bluetooth/bpa10x.c         |   38 +++---
 drivers/bluetooth/bt3c_cs.c        |   34 +++---
 drivers/bluetooth/btmrvl_debugfs.c |    2 +-
 drivers/bluetooth/btmrvl_main.c    |   74 ++++++------
 drivers/bluetooth/btmrvl_sdio.c    |  112 +++++++++---------
 drivers/bluetooth/btsdio.c         |   26 ++--
 drivers/bluetooth/btuart_cs.c      |   24 ++--
 drivers/bluetooth/btusb.c          |   64 +++++-----
 drivers/bluetooth/btwilink.c       |   34 +++---
 drivers/bluetooth/dtl1_cs.c        |   20 ++--
 drivers/bluetooth/hci_ath.c        |   14 +-
 drivers/bluetooth/hci_bcsp.c       |   58 +++++-----
 drivers/bluetooth/hci_h4.c         |   18 ++--
 drivers/bluetooth/hci_ldisc.c      |   36 +++---
 drivers/bluetooth/hci_ll.c         |   76 ++++++------
 drivers/bluetooth/hci_vhci.c       |    8 +-
 include/net/bluetooth/bluetooth.h  |   11 +-
 net/bluetooth/af_bluetooth.c       |   20 ++--
 net/bluetooth/bnep/core.c          |   26 ++--
 net/bluetooth/bnep/netdev.c        |   14 +-
 net/bluetooth/bnep/sock.c          |   10 +-
 net/bluetooth/cmtp/capi.c          |   46 ++++----
 net/bluetooth/cmtp/core.c          |   30 +++---
 net/bluetooth/cmtp/sock.c          |   10 +-
 net/bluetooth/hci_conn.c           |   52 ++++----
 net/bluetooth/hci_core.c           |  142 +++++++++++-----------
 net/bluetooth/hci_event.c          |  234 ++++++++++++++++++------------------
 net/bluetooth/hci_sock.c           |   26 ++--
 net/bluetooth/hci_sysfs.c          |   12 +-
 net/bluetooth/hidp/core.c          |   50 ++++----
 net/bluetooth/hidp/sock.c          |   10 +-
 net/bluetooth/l2cap_core.c         |  172 +++++++++++++-------------
 net/bluetooth/l2cap_sock.c         |   40 +++---
 net/bluetooth/lib.c                |   23 ++++-
 net/bluetooth/mgmt.c               |   80 ++++++------
 net/bluetooth/rfcomm/core.c        |  152 ++++++++++++------------
 net/bluetooth/rfcomm/sock.c        |   56 +++++-----
 net/bluetooth/rfcomm/tty.c         |  100 ++++++++--------
 net/bluetooth/sco.c                |   84 +++++++-------
 net/bluetooth/smp.c                |   30 +++---
 44 files changed, 1144 insertions(+), 1122 deletions(-)
Signature · 1 line
1.7.6.rc1