Skip to content

RFC: Common functions for GEM offset creation

Rob Clark dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/gem: add functions for mmap offset creationdrivers/gpu/drm/drm_gem.c include/drm/drmP.h+91 -00 replies
2/3drm/i915: use common functions for mmap offset creationdrivers/gpu/drm/i915/i915_gem.c+2 -830 replies
3/3drm/gma500: use common functions for mmap offset creationdrivers/staging/gma500/psb_gem.c+2 -610 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] RFC: Common functions for GEM offset creation

In the process of adding GEM support for OMAP DRM driver, I noticed that I was adding code for creating/freeing mmap offsets which was virtually identical to what was already duplicated in i915 and gma500 drivers.

Rather than duplicating the code a 3rd time, it seemed like a good idea to move it to the GEM core.

Note that I don't actually have a way to test psb or i915, but the changes seem straightforward enough.

--

For the curious, OMAP DRM driver is here:
https://github.com/robclark/kernel-omap4/commits/linux-omap-3.0-drm

I'll send patches when it's dependencies are merged and it is slightly more than half baked ;-)

Rob Clark (3):
drm/gem: add functions for mmap offset creation drm/i915: use common functions for mmap offset creation drm/gma500: use common functions for mmap offset creation

 drivers/gpu/drm/drm_gem.c        |   88 ++++++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_gem.c  |   85 +-----------------------------------
 drivers/staging/gma500/psb_gem.c |   63 +--------------------------
 include/drm/drmP.h               |    3 +
 4 files changed, 95 insertions(+), 144 deletions(-)
Signature · 1 line
1.7.4.1