Skip to content

balloon: cleanups, fix segfault

Amit Shah qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7balloon: Make functions, local vars staticballoon.c balloon.h+11 -150 replies
2/7balloon: Add braces around if statementsballoon.c+4 -30 replies
3/7balloon: Simplify code flowballoon.c+7 -90 replies
4/7virtio-balloon: Separate status handling into separate functionhw/virtio-balloon.c+31 -200 replies
5/7balloon: Separate out stat and balloon handlingballoon.c balloon.h hw/virtio-balloon.c+17 -153 replies
6/7balloon: Fix header comment; add Copyrightballoon.c+3 -20 replies
7/7virtio-balloon: Fix header comment; add Copyrighthw/virtio-balloon.c+3 -10 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarkus Armbruster
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault

'balloon 0' in the monitor causes a segfault. This happens because the function that handles change in balloon values is also tasked with handling stats retrieval from the guest, and it does the retrieval when the balloon target is '0'.

Silly API, replace it. Also do a few cleanups along the way.

Amit Shah (7):
balloon: Make functions, local vars static
balloon: Add braces around if statements
balloon: Simplify code flow
virtio-balloon: Separate status handling into separate function
balloon: Separate out stat and balloon handling
balloon: Fix header comment; add Copyright
virtio-balloon: Fix header comment; add Copyright

 balloon.c           |   47 +++++++++++++++++++++------------------
 balloon.h           |   12 ++++------
 hw/virtio-balloon.c |   60 +++++++++++++++++++++++++++++---------------------
 3 files changed, 65 insertions(+), 54 deletions(-)
Signature · 1 line
1.7.6