Skip to content

dmaengine/amba-pl08x updates

Viresh Kumar linux-arm-kernel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest20 patches 2 repliesIn review
  2. v220 patches 14 repliesSuperseded
  3. v118 patches 83 repliesSuperseded

Changes in v3 from the cover letter

- Fix issues in "support runtime PM" patch, and move runtime_get and put routines to more suitable positions.
- Reformat debug message in "Changing few prints to dev_dbg from dev_info"
- set total_len = 0, for each dsg

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20ARM: asm/pl080.h: Protect against multiple inclusion of header filearch/arm/include/asm/hardware/pl080.h+4 -00 replies
2/20dmaengine/amba-pl08x: Resolve formatting issuesdrivers/dma/amba-pl08x.c+16 -250 replies
3/20dmaengine/amba-pl08x: Rearrange inclusion of header files in ascending orderdrivers/dma/amba-pl08x.c+8 -90 replies
4/20dmaengine/amba-pl08x: pass (*ptr) to sizeof() instead of (struct xyz)drivers/dma/amba-pl08x.c+4 -40 replies
5/20dmaengine/amba-pl08x: Complete doc comment for struct pl08x_txdinclude/linux/amba/pl08x.h+8 -00 replies
6/20dmaengine/amba-pl08x: Remove redundant comment and rewrite originaldrivers/dma/amba-pl08x.c+7 -80 replies
7/20dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev_infodrivers/dma/amba-pl08x.c+3 -40 replies
8/20dmaengine/amba-pl08x: support runtime PMdrivers/dma/amba-pl08x.c+12 -00 replies
9/20dmaengine/amba-pl08x: Simplify pl08x_ensure_on()drivers/dma/amba-pl08x.c+1 -70 replies
10/20dmaengine/amba-pl08x: No need to check "ch->signal < 0"drivers/dma/amba-pl08x.c+1 -10 replies
11/20dmaengine/amba-pl08x: Schedule tasklet in case of error interruptdrivers/dma/amba-pl08x.c+23 -210 replies
12/20dmaengine/amba-pl08x: Get rid of pl08x_pre_boundary()drivers/dma/amba-pl08x.c include/linux/amba/pl08x.h+17 -1260 replies
13/20dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width (not MIN(width))drivers/dma/amba-pl08x.c+6 -80 replies
14/20dmaengine/amba-pl08x: Add prep_single_byte_llis() routinedrivers/dma/amba-pl08x.c+33 -280 replies
15/20dmaengine/amba-pl08x: Align lli_len to max(src.width, dst.width)drivers/dma/amba-pl08x.c+7 -50 replies
16/20dmaengine/amba-pl08x: Choose peripheral bus as master busdrivers/dma/amba-pl08x.c+6 -160 replies
17/20dmaengine/amba-pl08x: Pass flow controller information with slave channel datadrivers/dma/amba-pl08x.c include/linux/amba/pl08x.h+57 -80 replies
18/20dmaengine/amba-pl08x: Add support for sg len greater than one for slave transfersdrivers/dma/amba-pl08x.c include/linux/amba/pl08x.h+231 -1690 replies
19/20dmaengine/amba-pl08x: Check txd->llis_va before freeing dma_pooldrivers/dma/amba-pl08x.c+2 -10 replies
20/20dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling kfree() directlydrivers/dma/amba-pl08x.c+3 -10 replies

Reviews trailers per patch

11 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus Walleij
SeriesA-b
1/20A-b
2/20
3/20
4/20
5/20
6/20
7/20A-b
8/20
9/20A-b
10/20A-b
11/20
12/20A-b
13/20A-b
14/20
15/20A-b
16/20A-b
17/20
18/20A-b
19/20A-b
20/20A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/20] dmaengine/amba-pl08x updates

This patchset contains patches for ARM's pl08x DMA controller driver. Main changes introduced by this patchset are:
- Formatting fixes
- Logical Fixes
- Support for Peripheral as flow controller
- Support for sg_len to be greater than 1 for slave transfers
- Schedule tasklet for error interrupts
- remove pl08x_pre_boundary() routine
- support for runtime PM
- etc

This patchset is tested on SPEAr600 for following tests:
- memory to memory copy (using drivers/dma/dmatest, upto 16 threads per channel)
- peripheral to memory and vice versa (Peripheral: JPEG)

This was rebased on Vinod's slave-dma.git/next, over following patch:

commit 1ae105aa7416087f2920c35c3cd16831d0d09c9c
Merge: 02f8c6a 5a42fb9
Author: Vinod Koul <[email protected]>
Date: Wed Jul 27 20:43:21 2011 +0530

Merge branch 'next' into for-linus-3.0

Hope i haven't missed any review comments.

Changes Since V2:
- Fix issues in "support runtime PM" patch, and move runtime_get and put routines to more suitable positions.
- Reformat debug message in "Changing few prints to dev_dbg from dev_info"
- set total_len = 0, for each dsg

Changes Since V1:
- Dropped many formatting fixes which were added earlier, as they made things look even bad.
- Fixed tabbing issues in PATCH "Add prep_single_byte_llis() routine"
- Many comments are updated throughout the patchset.
- Fixed interrupt handler to report spurious interrupt for channels which are not used.
- Clk enabling/disabling done via runtime PM
- Complete mask of flow controller is not passed from platform data now, direction is decided at runtime.
- pl08x_free_txd() called with locks.
- Two new patches are added:
- Rearrange inclusion of header files in ascending order
- pass (*ptr) to sizeof() instead of (struct xyz)

Viresh Kumar (20):
ARM: asm/pl080.h: Protect against multiple inclusion of header file dmaengine/amba-pl08x: Resolve formatting issues dmaengine/amba-pl08x: Rearrange inclusion of header files in
ascending order
dmaengine/amba-pl08x: pass (*ptr) to sizeof() instead of (struct xyz) dmaengine/amba-pl08x: Complete doc comment for struct pl08x_txd dmaengine/amba-pl08x: Remove redundant comment and rewrite original dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev_info dmaengine/amba-pl08x: support runtime PM dmaengine/amba-pl08x: Simplify pl08x_ensure_on() dmaengine/amba-pl08x: No need to check "ch->signal < 0" dmaengine/amba-pl08x: Schedule tasklet in case of error interrupt dmaengine/amba-pl08x: Get rid of pl08x_pre_boundary() dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width
(not MIN(width))
dmaengine/amba-pl08x: Add prep_single_byte_llis() routine dmaengine/amba-pl08x: Align lli_len to max(src.width, dst.width) dmaengine/amba-pl08x: Choose peripheral bus as master bus dmaengine/amba-pl08x: Pass flow controller information with slave
channel data
dmaengine/amba-pl08x: Add support for sg len greater than one for
slave transfers
dmaengine/amba-pl08x: Check txd->llis_va before freeing dma_pool dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling
kfree() directly

 arch/arm/include/asm/hardware/pl080.h |    4 +
 drivers/dma/amba-pl08x.c              |  628 ++++++++++++++++-----------------
 include/linux/amba/pl08x.h            |   30 ++-
 3 files changed, 335 insertions(+), 327 deletions(-)
Signature · 1 line
1.7.2.2