Skip to content

RFC Don't include cleaned variables in inherited environment

Joshua Lock bitbake-devel 1 version Applied

Status from this message: Merged to master, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1Ensure only the filtered environment variables are inherited from the OSbin/bitbake-layers lib/bb/cooker.py lib/bb/data.py +1 more+29 -181 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/1] Don't include cleaned variables in inherited environment

Per James Limbouris' report the pristine, saved environment is erroneously added to the data store. This patch fixes this bug by passing a list of the permitted variables to the inheritFromOS method and only inheriting those which appear in the approved list.

Please review the following changes for suitability for inclusion. If you have any objections or suggestions for improvement, please respond to the patches. If you agree with the changes, please provide your Acked-by.

The following changes since commit b3ad7acebfad3063c3364f4492f53b25bf53cf81:

lib/bb/ui/crumbs/hobprefs: fix erroneous save/reparse (2011-08-12 17:48:13 +0100)

are available in the git repository at:
git://github.com/incandescant/bitbake env
https://github.com/incandescant/bitbake/tree/env

Joshua Lock (1):
Ensure only the filtered environment variables are inherited from the
OS

 bin/bitbake-layers |    6 +++---
 lib/bb/cooker.py   |    3 ++-
 lib/bb/data.py     |   15 ++++++++-------
 lib/bb/utils.py    |   23 ++++++++++++++++-------
 4 files changed, 29 insertions(+), 18 deletions(-)
Signature · 1 line
1.7.6