Skip to content

mmc: fixes for aggressive clock gating framework

Mika Westerberg linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 2 repliesIn review

Changes to previous version from the cover letter

* rename clock gating functions
* use mmc_host_clk_hold() and mmc_host_clk_release() to protect the ios updates
* use non-reentrant workqueue instead of the default

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mmc: rename mmc_host_clk_{ungate|gate} to mmc_host_clk_{hold|release}drivers/mmc/core/core.c drivers/mmc/core/host.c drivers/mmc/core/host.h+11 -110 replies
2/3mmc: prevent aggressive clock gating to race with ios updatesdrivers/mmc/core/core.c+29 -20 replies
3/3mmc: use non-reentrant workqueue for clock gatingdrivers/mmc/core/host.c+1 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus Walleij
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] mmc: fixes for aggressive clock gating framework

Hi,

This is an updated series which should fix few races seen when aggressive clock gating is active. The first patch actually just renames the gating functions to make their use-cases a bit more clear.

Second and third patches fix the races itself.

Previous version of the series can be seen here

	http://article.gmane.org/gmane.linux.kernel.mmc/9611

Changes to previous version:
* rename clock gating functions
* use mmc_host_clk_hold() and mmc_host_clk_release() to protect the ios updates
* use non-reentrant workqueue instead of the default

Please review, thanks.

Mika Westerberg (3):
mmc: rename mmc_host_clk_{ungate|gate} to mmc_host_clk_{hold|release}
mmc: prevent aggressive clock gating to race with ios updates
mmc: use non-reentrant workqueue for clock gating

 drivers/mmc/core/core.c |   35 +++++++++++++++++++++++++++++++----
 drivers/mmc/core/host.c |   12 ++++++------
 drivers/mmc/core/host.h |    8 ++++----
 3 files changed, 41 insertions(+), 14 deletions(-)
Signature · 1 line
1.7.5.4