Skip to content

RFC Add update_progress(), divert checkout messages

[email protected] git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2progress: add update_progress()progress.c progress.h+17 -00 replies
2/2unpack-trees: divert check_updates() output via update_progress()unpack-trees.c+23 -70 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJunio C Hamano
1/2Inspired-by
2/2Inspired-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2 RFC] Add update_progress(), divert checkout messages

From: Steffen Daode Nurpmeso <[email protected]>

Whereas only syntactic sugar, i think it's a bit odd that during a checkout which mostly removes files the git-checkout progress displays "Checking out files" all of the time.

There are two solutions to this: either simply change that string to "Updating working tree", which is acceptable to anybody at anytime. Or divert what progress reports to the actual action which is currently performed. This series tries to achieve the latter.

But maybe progress should instead be extended that it could handle a situation like the following directly. I.e., offer an additional start_parted_progress() series, or extend the current one with an additional "signed parted" argument. That update_progress() could then instead be named progress_change_part() or whatever. ?

Updating work tree: removing files (x/y [xy%]) total%
Main-Title Action-title Action-cnt

Steffen Daode Nurpmeso (2):
progress: add update_progress()
unpack-trees: divert check_updates() output via update_progress()

 progress.c     |   15 +++++++++++++++
 progress.h     |    2 ++
 unpack-trees.c |   30 +++++++++++++++++++++++-------
 3 files changed, 40 insertions(+), 7 deletions(-)
Signature · 1 line
1.7.7.rc0.dirty