Skip to content

Remove QEMUFile abuse

Juan Quintela qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wavaudio: Use stdio instead of QEMUFileaudio/wavaudio.c+24 -100 replies
2/3wavcapture: Use stdio instead of QEMUFileaudio/wavcapture.c+34 -141 reply
3/3ds1225y: Use stdio instead of QEMUFilehw/ds1225y.c+16 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] Remove QEMUFile abuse

Hi

v2: Make malc happy release O;-)
- learn how to use fwrite/fread correctly O:-)
- add errno to all error messages
- make checkpatch happy. Except for
WARNING: space prohibited between function name and open parenthesis '('

Please apply.

v1:

QEMUFile is intended to be used only for migration. Change the other three users to use FILE * operations directly. gcc on Fedora 15 complains about fread/write not checking its return value, so I added checks. But in several places only print an error message (there is no error handly that I can hook into). Notice that this is not worse than it is today.

Later, Juan.

Juan Quintela (3):
wavaudio: Use stdio instead of QEMUFile
wavcapture: Use stdio instead of QEMUFile
ds1225y: Use stdio instead of QEMUFile

 audio/wavaudio.c   |   34 ++++++++++++++++++++++++----------
 audio/wavcapture.c |   48 ++++++++++++++++++++++++++++++++++--------------
 hw/ds1225y.c       |   28 ++++++++++++++++------------
 3 files changed, 74 insertions(+), 36 deletions(-)
Signature · 1 line
1.7.6.2