Skip to content

e1000: reset handling

Michael S. Tsirkin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Changes from v1 from the cover letter

- value written was stored in CTRL register so it will be non 0 after reset.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2e1000: minor reset code refactoringhw/e1000.c+46 -460 replies
2/2e1000: CTRL.RST emulationhw/e1000.c+7 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] e1000: reset handling

Here's a fix for e1000 reset as suggested by Andy Gospodarek and Anthony PERARD, written in a way that doesn't require forward declarations, and with reset clearing interrupts.

Changes from v1:
- value written was stored in CTRL register so it will be non 0 after reset.

Notes: some internal state:

    uint32_t rxbuf_size;
    int check_rxov;

isn't cleared in reset need to check that it's ok.

Signature · 1 line
MST