Skip to content

Allow empty prefix

Zdenek Kabelac lvm-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Fix core on buggy config filelibdm/libdm-config.c test/t-000-basic.sh+8 -10 replies
2/3Add find_config_tree_str_allow_emptylib/commands/toolcontext.c lib/config/config.c lib/config/config.h +2 more+28 -80 replies
3/3Change default prefix.doc/example.conf.in lib/config/defaults.h+8 -41 reply
3/3Change default prefix.+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Allow empty prefix

Resolving problem of command like 'lvs/pvs/vgs' were always printing 2 space prefix " " even if user has specified no prefix.

1. fix coredump of lvm if buggy config is read.
(introduced with cascaded patch).

2. For reading empty string introduce find_config_tree_str_allow_empty() and dm_config_tree_find_str_allow_empty().

3. Change default to "" (no prefix) - since that what most users would expect here probably.

Zdenek Kabelac (3):
Fix core on buggy config file
Add find_config_tree_str_allow_empty
Change default prefix.

 doc/example.conf.in        |    6 +++---
 lib/commands/toolcontext.c |    7 ++++---
 lib/config/config.c        |    6 ++++++
 lib/config/config.h        |    2 ++
 lib/config/defaults.h      |    6 +++++-
 libdm/libdevmapper.h       |    2 ++
 libdm/libdm-config.c       |   25 +++++++++++++++++++------
 test/t-000-basic.sh        |    3 +++
 8 files changed, 44 insertions(+), 13 deletions(-)
Signature · 1 line
1.7.6.4