Skip to content

Improve subsections detection

Juan Quintela qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 0 repliesNew
  2. v35 patches 0 repliesSuperseded
  3. v15 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- brown paperbug on qemu_file_skip()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5savevm: teach qemu_fill_buffer to do partial refillssavevm.c+11 -30 replies
2/5savevm: some coding style cleanupssavevm.c+14 -70 replies
3/5savevm: define qemu_get_byte() using qemu_peek_byte()savevm.c+6 -90 replies
4/5savevm: improve subsections detection on loadsavevm.c+75 -350 replies
5/5Revert "savevm: fix corruption in vmstate_subsection_load()."savevm.c+1 -90 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchAnthony Liguori
1/5R-b
2/5R-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/5] Improve subsections detection

Hi

v4:
- brown paperbug on qemu_file_skip()

static void qemu_file_skip(QEMUFile *f, int size)
{
- if (f->buf_index + size < f->buf_size) {

+    if (f->buf_index + size <= f->buf_size) {
        f->buf_index += size;
    }
}

v3:
- fix return value on qemu_get_buffer.

Anthony, all reviewers comments are fixed, please consider to apply.

Later, Juan.

v2:
- rename "used" to "remaining" (Alex suggestion)
- implement qemu_get_{byte,buffer} on top of qemu_peek_{byte, buffer} (Anthony suggestion)
- fix qemu_peek_buffe_logic (Alex discovered the problem)

v1:
This series move the subsections detection code form:
- Look that it starts form 5
To:
- Look that it starts form 5 (SUBSECTION)
- Look at the length
- Look that length is bigger than section name
- Look at the idstr and see that it starts with the subsection name.

Please review.

Later, Juan.

*** BLURB HERE ***

Juan Quintela (5):
savevm: teach qemu_fill_buffer to do partial refills
savevm: some coding style cleanups
savevm: define qemu_get_byte() using qemu_peek_byte()
savevm: improve subsections detection on load Revert "savevm: fix corruption in vmstate_subsection_load()."

 savevm.c |  144 ++++++++++++++++++++++++++++++++++++++++---------------------
 1 files changed, 94 insertions(+), 50 deletions(-)
Signature · 1 line
1.7.6.4