Improve subsections detection
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 0 repliesNew
- v35 patches 0 repliesSuperseded
- v15 patches 5 repliesSuperseded
Changes in v4 from the cover letter
- brown paperbug on qemu_file_skip()
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | savevm: teach qemu_fill_buffer to do partial refillssavevm.c | +11 | 0 replies | |
| 2/5 | savevm: some coding style cleanupssavevm.c | +14 | 0 replies | |
| 3/5 | savevm: define qemu_get_byte() using qemu_peek_byte()savevm.c | +6 | 0 replies | |
| 4/5 | savevm: improve subsections detection on loadsavevm.c | +75 | 0 replies | |
| 5/5 | Revert "savevm: fix corruption in vmstate_subsection_load()."savevm.c | +1 | 0 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Anthony Liguori |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 0/5] Improve subsections detection
Hi
v4:
- brown paperbug on qemu_file_skip()
static void qemu_file_skip(QEMUFile *f, int size)
{
- if (f->buf_index + size < f->buf_size) {
+ if (f->buf_index + size <= f->buf_size) {
f->buf_index += size;
}
}v3:
- fix return value on qemu_get_buffer.
Anthony, all reviewers comments are fixed, please consider to apply.
Later, Juan.
v2:
- rename "used" to "remaining" (Alex suggestion)
- implement qemu_get_{byte,buffer} on top of qemu_peek_{byte, buffer} (Anthony suggestion)
- fix qemu_peek_buffe_logic (Alex discovered the problem)
v1:
This series move the subsections detection code form:
- Look that it starts form 5
To:
- Look that it starts form 5 (SUBSECTION)
- Look at the length
- Look that length is bigger than section name
- Look at the idstr and see that it starts with the subsection name.
Please review.
Later, Juan.
*** BLURB HERE ***
Juan Quintela (5):
savevm: teach qemu_fill_buffer to do partial refills
savevm: some coding style cleanups
savevm: define qemu_get_byte() using qemu_peek_byte()
savevm: improve subsections detection on load Revert "savevm: fix corruption in vmstate_subsection_load()."
savevm.c | 144 ++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 94 insertions(+), 50 deletions(-)
Signature · 1 line
1.7.6.4