udf: Change some KERN_<level>s and logging neatening
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 19 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | udf: Promote some debugging messages to udf_errorfs/ fs/ fs/ | +23 | 2 replies | |
| 2/6 | udf: Rename udf_error to udf_errfs/ fs/ fs/ | +26 | 1 reply | |
| 3/6 | udf: Rename udf_warn to udf_warnfs/ fs/ fs/ +1 more | +15 | 3 replies | |
| 4/6 | udf: Convert printks to pr_<level>fs/ fs/ fs/ +4 more | +77 | 7 replies | |
| 5/6 | udf: Neaten logging output, use vsprintf extension %pVfs/ | +17 | 3 replies | |
| 6/6 | udf: Neaten udf_debug usesfs/ fs/ fs/ +3 more | +50 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | NamJae Jeon |
|---|---|
| 1/6 | Original-patch-by R-b Original-patch-by R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] udf: Change some KERN_<level>s and logging neatening
I reviewed your patch and think it's too large for others to review because it combines multiple things into a single patch.
I think that adding struct super_block * to udb_debug isn't necessary or particularly useful.
Here are the changes to your original patch that I made:
Separate a single large patch into reviewable chunks. Don't convert every message type to udf_<foo>.
Joe Perches (6):
udf: Promote some debugging messages to udf_error
udf: Rename udf_error to udf_err
udf: Rename udf_warn to udf_warn
udf: Convert printks to pr_<level>
udf: Neaten logging output, use vsprintf extension %pV
udf: Neaten udf_debug uses
fs/udf/balloc.c | 14 ++-- fs/udf/directory.c | 8 +- fs/udf/inode.c | 36 ++++----- fs/udf/lowlevel.c | 2 +- fs/udf/misc.c | 24 ++++--- fs/udf/namei.c | 5 +- fs/udf/partition.c | 11 +-- fs/udf/super.c | 214 +++++++++++++++++++++++----------------------------- fs/udf/truncate.c | 21 ++--- fs/udf/udfdecl.h | 35 ++++++--- fs/udf/udftime.c | 3 +- fs/udf/unicode.c | 6 +- 12 files changed, 178 insertions(+), 201 deletions(-)
Signature · 1 line
1.7.6.405.gc1be0