Skip to content

RFC Improve Ceph Qemu+RBD support

Josh Durgin ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 RFC Latest4 patches 13 repliesIn review

Changes in v3 from the cover letter

make <auth> a direct child of <disk> instead of <source> allow secret lookup by UUID or usage
test with fake secret driver
other fixes from Daniel's review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4secret: add Ceph secret typedocs/schemas/secret.rng include/libvirt/libvirt.h.in src/conf/secret_conf.c +2 more+44 -16 replies
2/4storage: add auth to virDomainDiskDefdocs/schemas/domaincommon.rng src/Makefile.am src/conf/domain_conf.c +1 more+145 -93 replies
3/4qemu: pass virConnectPtr into Domain{Attach,Detach}*src/qemu/qemu_command.c src/qemu/qemu_command.h src/qemu/qemu_driver.c +2 more+28 -212 replies
4/4qemu/rbd: improve rbd device specificationsrc/qemu/qemu_command.c tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.args tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml +2 more+268 -11710 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [RFC PATCH v3 0/4] Improve Ceph Qemu+RBD support

The current support for qemu and Ceph RBD (rados block device) has two main deficiencies: authentication doesn't work, and it relies on environment variables (which don't work with latest upstream). This patch set addresses both those problems.

The first two patches update the xml schemas and conf to add a Ceph secret type and to specify authentication information along with the rbd disk.

The next patch passes virConnectPtr into the Domain{Attach,Detach} methods (needed to access secrets while building the qemu command).

The final patch replaces the current RBD qemu code and uses the new conf info to do authentication properly. We still need to make a change there to avoid having the authentication key show up on qemu command line (there are a few ways to do this, which will be discussed in a separate email).

Changes from v2:
make <auth> a direct child of <disk> instead of <source> allow secret lookup by UUID or usage
test with fake secret driver
other fixes from Daniel's review

Changes from v1:
update docs/schemas/{domain,secret}.rng

Josh Durgin (1):
storage: add auth to virDomainDiskDef

Sage Weil (3):
secret: add Ceph secret type
qemu: pass virConnectPtr into Domain{Attach,Detach}* qemu/rbd: improve rbd device specification

 docs/schemas/domaincommon.rng                      |   29 ++
 docs/schemas/secret.rng                            |   10 +
 include/libvirt/libvirt.h.in                       |    3 +
 src/Makefile.am                                    |    3 +-
 src/conf/domain_conf.c                             |  105 +++++++-
 src/conf/domain_conf.h                             |   17 ++
 src/conf/secret_conf.c                             |   23 ++-
 src/conf/secret_conf.h                             |    1 +
 src/qemu/qemu_command.c                            |  289 ++++++++++++--------
 src/qemu/qemu_command.h                            |    3 +-
 src/qemu/qemu_driver.c                             |   17 +-
 src/qemu/qemu_hotplug.c                            |   15 +-
 src/qemu/qemu_hotplug.h                            |    9 +-
 src/secret/secret_driver.c                         |    8 +
 .../qemuxml2argv-disk-drive-network-rbd-auth.args  |    6 +
 .../qemuxml2argv-disk-drive-network-rbd-auth.xml   |   37 +++
 .../qemuxml2argv-disk-drive-network-rbd.args       |    6 +-
 tests/qemuxml2argvtest.c                           |   52 ++++
 18 files changed, 485 insertions(+), 148 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth.xml