Skip to content

param: optional /sys/module/*/parameters

David Decotigny lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v13 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3param: make destroy_params() privateinclude/linux/moduleparam.h kernel/module.c kernel/params.c+9 -180 replies
2/3param: simple refactoringkernel/params.c+45 -480 replies
3/3param: make /sys/module/*/paramaters optionalDocumentation/ABI/stable/sysfs-module Documentation/DocBook/kgdb.tmpl fs/sysfs/Kconfig +2 more+28 -46 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] param: optional /sys/module/*/parameters

Hi,

Thank you Rusty for your review.

Here is the v2. I hope it is easier to understand. It also adds doc for the new Kconfig knob.

Description:

These patches turn /sys/module/*/parameters into an optional feature that can be enabled/disabled at compilation time. The goal is to encourage module developers to expose more of their parameters with fewer hesitations (eg. memory concerns, etc.), as the burden on small systems can now be avoided by disabling /sys/module/*/paramaters/ altogether at compile-time. On larger systems, having more module parameters exposed would help debugging/auditing of live systems.

Regards,

############################################
# Patch Set Summary:

David Decotigny (3):
param: make destroy_params() private
param: simple refactoring
param: make /sys/module/*/paramaters optional

 Documentation/ABI/stable/sysfs-module |    3 +
 Documentation/DocBook/kgdb.tmpl       |    3 +-
 fs/sysfs/Kconfig                      |   15 ++++-
 include/linux/moduleparam.h           |   14 +----
 kernel/module.c                       |    9 +++
 kernel/params.c                       |  108 ++++++++++++++++-----------------
 6 files changed, 82 insertions(+), 70 deletions(-)
Signature · 1 line
1.7.3.1