forcedeth: minor fixes for stats, rmmod, sparse
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 1 replyIn review
- v44 patches 0 repliesSuperseded
- v39 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 8 patches | 5 replies | Superseded |
Changes in v5 from the cover letter
- added patch 1/5 fixing a rmmod race (see description for test details)
- all other patches identical to v4
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | forcedeth: fix race when unloading moduledrivers/ | +1 | 0 replies | |
| 2/5 | forcedeth: Acknowledge only interrupts that are being processeddrivers/ | +8 | 0 replies | |
| 3/5 | forcedeth: remove unneeded stats updatesdrivers/ | +1 | 0 replies | |
| 4/5 | forcedeth: Improve stats countersdrivers/ | +4 | 0 replies | |
| 5/5 | forcedeth: fix a few sparse warnings (variable shadowing)drivers/ | +17 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH net v5 0/5] forcedeth: minor fixes for stats, rmmod, sparse
This is a minor update over v4, re-adding a patch I left aside to study it.
Changes since v4:
- added patch 1/5 fixing a rmmod race (see description for test details)
- all other patches identical to v4
Changes since v3:
- removed feature additions, this leaves minor sparse and stats fixes. Feature additions shipped previously will go to net-next
Changes since v2:
- removed "Fix a race during rmmod of forcedeth" from the series (will look at it separately with original author)
- added "remove unneeded stats updates" and "64-bit stats"
- reordered patches
Changes since v1:
- rebased on top of netdev tip
- do not repeat name of device in netdev_dbg
- do not completely mute TX timeout messages when debug_tx_timeout is not set
- make debug_tx_timeout writable in /sys/module
Note: I am re-submitting "expose module parameters in /sys/module" as
it can be useful in production and I was assured it doesn't add much memory overhead by the sysfs maintainers.
Tested:
16-way x86_64 SMP, dual forcedeth ->
RX bytes:7244556582 (7.2 GB) TX bytes:181904254 (181.9 MB)
############################################
# Patch Set Summary:
David Decotigny (3):
forcedeth: fix race when unloading module
forcedeth: remove unneeded stats updates
forcedeth: fix a few sparse warnings (variable shadowing)
Mandeep Baines (1):
forcedeth: Improve stats counters
Mike Ditto (1):
forcedeth: Acknowledge only interrupts that are being processed
drivers/net/ethernet/nvidia/forcedeth.c | 88 +++++++++++-------------------- 1 files changed, 31 insertions(+), 57 deletions(-)
Signature · 1 line
1.7.3.1