AT91: replace old i2c-at91.c TWI driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest posting 2/24 patches 1 replyIn review
- v11 posting 1/24 patches 0 repliesSuperseded
- v10 posting 2/21 of 4 patches 2 repliesSuperseded
Earlier versions · 8
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v10 posting 1/2 | 4 patches | 0 replies | Superseded | |
| v9 | 4 patches | 2 replies | Superseded | |
| v8 | 7 patches | 0 replies | Superseded | |
| v7 | 5 patches | 11 replies | Superseded | |
| v6 | 5 patches | 0 replies | Superseded | |
| v5 | 4 patches | 1 reply | Superseded | |
| v4 | 4 patches | 2 replies | Superseded | |
| v3 | 4 patches | 19 replies | Superseded |
Changes since v11 from the cover letter
- corrected wrong id_entry on sam9261 twi gpio pdev
Patches in v11 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drivers/i2c/busses/i2c-at91.c: remove old polling driverarch/ drivers/ drivers/ | +0 | 0 replies | |
| 2/4 | Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clkarch/ arch/ arch/ +4 more | +11 | 0 replies | |
| 3/4 | drivers/i2c/busses/i2c-at91.c: add new driverarch/ arch/ drivers/ +2 more | +516 | 0 replies | |
| 4/4 | G45 TWI: remove open drain setting for twi function gpiosarch/ | +0 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Felipe Balbi | Hubert Feurstein | Ludovic Desroches | Nicolas Ferre |
|---|---|---|---|---|
| Series | T-b | R-b | ||
| 1/4 | ||||
| 2/4 | ||||
| 3/4 | R-b | T-b | ||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver
The old driver has two main deficencies:
i) No repeated start (Sr) condiction is possible, this makes it unusable e.g. for most SMBus transfers.
ii) I/O was done with polling/busy waiting what caused over-/underruns
even at light system loads and clock speeds.
The new driver overcomes these deficencies and in addition allows for more than one TWI interface.
A remaining limitation is the fact, that only one repeated start is possible (two concatenated messages). This limitation is imposed by the hardware. However, this should not be a problem as all common i2c-client communication does not rely on more than one repeated start.
Changes since v11:
- corrected wrong id_entry on sam9261 twi gpio pdev
Nikolaus Voss (4):
drivers/i2c/busses/i2c-at91.c: remove old polling driver Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk drivers/i2c/busses/i2c-at91.c: add new driver
G45 TWI: remove open drain setting for twi function gpios
arch/arm/mach-at91/at91rm9200.c | 1 + arch/arm/mach-at91/at91rm9200_devices.c | 9 + arch/arm/mach-at91/at91sam9260.c | 1 + arch/arm/mach-at91/at91sam9261.c | 1 + arch/arm/mach-at91/at91sam9261_devices.c | 9 + arch/arm/mach-at91/at91sam9263.c | 1 + arch/arm/mach-at91/at91sam9g45.c | 2 + arch/arm/mach-at91/at91sam9g45_devices.c | 6 - arch/arm/mach-at91/at91sam9rl.c | 2 + arch/arm/mach-at91/at91sam9x5.c | 3 + arch/arm/mach-at91/include/mach/at91_twi.h | 68 ---- drivers/i2c/busses/Kconfig | 11 +- drivers/i2c/busses/i2c-at91.c | 591 ++++++++++++++++++---------- 13 files changed, 418 insertions(+), 287 deletions(-) delete mode 100644 arch/arm/mach-at91/include/mach/at91_twi.h
Signature · 1 line
1.7.9.5