Skip to content

forcedeth: stats & debug enhancements

David Decotigny lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9forcedeth: Add messages to indicate using MSI or MSI-Xdrivers/net/ethernet/nvidia/forcedeth.c+2 -00 replies
2/9forcedeth: allow to silence "TX timeout" debug messagesdrivers/net/ethernet/nvidia/forcedeth.c+57 -410 replies
3/9forcedeth: expose module parameters in /sys/moduledrivers/net/ethernet/nvidia/forcedeth.c+9 -90 replies
4/9forcedeth: stats for rx_packets based on hardware registersdrivers/net/ethernet/nvidia/forcedeth.c+1 -21 reply
5/9forcedeth: implement ndo_get_stats64() APIdrivers/net/ethernet/nvidia/forcedeth.c+99 -331 reply
6/9forcedeth: account for dropped RX framesdrivers/net/ethernet/nvidia/forcedeth.c+10 -20 replies
7/9forcedeth: new ethtool stat counter for TX timeoutsdrivers/net/ethernet/nvidia/forcedeth.c+6 -00 replies
8/9forcedeth: stats updated with a deferrable timerdrivers/net/ethernet/nvidia/forcedeth.c+1 -10 replies
9/9forcedeth: whitespace/indentation fixesdrivers/net/ethernet/nvidia/forcedeth.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next v1 0/9] forcedeth: stats & debug enhancements

These changes implement the ndo_get_stats64 API and add a few more stats and debugging features for forcedeth. They also ensure that stats updates are correct in SMP systems, 32 or 64-bits.

Regarding the "implement ndo_get_stats64() API" patch, I'm not sure I'm using the right way to protect the 64b stats. Ideally, I would like them to be non-blocking (u64_stats_sync.h), but as there are several sources for updates, I don't think I can do without locking or per-CPU stats. Would per-CPU stats be better here (note: I expect the contention on netdev_priv(dev)->stats_lock to be _VERY_ low)?

Tested:
~150Mbps incoming TCP, ethtool -S in a loop, x86_64 16-way:

     tx_bytes: 1413863329
     rx_packets: 38918872
     tx_packets: 19828148
     rx_bytes: 57818685991

############################################
# Patch Set Summary:

David Decotigny (6):
forcedeth: expose module parameters in /sys/module
forcedeth: stats for rx_packets based on hardware registers
forcedeth: implement ndo_get_stats64() API
forcedeth: account for dropped RX frames
forcedeth: stats updated with a deferrable timer
forcedeth: whitespace/indentation fixes

Mike Ditto (1):
forcedeth: Add messages to indicate using MSI or MSI-X

Sameer Nanda (2):
forcedeth: allow to silence "TX timeout" debug messages
forcedeth: new ethtool stat counter for TX timeouts

 drivers/net/ethernet/nvidia/forcedeth.c |  271 +++++++++++++++++++++----------
 1 files changed, 184 insertions(+), 87 deletions(-)
Signature · 1 line
1.7.3.1