Skip to content

staging: tidspbridge: clean up drv_interface.c

Víctor Manuel Jáquez Leal linux-omap lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 3 repliesIn review
  2. v15 patches 11 repliesSuperseded

Changes in v2 from the cover letter

* Removed changes in lines with pr_* and dbg_*, so Joe Perches could apply his patches for the format string without big rebases.
* Reviewed the modifications done by Lindent
* Added a clean up to the function bridge_mmap()
* Added a patch removing a unused global variable (driver_name)
* Added a patch that removes an always-true assert

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8staging: tidspbridge: more readable codedrivers/staging/tidspbridge/rmgr/drv_interface.c+6 -70 replies
2/8staging: tidspbridge: remove unused headerdrivers/staging/tidspbridge/rmgr/drv_interface.c drivers/staging/tidspbridge/rmgr/drv_interface.h+155 -1860 replies
3/8staging: tidspbridge: Lindent to drv_interface.cdrivers/staging/tidspbridge/rmgr/drv_interface.c+6 -60 replies
4/8staging: tidspbridge: silence the compilerdrivers/staging/tidspbridge/rmgr/drv_interface.c+3 -23 replies
4/8staging: tidspbridge: silence the compilerdrivers/staging/tidspbridge/rmgr/drv_interface.c+3 -20 replies
5/8staging: tidspbridge: remove header inclusionsdrivers/staging/tidspbridge/rmgr/drv_interface.c+0 -70 replies
6/8staging: tidspbridge: remove trivial assertdrivers/staging/tidspbridge/rmgr/drv_interface.c+1 -30 replies
7/8staging: tidspbridge: clean up bridge_mmap()drivers/staging/tidspbridge/rmgr/drv_interface.c+2 -30 replies
8/8staging: tidspbridge: use the driver name stringdrivers/staging/tidspbridge/rmgr/drv_interface.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] staging: tidspbridge: clean up drv_interface.c

I'm trying to learn how to contribute to the kernel and dsp/bridge is a module that I have used for a while.

These patches are the result of this first effort. It is a clean up of the file drv_interface.c which is the entry point of the kernel module.

Thanks

v2:

* Removed changes in lines with pr_* and dbg_*, so Joe Perches could apply his patches for the format string without big rebases.
* Reviewed the modifications done by Lindent
* Added a clean up to the function bridge_mmap()
* Added a patch removing a unused global variable (driver_name)
* Added a patch that removes an always-true assert

vmjl

Víctor Manuel Jáquez Leal (8):
staging: tidspbridge: more readable code
staging: tidspbridge: remove unused header
staging: tidspbridge: Lindent to drv_interface.c
staging: tidspbridge: silence the compiler
staging: tidspbridge: remove header inclusions
staging: tidspbridge: remove trivial assert
staging: tidspbridge: clean up bridge_mmap()
staging: tidspbridge: use the driver name string

 drivers/staging/tidspbridge/rmgr/drv_interface.c |  348 ++++++++++-----------
 drivers/staging/tidspbridge/rmgr/drv_interface.h |   28 --
 2 files changed, 166 insertions(+), 210 deletions(-)
 delete mode 100644 drivers/staging/tidspbridge/rmgr/drv_interface.h
Signature · 1 line
1.7.8.3